From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 17798 invoked from network); 5 Apr 2022 16:01:18 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 5 Apr 2022 16:01:18 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1649174478; b=r0cqG4o7Q6VgakwtH6CEiGt2Dda1M7a5kc0QMbiSS6T1hFqf9n9CHEP1jm1RYaG7m0OXPinSKb vgH3BaojxmJrmptwDvQ2SoFZ9hVXP0BSpxh6MZehKKlZOOKDM8di2MrouiFjPPUcIwSujKC4MB G4KWqNYsiSXAnNdISfxTOE5NKL9unkm6BAJUJe+NO9I/EyDF3nk441eyGZCVxk8hBOvgEpoWXF HLVnG+h7qR6mbDr1yHH5HWwKJsdMORbPxUOWNnQPDI06BpSiSYW4FmdfcjnGQJ8N13O3VlEfZp vDeXRtjxfTaoLqEomR+rTlHxd+8ZIa7L1k2h6qJbPJNBzA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f48.google.com) smtp.remote-ip=209.85.218.48; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1649174478; bh=wvptyLDk18kKFsVdCPJ8+XwWOwDYDEBUyu9aHBuzbdQ=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=EUIewk6YcP+m03wNh4RNu3NrUVG/Kli+h3im2r8Sfr8dG79mgBhQzIZd+CY7tcv4PFxVi39rek 2wRHbE+dEiSNnfhiabg+8uyS4RglqCyg067/7nHl3GpDcdjrGCXWBBpvt53/DTEO59t7T0v7Z4 fHKEFD0ATkC68DUqhLd1q2FJ/DzrA76CrXn1RzPmBSrOhiFJh0sTvWUe5i+NwIR+lVJvPfcBSJ SGOi92OSR+CHLC15PGx7CPk5qqxJ5Z6KKDBQM+rSjfv49QVLJQ93a8tSX/6tdU2ahHh7j9DRCW uBpgZ1p2OXstPoe55U5YeLOyu/a5wolCm8q7vyamj9G3vA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:To:Subject:Message-ID: Date:From:In-Reply-To:References:MIME-Version:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=A2LjPbPmhLW9iqeYjXXZQ0fJMOFStESW5zy2l8VTe9Y=; b=NuCEOgN0Q7QjPvkCqzY2U36Hpb bD7JSBbx1KDriV83P1oOKG/lASOu9GAga7pAfJEKwOHgj9n9nyzVqJevB0wulSC/trvWWOXfHpMMu r/Jfut+ozI9Ia/puSLotTTDjswsJQxUat8FqHmzi9Vd8wlWJO4PMHE8F169VbpRk2sYo+H4SB/6bk XCedxjJ1swOQf3S1VvPl8qZISIHeP3xWqAcT2ZFPbqbjDEccYkVCIY/ajHSo3zek29rn7dZSYhL7q 2GoFyqmj7CKw2Dz9WatRPxPKIBGj/fTW683OFGV/Rapx2InzGxSbHpynwtcc52jII7KkpCzX5KdLU 3HajeSRQ==; Received: from authenticated user by zero.zsh.org with local id 1nblcK-000J8f-30; Tue, 05 Apr 2022 16:01:16 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f48.google.com) smtp.remote-ip=209.85.218.48; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ej1-f48.google.com ([209.85.218.48]:38726) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1nblbl-000IoN-3h; Tue, 05 Apr 2022 16:00:42 +0000 Received: by mail-ej1-f48.google.com with SMTP id r13so27664146ejd.5 for ; Tue, 05 Apr 2022 09:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=A2LjPbPmhLW9iqeYjXXZQ0fJMOFStESW5zy2l8VTe9Y=; b=w7BY5oO7J8p43tP5szXQKRnFIlyidZ7z8tP/7A3MNrNycyUw8nrCkK3o4CCXFwpkQO vrmOvbmc1x68sKj40pFZF/vUt0FpyIJMf7n9OqMs4jaOAkz+hshd/DlAzY+zORg8xJJz yw0TAY7Rxw/UYRIxywQJsDqCKPSiILQR0jF7FFDeQionx+oYcE2+GTQQLXMxdfwwHUxH 8aqW59eyev8uZtZ6Ki0e40YYML3PZdl+fkJ5Vi4yw8USzJkbYVqoMZ1ajo0clvPyztmK kXV7tF+sCKjk+wssvfiXGgBSb/axPhQ6KBXlUtuDfy/j1A7g/wfpiKIhL1pkwLShTb7M pY4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=A2LjPbPmhLW9iqeYjXXZQ0fJMOFStESW5zy2l8VTe9Y=; b=3HmjfHBXO5m5DuD8nY1pBSWHMEnVKEq6pru64fSE8LVK3a7ItLwioytsizZ4js9R6F 7fqIqoCWa9YO2aSUkhrvCYry8bDdfvDpe+6TMUznLP84KWntRW2WR7QtdHzqYOpZbeyV QL+ezq+xx5Guwaj0aHkfhMAs6A2npdERZJXZo52z8RyJi2zYiK6N5iT+ra2toB/RT44/ dOeruPtWPRzDNFsdEO4g1yMHUtlxLWa0maa9Zeilf/9mBNVXFOAXHc7ch/H264t+FDcF mFznUsGDt0pLa3U/pwe+TFbcszCevTZ5mNS5CL4ktZM72I7ZdgOYe+y+oqPZG3vdSEyK Q6iw== X-Gm-Message-State: AOAM533yaT7Xvr3doKIHSXeSwhqtKIXSe+kDjlHr4YhPw13g4lLVlJo0 Fh2NK0saYkHZTBjTyJgnBlDwohFFZyJmZzZG/A6t57TbfUcmkFgx X-Google-Smtp-Source: ABdhPJw7//yTN7nZTMHwhizWzGOYb5QQ190uj4KKzfP1xw74T6rXVhaXT/53JzZINp5f/sDlzW1LCEZY6/QKSZ+f3WM= X-Received: by 2002:a17:907:7d86:b0:6e4:a344:2162 with SMTP id oz6-20020a1709077d8600b006e4a3442162mr4151933ejc.576.1649174440276; Tue, 05 Apr 2022 09:00:40 -0700 (PDT) MIME-Version: 1.0 References: <1174195730.504727.1649083398497@mail2.virginmedia.com> In-Reply-To: From: Bart Schaefer Date: Tue, 5 Apr 2022 09:00:27 -0700 Message-ID: Subject: Re: Lots of test failures when --disable-multibyte To: Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 49994 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Mon, Apr 4, 2022 at 3:00 PM Bart Schaefer wrote: > > Was testing: Zero-length string match in parameter substitution > > Plus the one immediately after it (Zero-length string match at end). > > I'm going to have to leave those one to someone else. Actually this turned out to be pretty trivial, the git revision on the test cases made it possible to find the previous patches to the multibyte code and then copy to the corresponding spot. diff --git a/Src/glob.c b/Src/glob.c index ca28f20e8..400be12d5 100644 --- a/Src/glob.c +++ b/Src/glob.c @@ -3331,7 +3331,7 @@ igetmatch(char **sp, Patprog p, int fl, int n, char *replstr, /* Largest possible match at tail of string: * * move forward along string until we get a match. * * Again there's no optimisation. */ - for (ioff = 0, t = s, umlen = uml; t < send; + for (ioff = 0, t = s, umlen = uml; t <= send; ioff++, t++, umlen--) { set_pat_start(p, t-s); if (pattrylen(p, t, send - t, umlen, &patstralloc, ioff)) { @@ -3362,7 +3362,7 @@ igetmatch(char **sp, Patprog p, int fl, int n, char *replstr, do { /* loop over all matches for global substitution */ matched = 0; - for (; t < send; t++, ioff++, umlen--) { + for (; t <= send; t++, ioff++, umlen--) { /* Find the longest match from this position. */ set_pat_start(p, t-s); if (pattrylen(p, t, send - t, umlen, &patstralloc, ioff)) {