zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: "Jörg Sommer" <joerg@jo-so.de>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH 1/4] run-help: Support variables in aliases
Date: Wed, 17 May 2023 15:45:47 -0700	[thread overview]
Message-ID: <CAH+w=7aHYfY20w5oLqhj5rvCOnO1agRfg71t0Rn5Qg=B2wC+HQ@mail.gmail.com> (raw)
In-Reply-To: <2322b9b9b46c585516c4347ad3b07a9db26f0a7f.1684361567.git.joerg@jo-so.de>

On Wed, May 17, 2023 at 3:13 PM Jörg Sommer <joerg@jo-so.de> wrote:
>
> If the alias definition starts with a variable assignment, run-help fails,
> because it sees the variable assignment as command. Hence, skip all
> variable assignments and noglob|nocorrect thereafter.

This may not be the right way to handle this.  The same thing is
already being attempted in the block at

    (*)
        if ((! didman++))
        then

where you'll see

                # Discard the command itself & everything before it.

so I would have expected the existing recursive call to cover it.  If
recursion is NOT handling it, then maybe we need to pull that whole
thing up to before the original "whence" command?

Either way, we already have

    (*( is an alias for (noglob|nocorrect))*)

which would be made redundant by your addition of

+            elif [[ $expansion[1] == (noglob|nocorrect) ]]

I repeat my earlier remarks about "reaching the point of diminishing
returns" with our attempts to turn run-help into a full command-line
parser.


  parent reply	other threads:[~2023-05-17 22:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-17 22:12 Jörg Sommer
2023-05-17 22:12 ` [PATCH 2/4] run-help-ip: Reduce the match for link to l Jörg Sommer
2023-05-17 22:12 ` [PATCH 3/4] run-help-openssl: Reduce the code Jörg Sommer
2023-05-17 22:12 ` [PATCH 4/4] run-help for docker, perf, podman, ssh, svnadmin Jörg Sommer
2023-05-31 17:45   ` [PATCH v2] " Jörg Sommer
2023-09-20 22:41     ` Oliver Kiddle
2023-09-23  7:16       ` Jörg Sommer
2023-09-23 15:57         ` Bart Schaefer
2023-09-24  7:31           ` Jörg Sommer
2023-05-17 22:45 ` Bart Schaefer [this message]
2023-05-18  6:52   ` [PATCH 1/4] run-help: Support variables in aliases Jörg Sommer
2023-05-18  9:02   ` Peter Stephenson
2023-05-23 16:25 ` [PATCH v2] run-help-openssl: Reduce code and use new manpages Jörg Sommer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7aHYfY20w5oLqhj5rvCOnO1agRfg71t0Rn5Qg=B2wC+HQ@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=joerg@jo-so.de \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).