From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 23883 invoked from network); 5 Oct 2023 14:32:36 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 5 Oct 2023 14:32:36 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1696516356; b=TunzTMr7a6UTris7iG72Gra1FMBwcFKmXz2UKSwdAI7ua1I0OwZeYQ6XTsThP4HbUVw5EyNg/T rXMoxOZjZN55Rt3Yo6si1eglQigrFA54yOXjgObisCHE2vHa9NRr+/46AWEHzm6fL48jF+HsyV TlOiE+pXiFKyTzwLJuX0hD02m+KhsmvKTnza67+NCcOCImfkpLpr32VsrbcJ/5aLhV15eXeZIq mQssSqQ/bSiXr2MoTLhHVk4ipjhixRHVC9DtedE73+o2pfAAi9g/Sl2emBGGUYf/MOsnoGG70k 8vg9OVty2S3wNtCRyqESeiYWpaZ8uqgOL8p8BoQhqfZ9TQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ed1-f53.google.com) smtp.remote-ip=209.85.208.53; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1696516356; bh=Hqg28UPGam9MpMws96qzYN8Bp2V+CmzP8T+sTou87Zc=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=LB/Q7eR6tBq0qJWcAowO1IutpuVvK/Al0mQPpu5bi/NrGftIG1GIwFVGHzlA08glFYEwmVY3cz qRxK9guMglMr5gtuoFUPdWSPbO4kbNWLJ4Wf5qMoP+ucvkPeTlOi2z0m7VuDiMYCCP7HdzW8CJ 1QXtEglzLpw7Hk6wZ6iup5aVQNDxc6Q39YlqpOEWey5TOPg0txp3v0YkVeGyrVw2P6K+iEhYFU t7gGk7euUIA+f34UtcAvTNYFV5lSFRHMLDTnpoj9qOoHFVnfFuXWIV9V+y7J9m6gDDE23c+rhs g0+h4REbUOm8GoAUfW9H6HcbdpKlCa20vX6mPbQoJ/kclQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=qx2Al3DBmL6FO9/sKzc6hZbLc8D3pm3qlHcwIy5DWso=; b=D0wvAT3JQu98OTG5x5WmoTv0tG uJNRD9pqLvVSd4vUwE1sM+nQcOuCVKsWo2Qzucln7eJXj9hvxNs2RR1dJyKN2Dmh7Pv7gT8SsDkac 2Wi8GTUxImgEHCHXpb9j8QEsQBSIWyJSpP8q5QtrLKPAAN10GX61YtyIkyoqm4SLllunrgWOheVI+ NgpSPgaUzn06YInWwEmA8hJjENNmWqmb+vphLiwbeVNdR6HxQtz4pzFRmyS7Xp2Jp1lJRBD1gZ4dW 2zsCV1xFMSTok3y6pmZ2Ui0AYmtBchKGA1IjJeTsj1t/X6BJ1v2jjVNNqQHtOV2MqIZN0pEeh1ngn fDI4lJvQ==; Received: by zero.zsh.org with local id 1qoPP1-0006zS-0j; Thu, 05 Oct 2023 14:32:35 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ed1-f53.google.com) smtp.remote-ip=209.85.208.53; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ed1-f53.google.com ([209.85.208.53]:60467) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1qoPOM-0006hL-QS; Thu, 05 Oct 2023 14:31:57 +0000 Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-522bd411679so1749559a12.0 for ; Thu, 05 Oct 2023 07:31:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20230601.gappssmtp.com; s=20230601; t=1696516314; x=1697121114; darn=zsh.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qx2Al3DBmL6FO9/sKzc6hZbLc8D3pm3qlHcwIy5DWso=; b=g/O69zLOw4lhKUzDVChUnQ/DA2XGbbktZMgVYsL1DcaLFRUcsv2rM++l/bMC7dHVl0 1ngaddSrQuK8qhNqv/h09luADnuHRzHSciJxb4FqEmogYg3h7U1Yt6bL3inKWKoQbS29 BjD9SN+T+fDGPdpKYS3EDJTijOt6b0oXVaUS/OjGTaqAbkimbXHHimqtxG6IZxyfst7R TGje2h0G05ZBNdVEOq3iu+9P738gwX2jrvGjaqtwfKSyWO4DvYMj0eznVOOgkJF58V48 p2r1P4v5rSgEcpyFkWhEV4QeDaHjV8TIx7QrAY7/8k5mjjfPZvmRw66S0KppSaZr6ekA 9MPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696516314; x=1697121114; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qx2Al3DBmL6FO9/sKzc6hZbLc8D3pm3qlHcwIy5DWso=; b=HyS6LuTI8euP24FIgZTqPNDaI0ecZtuHh3G8LWd+sfPvDnKY+V3cnG6kBauhba+WIv uLLbOSiOw28A4xOJYTkV6EgDlEeySwCX8VpXQ6jzMOvzhz0qiJSwpC36Dm6iN4fSfAaG fG8g7Uc0P14+eyZTCau0JtBRoSTrwnqyD2dFyT7UIr197wJrcPnB7PDFKGmDnKqSGntz OjtCX5kU5XDrTE+GXS+WTHr0bWHHoiKEw556K0xL6hnD03z8kytVDUc81/pfkC/IgOB4 QLff/kYd47iQI1T4/CKjZMjAhzM8tmqcb9xp/U9j7bc/tWcahqvxXQ42vg7buV29xOrK DuIg== X-Gm-Message-State: AOJu0Yw50enn5lyK+3QyuAYBlQC3GG4WW7JJN2pI39LfXVY1Ra8mXf4k aF4wV8saFnscyy6Kci8ESS6/gXZfFlUzi3l2nFaQZvvv0pgfUhi0ugI= X-Google-Smtp-Source: AGHT+IFxpgF2iWuiJy8oiGjXEMUNttjZyM9jeq/t0s+8/+pDRJCIPucr87wDcsUsx3Z8mlvWzTeyJq57rWzsjHiWSIk= X-Received: by 2002:a17:906:1cd:b0:9b2:8fad:2593 with SMTP id 13-20020a17090601cd00b009b28fad2593mr4665065ejj.41.1696516313977; Thu, 05 Oct 2023 07:31:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bart Schaefer Date: Thu, 5 Oct 2023 07:31:42 -0700 Message-ID: Subject: Re: munmap_chunk(): invalid pointer To: Sebastian Gniazdowski Cc: Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 52204 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: My fault, I forgot unmeta() re-uses its zalloc'd buffer. diff --git a/Src/parse.c b/Src/parse.c index f7285c2ed..c0a1e9f95 100644 --- a/Src/parse.c +++ b/Src/parse.c @@ -3421,10 +3421,8 @@ build_dump(char *nam, char *dump, char **files, int ali, int map, int flags) zwarnnam(nam, "can't open file: %s", *files); noaliases = ona; unlink(dump); - zsfree(fnam); return 1; } - zsfree(fnam); file = (char *) zalloc(flen + 1); file[flen] = '\0'; lseek(fd, 0, 0);