From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 3367 invoked from network); 13 Oct 2021 04:58:36 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 13 Oct 2021 04:58:36 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1634101116; b=m27Pd7m0IrU4Tt7RBedH/z8MC5ILWKS7womFyVO5GZPEu983PagAzmOMrs5Zong2NPSQIci+y1 kP3FXyKcTaAtzCr0gYFSb/UKJLKroX02ClP6mgbwkwNrCpNDfMNgmGJY3yO1rPIbTaAUqei7F8 Hh+4m/W1FY/ACK33gEO8RMrwCFWvZZNaVR512xn1SomSguHpJbttRSA+pfSLOSKMuiaSsYRIdl wNp6zhDexmbbIOe7eugYm95ONCHy+raPNcf4bCPPegxOBssJyLOR9cFQG3Fbr1UbCwiYYvw6Uv okDZILFfXQU9hDAIXCfDDIJSzOCmGnW9ZIbJ/n06WJVtfQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-yb1-f171.google.com) smtp.remote-ip=209.85.219.171; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1634101116; bh=dxVCW57uvX2bkTrAHnJwf+obXjLhlfa1NzU7M3JpY10=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=XFLdZwHTwSj7MGGE/gunH5ffDJGwEGjhWtaWei2CPcnFnCbOVG0gl6pRlTYm7yR/5j6fFKqEJd 4L7I2rpqyHvCyUb1NczQMCrFxMa3h7oH9SFIX6dXCNWih0BMAnjW6iDo26ySFcmMZ8bTafUDCi f0JywDGRZuZ4MUyfASg+WRLBhnb6BKU8bpucSiKieb8Z7jkuAgcYMQ1uDvrJomMi+UHFep1QGM 7ayJ8WmKsflhjzH3H9Wi2+qEuof6ufT2E1UM24mRe4CzsMa4TZQ5Jgs4YTYY+RvKOTIGbwKzkQ tL7bvPJ9VerKSZB5sb1iuVfoW15JAGEcsZ+gV/YDMQdmWQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=K9lRwU2gd45rzzWrZGIrWvqt8tLDFWnu0BPqj5z8+V8=; b=o0u0JARP0+fiSDQK9qUOxYnDae WXPVB7dSGpZztKMT13PvQQDPQzUfcd59zv0/xcZk39J6ogjSl8vIIww9k81i3xHqObvAfbIdFBAgM nWpmhKOrTYvBlug+Tt4IT41qEZVNHWN4U/qyD3Sw4xB0xbE4trUY5dDdI6HFN3kv6Wq64AftJqqz7 7v2sb2UugRoB07CZb0JY13eqVxO23A5EUXPk1S4uCSxc8oVn5vA4yiySW7mP/QwfhVDzV0jVNgkXU l6yNY6H8vJSMrVS2A/bTy0mdlf2/QFCH6ApZAL7UuASoOaqcOhVfC5TMBqILHaQg5XQqDwh05FmJV JR61svSg==; Received: from authenticated user by zero.zsh.org with local id 1maWLZ-00085f-Ia; Wed, 13 Oct 2021 04:58:33 +0000 Authentication-Results: zsh.org; iprev=pass (mail-yb1-f171.google.com) smtp.remote-ip=209.85.219.171; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-yb1-f171.google.com ([209.85.219.171]:36687) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1maWL0-0007mg-8j; Wed, 13 Oct 2021 04:57:59 +0000 Received: by mail-yb1-f171.google.com with SMTP id g6so3411563ybb.3 for ; Tue, 12 Oct 2021 21:57:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K9lRwU2gd45rzzWrZGIrWvqt8tLDFWnu0BPqj5z8+V8=; b=b+XNXwJzEyDZSsz+8xRM/w0yH4gipGBmBEymVjdhWz+MiA/6ekD0QwZfaumxLBbTO1 5Jt57Jv6tX6dR+Y9sPL7xg3xsCOpsJNhcTolyymzjp0n3uqckJXmkIJ1n60KFxZ3BwXr oBleGLJeIwM/ckQ2+5OZlsW15Qmdie9EfndHmFYM5ySJ/lYq6V27dKtsYU5CW49YhoeK +pJ4RlDnQDZtGtDMIfXJ9AFRVht1R9tjoE1+CfeUiBgPIgwoMvy/AobYsq/CfBcYFkwT Rscbppg3uhDeX0Jh964wcjpq+WWz1O4b+gPik4TmXV744uTKCaZzfB6E+zjakZnEndWX b4TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K9lRwU2gd45rzzWrZGIrWvqt8tLDFWnu0BPqj5z8+V8=; b=4cWU+h58/gAJ5s38Y7gwufnKIL6STJTBpArn+k4IH4a8zD18Y4GhyW4X8TlCOCZoFn fK5yiUHUZhgXA8TT4zWSwwk3PySP4k1D8JpRo+O1gCN7KfhCCj2C5pVMVHhBe5oIeqpa uzfijeCYfLPXRRksilKKCrgXakhFjM4jWpCnTpHmnzfdez/ZxEcY1f/Z5TpLfcVY9cTQ sd8O6X8cHuYcDn7aN9UUI7WlNizAQJm1bCozHfdLZ014EdvnvxnMKuGm6aPSV0qxY7kS /n+5tko1Dt3dyTNCqj3kBJs7nO33xeuJ4XxVtCQ4b8EFKzezcKzhW/Mfc8vK6fkfdtCZ fLtQ== X-Gm-Message-State: AOAM531ekz+Or1CymlxRhxF1cit05Sd3VuPetmo5zconZBiPhC+P3Tfo g9bZB/bOQpVQ0kHKIRdsj4mzylxyXnPFDYXvCto1lA== X-Google-Smtp-Source: ABdhPJzgC4pBxWYEfr+K9n2NDHKeIStAUupFvTiPOx5VX+KueQ5mnM8dfhx2N5aZs4DMd8kh47SxjliFghs6/pCC3JM= X-Received: by 2002:a25:bd93:: with SMTP id f19mr30464295ybh.23.1634101076765; Tue, 12 Oct 2021 21:57:56 -0700 (PDT) MIME-Version: 1.0 References: <20211012152532.GC17948@tarpaulin.shahaf.local2> In-Reply-To: <20211012152532.GC17948@tarpaulin.shahaf.local2> From: Bart Schaefer Date: Tue, 12 Oct 2021 21:57:45 -0700 Message-ID: Subject: Re: [RFC] Add xfail tests for || form of completion matchers To: Marlon Richert Cc: Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 49478 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Tue, Oct 12, 2021 at 8:26 AM Daniel Shahaf wrote: > > Marlon Richert wrote on Tue, Oct 12, 2021 at 15:08:46 +0300: > > On Mon, Oct 11, 2021 at 5:34 PM Marlon Richert wrote: > > > > I've now added an accompanying documentation update to the patch. > > Could you confirm that the text which the docs patch deletes or changes > was all confirmed correct (even if perhaps unclear)? For example, this part is misleading: > > +By default, characters in the string to be completed (referred to here as the > > +command line) map only onto identical characters in the list of matches [...] > > +missing characters are inserted only at the cursor position, if the shell > > +option tt(COMPLETE_IN_WORD) is set, or at the end of the command line, It's at the end of the current word, not the end of the command line. The old wording nearly always says "string on the command line" which is only somewhat better; if it's going to be completely rewritten to drop "string on the", the phrase "command line" should become more precise. "Incomplete word" perhaps? > > +) requires a var(match-spec) as it argument, consisting of one or more matching "its" > > +corresponding tests are applied to both characters, but they are not otherwise > > +constrained; any matching character in one set goes with any matching character > > +in the other set: this is equivalent to the behaviour of ordinary character > > +classes. What's an "ordinary" character class? That is, what ordinary context is implied? > > +xitem(tt(l:)tt(|)var(lpat)tt(=)var(tpat)) > > +xitem(tt(L:)tt(|)var(lpat)tt(=)var(tpat)) > > +xitem(tt(r:)var(lpat)tt(|)tt(=)var(tpat)) > > +item(tt(R:)var(lpat)tt(|)tt(=)var(tpat))( > > +Let any substring matching var(lpat) at the left (for tt(l:) and tt(L:)) or > > +right (for tt(r:) and tt(R:)) edge of the command line be completed to any Again, not the command line, just the current word under (or to the left of) the cursor, but I'll stop mentioning this because it's a problem with definition of terms. > > +xitem(tt(l:)var(anchor)tt(|)var(lpat)tt(=)var(tpat)) > > +xitem(tt(L:)var(anchor)tt(|)var(lpat)tt(=)var(tpat)) > > +xitem(tt(r:)var(lpat)tt(|)var(anchor)tt(=)var(tpat)) > > +item(tt(R:)var(lpat)tt(|)var(anchor)tt(=)var(tpat))( > > +Let any command line substring, which is left/right-adjacent (respectively) to > > +a substring matching var(anchor) and which matches var(lpat), be completed to > > +any trial completion substring, which > > +startitemize() > > +itemiz(\ > > +is adjacent to the same substring and which Unclear whether "the same substring" refers to "any command line substring" or to "a substring matching anchor". I believe you mean the former (or perhaps the larger substring composed of both of the former)? Best to specify. I believe the rest of the explanations are correct, but it would be good if Oliver confirms. Did you remove the assorted other examples because there is a problem with them?