zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: IS_DASH() warning
Date: Thu, 9 Mar 2017 23:27:36 -0800	[thread overview]
Message-ID: <CAH+w=7aLSXE5wHtnR-FvCJRVc19UC3aDWOrf2O+fjUZeR23csw@mail.gmail.com> (raw)

glob.c:2398:10: warning: comparison of constant -101 with expression of type
      'unsigned char' is always false
      [-Wtautological-constant-out-of-range-compare]
            if (IS_DASH(c1) && lastch >= 0 && p < str2 && lastch <= (int)c2) {
                ^~~~~~~~~~~
./zsh.h:248:39: note: expanded from macro 'IS_DASH'
#define IS_DASH(x) ((x) == '-' || (x) == Dash)
                                  ~~~ ^  ~~~~

(It's complaining about the comparison to Dash if proportional font
misplaces the caret.)


             reply	other threads:[~2017-03-10  7:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170310072841epcas2p2340dcec5f380c88168d615f3df3de89d@epcas2p2.samsung.com>
2017-03-10  7:27 ` Bart Schaefer [this message]
2017-03-10  9:46   ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7aLSXE5wHtnR-FvCJRVc19UC3aDWOrf2O+fjUZeR23csw@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).