zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Oliver Kiddle <opk@zsh.org>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Turning display attributes on / off in prompt strings
Date: Fri, 16 Dec 2022 23:50:03 -0800	[thread overview]
Message-ID: <CAH+w=7aQ+cC26KB5U+0w50XVEp49MnpJrFCT-Eokys7su1azbQ@mail.gmail.com> (raw)
In-Reply-To: <37998-1671237833.378022@KQt2.DuNm.SJtt>

On Fri, Dec 16, 2022 at 4:45 PM Oliver Kiddle <opk@zsh.org> wrote:
>
> Bart Schaefer wrote:
> > you can't mix in "raw" sequences for attributes that prompt.c
> > doesn't "know about"
>
> It can also get confused when you assign the results of ${(%)...} to a
> variable without printing the results.

A consideration is that if we simply replaced $"\e[m' with $'\e[24m'
and so on, the present prompt code would still emit the
then-unnecessary sequences to restore the other attributes.  Is it
worth the effort to rework that?

> I'd be reluctant to create an extra setopt without first having evidence
> that terminals that need it are still in use.

Agreed, I was excerpting Mikael mostly for "would [not] lose a lot of
compatibility".

> And if we need a way to
> override terminal settings, something more generic may be better.

Would populating a writable special hash parameter be a security issue?

As you implied, though, the hash key names could be tricky to choose.


  reply	other threads:[~2022-12-17  7:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-16 19:45 Bart Schaefer
2022-12-17  0:43 ` Oliver Kiddle
2022-12-17  7:50   ` Bart Schaefer [this message]
2022-12-17  9:47     ` Oliver Kiddle
2022-12-17 19:45       ` Bart Schaefer
2022-12-21 16:46         ` Oliver Kiddle
2022-12-21 21:28           ` Bart Schaefer
2022-12-21 17:12 ` Oliver Kiddle
2022-12-21 21:03   ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7aQ+cC26KB5U+0w50XVEp49MnpJrFCT-Eokys7su1azbQ@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=opk@zsh.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).