From: Bart Schaefer <schaefer@brasslantern.com>
To: Roman Perepelitsa <roman.perepelitsa@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: PATCH: bug fix: infinite loop in sysread
Date: Wed, 5 Feb 2020 12:55:37 -0800 [thread overview]
Message-ID: <CAH+w=7aTpOsSMJOoiRnj6mpREfPc8AHJE+Os0FKjuNug23nxMQ@mail.gmail.com> (raw)
In-Reply-To: <CAN=4vMqkV3uf3Ki4221k_HpYaqNmTq_msD7kv_Eg-5rg5=MDhA@mail.gmail.com>
On Wed, Feb 5, 2020 at 6:20 AM Roman Perepelitsa
<roman.perepelitsa@gmail.com> wrote:
>
> Here select() keeps returning 0, indicating timeout. This is not an
> error, so errno doesn't get set. If it was EINTR prior to the call,
> it stays EINTR, and the loop keeps spinning.
>
> The fix is to replace `< 1` with `< 0` in the loop condition.
Wouldn't a better fix be to set errno = 0 before the call?
next prev parent reply other threads:[~2020-02-05 20:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 14:19 Roman Perepelitsa
2020-02-05 20:55 ` Bart Schaefer [this message]
2020-02-05 21:04 ` Roman Perepelitsa
2020-02-06 19:52 ` dana
2020-02-06 20:01 ` Peter Stephenson
2020-02-07 11:26 ` Roman Perepelitsa
2020-02-07 16:49 ` dana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7aTpOsSMJOoiRnj6mpREfPc8AHJE+Os0FKjuNug23nxMQ@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=roman.perepelitsa@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).