From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 71c48078 for ; Thu, 29 Nov 2018 18:39:48 +0000 (UTC) Received: (qmail 17886 invoked by alias); 29 Nov 2018 18:39:36 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43854 Received: (qmail 25032 invoked by uid 1010); 29 Nov 2018 18:39:36 -0000 X-Qmail-Scanner-Diagnostics: from mail-lj1-f194.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.100.2/25112. spamassassin: 3.4.2. Clear:RC:0(209.85.208.194):SA:0(-1.9/5.0):. Processed in 3.594945 secs); 29 Nov 2018 18:39:36 -0000 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t7e2jDH24K4qx7pnC1D4ZTn+sNakvE9D/M+x13yoOZA=; b=RQNUk+KZNPZaUxPqB584qtQsjLjQjrEaFJj2xtt6SZqRe3Zvnmlg1+fz0nBDfhVnjZ 3OPtCFBwbIDVckn/JYPaPjWdGSG7mgXM8DycMm6bK9pQomJ64tXX/P5LSGwn+2+kSuPt MbEF8e9dluMqUtgVyo5DDq4REnDhdwotG5NlmmjDARmZed64upqr+FvxwuMlnTA+lAa1 7xfg3CcBIlr6VZW3zK8hl+3a9Llax6Hq403fFgFaLMlA9i0ge5IfGc50ZQHUKJTZhMt9 zKvh/q+O0XfKe7x87znCsSrhXtwNTSgn5cHLRirP/Q5YkZ+3JoNNyEvHNJURIT1KFjPc f+Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t7e2jDH24K4qx7pnC1D4ZTn+sNakvE9D/M+x13yoOZA=; b=MDex9ZRxoa0VC3TEpmtWuIXPgTQJ62dYZgqMHzzXOOfY8Q5Bg5XsRG73k/m25lOHMl RVVvwg/DjgNLQL38dbP/92f+VdH044PsZZYQjsjXB+zsUMLJChLmPDUECQaGI2tRu3dK /eoJyM/VjWYLgi0X/m6r6dA0PB+Ywvj1XGcGl9K8Z1XlFCvuUM/u/GUZTevwr4TRorWK upTL7x9a/BtJj+yM0gf+TgaldwSfApFE280c1Hr4+8LYxSv9Mel3EEQX6CC89xr24NFv O8cUWMbjyAMG77HATu+sbfMFZ7h6KSo5fZbBrJUOU2pHS+jDfccifarHtf7iLLKmJuzh 0PMA== X-Gm-Message-State: AA+aEWaQdjalnY+nuCoe34reMMFAIbtDTUqLdJYRJeisl8jPqy+tFjye hbYSv/Sl6L9L851+2iNquoBVWwqEIEvn4vpCi5cnkw== X-Google-Smtp-Source: AFSGD/XA+5E47JPrjm+18as59A1KzM0hCi3xvAX395iEuf28FPTFq3UbpARx1rtpPzhP1zTXsbkKee7vC9SppAJ+HIo= X-Received: by 2002:a2e:630a:: with SMTP id x10-v6mr1776450ljb.11.1543516767525; Thu, 29 Nov 2018 10:39:27 -0800 (PST) MIME-Version: 1.0 References: <1429277155-24607-1-git-send-email-kdudka@redhat.com> <1429277155-24607-2-git-send-email-kdudka@redhat.com> <20150417201753.41812294@ntlworld.com> <2172016.U8TV6t29ou@kdudka-nb> <1543512844.6025.28.camel@samsung.com> In-Reply-To: <1543512844.6025.28.camel@samsung.com> From: Bart Schaefer Date: Thu, 29 Nov 2018 10:39:15 -0800 Message-ID: Subject: Re: [PATCH 2/2] clear the heredoc list in case par_event() fails To: Peter Stephenson Cc: "zsh-workers@zsh.org" Content-Type: text/plain; charset="UTF-8" On Thu, Nov 29, 2018 at 9:42 AM Peter Stephenson wrote: > > There's some slightly icky linkage between lex errors and the top level > requiring tok to be LEXERR. The simple fix using the existing > signalling looks like the following. I definitely don't think the tok = > LEXERR has a moral right to percolate through in the way it must > previously have been doing to avoid this, and the lexer does certainly > have the right to update the token when signalling a parse error, so > (famous last words) it's hard to see what could be wrong with this... Might this need to be conditional upon ... something ... so that e.g. ${(z)...} on a malformed here-document doesn't throw an error? I don't have the code handy to poke around.