From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 10367 invoked from network); 5 Nov 2023 21:10:43 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 5 Nov 2023 21:10:43 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1699218643; b=PJ4ljIgosieM6sJ7E7eBsqnVmMN6s9aVPjMis/bc6xgBat7xkmAV9QPc8QEEqWS9IlT0NpoDMS bHoM4smOfkhoIf2YPhh3wvrqKSUXuCp37tXMo6QadaRFxcpdKd3Cls963SYLuhgxga4erlRXgr BWT1U48xjmH6aGPbC7ZUIsLhUbWiU7aWtK/KEcNXCFnuzcr03+WyiEqyd6xMMGaKX0s+XhXRN+ Drs+/+eVpfPPXiItTbexFQWYvlB9Xd5FTaWokJfl5CoQ/n3tnJorVZ52mxaQSOlPaUsCpsDGIx jueADtBY3PUHu8S4135AkAAmsxS8KYfqYhj4NsJyjwwmAg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ed1-f44.google.com) smtp.remote-ip=209.85.208.44; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1699218643; bh=Xc2Ohk30Ac56MDrkdMVh6JuWQvPA1i9Kf1QGrfVGVhg=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=gwELbk2N94qcOuT1ryvOms3bBWs2cko4r2dXcnYEGirLNOBHntsfyo3qI56ke4mQrO8GRv5YYm 2XsnSLsZxPHEo2L/YDrI1RCpyMrGssFqIiSyfQR3PYb6laVDlMq6YGQ4fQ9B24C8l+NsPKf5j1 w1eJT9fQFE/SQbvqHed/Rwp3Tu0XhTXmW9Cad2zt1mBPiCCzLCRiJOeCzJ1B/Ngs6odJ40O7nw 6CaRnyLe13uBNqL4PwFY8YLMIo7xJw2AzVl20KUFODLJ44AzBrUXu+FZvKcw5qWANmrtVROmUQ wKz6I+ctCUrU246cSlgcpKN2YJmXW8UDZuGVg+Qu4qXkug==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=wmufaXyk+qCYJxFl8VKyweKpTEAUI/0WFFMilpKh3xk=; b=MvguQXzhfxPTXF2ezgPbfryMNR YnbSf9+Ix/CDoq4wfsKj9Iip124qXwHdFAXP56VHHzqIkQoqLoiR87aFARaWGWINqauZ3zv0gO60C Dya6Gvmx8jDixAsrt6yWUeUy+2dF2Esw/wf16bDrZf5xXx3y7ZUHm/sC46XK1RgzymgIXs2NQJnCh cCZGREsOPjMZlFymS8OVyViIUgysWmCE1alyTjBo5Mqa/EaT2h9ykXLT86klE6fgj8x9l05S5Hfdp KJmVWhCXroyKoDBJ/I4Bg8sjZjDSQMzLS7c12ntuyAiTwqyBy5zM0FRz3l7qx1RxW4ptVLzRWAcHw 6T6ozsuQ==; Received: by zero.zsh.org with local id 1qzkOG-0001LQ-OG; Sun, 05 Nov 2023 21:10:40 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ed1-f44.google.com) smtp.remote-ip=209.85.208.44; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ed1-f44.google.com ([209.85.208.44]:51353) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1qzkNu-00013R-Ae; Sun, 05 Nov 2023 21:10:19 +0000 Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-53df747cfe5so6468591a12.2 for ; Sun, 05 Nov 2023 13:10:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20230601.gappssmtp.com; s=20230601; t=1699218617; x=1699823417; darn=zsh.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=wmufaXyk+qCYJxFl8VKyweKpTEAUI/0WFFMilpKh3xk=; b=W0sR3BdAb6xWhH9ZCRrWfMnqNA0n+guRFF+8jPb2toS5Jd0LkpGBHicPELcha+AIDu OpXL5sTTr/C5DAG12a4nGYrKNoiF0D3OiaDGXhznaETelKbyCKgTJuFP4x6H6hMem6uq K12wMco/A12+tj6ROyPeK5TgBn/5BxY2AXCVYayy1cy5M4DBRtmJCkJkSVdRVT3+OgPm zJEQkNQJuHrceMPrIZRcoTxe7RGG/BAr4w23AOviPQAbLZekSs2Fh775CccZ0bmFvNO2 tTTBKFvyKBuskoI9APZGIHnR5nuNFe6dJvn3gl8H2QUIUXXeuZNIwdZ6bBTCeldwFIns 8LJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699218617; x=1699823417; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wmufaXyk+qCYJxFl8VKyweKpTEAUI/0WFFMilpKh3xk=; b=J7EUD7E46Ps3IMnsXeiQ07BDbYJr6M77ns0vLzrIClcrPsVl0mWdqHVDuHmsnjlb98 r7B/tVFitjOyeRvyFIPFLCTrbxC8YakapJ7DnM5dgxWgF0q55kf4ZLDBHfH7oIdRANL/ 6SvgynApa2wRKsTwRO664nj4xhwv7/ZTn3r/fWfjXuAhWj7+1PavaimpppQ+31kjctEQ /He/20ZZq7ZsAWLOpH2K3hHtboRlZHhemBVSXgCwA6uzNgOG0t7l4vdq48z9Um4M1+82 ouAwqrmoazNiZNNMNqug1c7spzyYLx5cZLRBXspH2vKIWlnbROAIq8GNnn5grWlJ7WAt sV2A== X-Gm-Message-State: AOJu0YxXzUvlMF6jg2FrUxgb4fZ7Dhe6cGgzCgd5KJtZXWElGJ/namDM YWsbsQ1JuyFNjI6IKVrzw8RTYol3VXHwPS+NjCtD/t/LWrVvO+wI X-Google-Smtp-Source: AGHT+IHyznwPPPq9pLnGsHCtEBL5+HSd0lE93/ZFlPsVO4D2hAJY5TlFFkz4JEnGyNEZPIe2qVgdBBqZRxZsAHvhoQk= X-Received: by 2002:a17:907:31cd:b0:9dd:d85e:b23f with SMTP id xf13-20020a17090731cd00b009ddd85eb23fmr5098414ejb.67.1699218617439; Sun, 05 Nov 2023 13:10:17 -0800 (PST) MIME-Version: 1.0 References: <6f0cc0e8-665f-4c90-ba6e-6180ebcf9d60@laker.email> In-Reply-To: From: Bart Schaefer Date: Sun, 5 Nov 2023 13:10:06 -0800 Message-ID: Subject: Re: [PATCH] Re: `pwd -P` with systemd-homed causes inconsistent cwd state To: Kyle Laker Cc: Zsh hackers list Content-Type: multipart/mixed; boundary="00000000000016bba006096e2a96" X-Seq: 52275 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: --00000000000016bba006096e2a96 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Nov 5, 2023 at 8:17=E2=80=AFAM Bart Schaefer wrote: > > I'll put something together a bit later today, but in the meantime > would be interested in feedback from anyone else who has a better idea > how we arrived at this state (and possible what really is going on in > lchdir() ...). The attached passes "make check" for me with all sensible** permutations of HAVE_GETCWD and USE_GETCWD. If someone else can check the __CYGWIN__ case that would be great. ** That is, I didn't try defined(USE_GETCWD) && !defined(HAVE_GETCWD) Kyle? --00000000000016bba006096e2a96 Content-Type: text/plain; charset="US-ASCII"; name="zgetdir-lost2.txt" Content-Disposition: attachment; filename="zgetdir-lost2.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lolyv51r0 ZGlmZiAtLWdpdCBhL1NyYy9jb21wYXQuYyBiL1NyYy9jb21wYXQuYwppbmRleCA4MTdiYjRhYWYu LjhiMzFhZDlmNCAxMDA2NDQKLS0tIGEvU3JjL2NvbXBhdC5jCisrKyBiL1NyYy9jb21wYXQuYwpA QCAtMzQyLDM2ICszNDIsNjkgQEAgem9wZW5tYXgodm9pZCkKIG1vZF9leHBvcnQgY2hhciAqCiB6 Z2V0ZGlyKHN0cnVjdCBkaXJzYXYgKmQpCiB7Ci0gICAgY2hhciBuYnVmW1BBVEhfTUFYKzNdOwog ICAgIGNoYXIgKmJ1ZjsKKyNpZiBkZWZpbmVkKEhBVkVfR0VUQ1dEKSB8fCBkZWZpbmVkKF9fQ1lH V0lOX18pCisgICAgY2hhciAqY3dkYnVmOworI2VuZGlmCisjaWYgZGVmaW5lZChVU0VfR0VUQ1dE KSB8fCBkZWZpbmVkKF9fQ1lHV0lOX18pCisjaWZkZWYgR0VUQ1dEX0NBTExTX01BTExPQworICAg IGlmICgoY3dkYnVmID0gZ2V0Y3dkKE5VTEwsIDApKSkgeworCWJ1ZiA9IGR1cHN0cmluZyhjd2Ri dWYpOworCWZyZWUoY3dkYnVmKTsKKyAgICB9IGVsc2UKKwlidWYgPSBOVUxMOworI2Vsc2UKKyAg ICBjd2RidWYgPSB6YWxsb2MoUEFUSF9NQVgrMSk7CisgICAgaWYgKChidWYgPSBnZXRjd2QoY3dk YnVmLCBQQVRIX01BWCkpKQorCWJ1ZiA9IGR1cHN0cmluZyhidWYpOworICAgIHpmcmVlKGN3ZGJ1 ZiwgUEFUSF9NQVgrMSk7CisjZW5kaWYgLyogR0VUQ1dEX0NBTExTX01BTExPQyAqLworICAgIGlm IChkICYmIGJ1ZikKKwlyZXR1cm4gZC0+ZGlybmFtZSA9IHp0cmR1cChidWYpOworICAgIGVsc2UK KwlyZXR1cm4gYnVmOworI2Vsc2UgLyogIVVTRV9HRVRDV0QgJiYgIV9fQ1lHV0lOX18gKi8KICAg ICBpbnQgYnVmc2l6LCBwb3M7Ci0gICAgc3RydWN0IHN0YXQgc2J1ZjsKLSAgICBpbm9fdCBwaW5v OwotICAgIGRldl90IHBkZXY7Ci0jaWYgIWRlZmluZWQoX19DWUdXSU5fXykgJiYgIWRlZmluZWQo VVNFX0dFVENXRCkKKyAgICBjaGFyIG5idWZbUEFUSF9NQVgrM107CiAgICAgc3RydWN0IGRpcmVu dCAqZGU7CiAgICAgRElSICpkaXI7Ci0gICAgZGV2X3QgZGV2OwotICAgIGlub190IGlubzsKKyAg ICBzdHJ1Y3Qgc3RhdCBzYnVmOworICAgIGlub190IHBpbm8sIGlubzsKKyAgICBkZXZfdCBwZGV2 LCBkZXY7CiAgICAgaW50IGxlbjsKLSNlbmRpZgogCisgICAgc3RyY3B5KG5idWYsICIuLi8iKTsK KyAgICBpZiAoc3RhdCgiLiIsICZzYnVmKSA9PSAwKSB7CisJLyogUmVjb3JkIHRoZSBpbml0aWFs IGlub2RlIGFuZCBkZXZpY2UgKi8KKwlwaW5vID0gc2J1Zi5zdF9pbm87CisJcGRldiA9IHNidWYu c3RfZGV2OworCWlmIChkKQorCSAgICBkLT5pbm8gPSBwaW5vLCBkLT5kZXYgPSBwZGV2OworICAg IH0KKyNpZmRlZiBIQVZFX0dFVENXRAorICAgIGVsc2UgeworI2lmZGVmIEdFVENXRF9DQUxMU19N QUxMT0MKKwlpZiAoKGN3ZGJ1ZiA9IGdldGN3ZChOVUxMLCAwKSkpIHsKKwkgICAgYnVmID0gZHVw c3RyaW5nKGN3ZGJ1Zik7CisJICAgIGZyZWUoY3dkYnVmKTsKKwl9IGVsc2UKKwkgICAgYnVmID0g TlVMTDsKKyNlbHNlCisJY3dkYnVmID0gemFsbG9jKFBBVEhfTUFYKzEpOworCWlmICgoYnVmID0g Z2V0Y3dkKGN3ZGJ1ZiwgUEFUSF9NQVgpKSkKKwkgICAgYnVmID0gZHVwc3RyaW5nKGJ1Zik7CisJ emZyZWUoY3dkYnVmLCBQQVRIX01BWCsxKTsKKyNlbmRpZiAvKiBHRVRDV0RfQ0FMTFNfTUFMTE9D ICovCisJcmV0dXJuIGJ1ZjsgICAgLyogTlVMTCB3aGVuIHN0YXQoKSBhbmQgZ2V0Y3dkKCkgYm90 aCBmYWlsZWQgKi8KKyAgICB9CisjZW5kaWYKKyAgICAvKiBzdGF0KCkgc3VjY2VlZGVkICovCiAg ICAgYnVmID0gemhhbGxvYyhidWZzaXogPSBQQVRIX01BWCsxKTsKICAgICBwb3MgPSBidWZzaXog LSAxOwogICAgIGJ1Zltwb3NdID0gJ1wwJzsKLSAgICBzdHJjcHkobmJ1ZiwgIi4uLyIpOwotICAg IGlmIChzdGF0KCIuIiwgJnNidWYpIDwgMCkgewotCXJldHVybiBOVUxMOwotICAgIH0KIAotICAg IC8qIFJlY29yZCB0aGUgaW5pdGlhbCBpbm9kZSBhbmQgZGV2aWNlICovCi0gICAgcGlubyA9IHNi dWYuc3RfaW5vOwotICAgIHBkZXYgPSBzYnVmLnN0X2RldjsKLSAgICBpZiAoZCkKLQlkLT5pbm8g PSBwaW5vLCBkLT5kZXYgPSBwZGV2OwotI2lmICFkZWZpbmVkKF9fQ1lHV0lOX18pICYmICFkZWZp bmVkKFVTRV9HRVRDV0QpCiAjaWZkZWYgSEFWRV9GQ0hESVIKLSAgICBlbHNlCisgICAgaWYgKCFk KQogI2VuZGlmCiAJaG9sZGludHIoKTsKIApAQCAtNDg3LDE4ICs1MjAsNiBAQCB6Z2V0ZGlyKHN0 cnVjdCBkaXJzYXYgKmQpCiAJemNoZGlyKGJ1ZiArIHBvcyArIDEpOwogICAgIG5vaG9sZGludHIo KTsKIAotI2Vsc2UgIC8qIF9fQ1lHV0lOX18sIFVTRV9HRVRDV0QgY2FzZXMgKi8KLQotICAgIGlm ICghZ2V0Y3dkKGJ1ZiwgYnVmc2l6KSkgewotCWlmIChkKSB7Ci0JICAgIHJldHVybiBOVUxMOwot CX0KLSAgICB9IGVsc2UgewotCWlmIChkKSB7Ci0JICAgIHJldHVybiBkLT5kaXJuYW1lID0genRy ZHVwKGJ1Zik7Ci0JfQotCXJldHVybiBidWY7Ci0gICAgfQogI2VuZGlmCiAKICAgICAvKgpAQCAt NTI2LDIzICs1NDcsNiBAQCBtb2RfZXhwb3J0IGNoYXIgKgogemdldGN3ZCh2b2lkKQogewogICAg IGNoYXIgKnJldCA9IHpnZXRkaXIoTlVMTCk7Ci0jaWZkZWYgSEFWRV9HRVRDV0QKLSAgICBpZiAo IXJldCkgewotI2lmZGVmIEdFVENXRF9DQUxMU19NQUxMT0MKLQljaGFyICpjd2QgPSBnZXRjd2Qo TlVMTCwgMCk7Ci0JaWYgKGN3ZCkgewotCSAgICByZXQgPSBkdXBzdHJpbmcoY3dkKTsKLQkgICAg ZnJlZShjd2QpOwotCX0KLSNlbHNlCi0JY2hhciAqY3dkYnVmID0gemFsbG9jKFBBVEhfTUFYKzEp OwotCXJldCA9IGdldGN3ZChjd2RidWYsIFBBVEhfTUFYKTsKLQlpZiAocmV0KQotCSAgICByZXQg PSBkdXBzdHJpbmcocmV0KTsKLQl6ZnJlZShjd2RidWYsIFBBVEhfTUFYKzEpOwotI2VuZGlmIC8q IEdFVENXRF9DQUxMU19NQUxMT0MgKi8KLSAgICB9Ci0jZW5kaWYgLyogSEFWRV9HRVRDV0QgKi8K ICAgICBpZiAoIXJldCkKIAlyZXQgPSB1bm1ldGEocHdkKTsKICAgICBpZiAoIXJldCB8fCAqcmV0 ID09ICdcMCcpCg== --00000000000016bba006096e2a96--