From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 11751 invoked from network); 9 Jun 2022 04:08:54 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 9 Jun 2022 04:08:54 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1654747734; b=rJr7Qajg9Lxv3vIzAE7bQyBHAk7SFdq6mmwHc0r9twSCu0PSxkAlytk8kNCQ+08xK3Qk++wEuX BKcHDKkwHnP2V2AsOb9xMLt55HtVaqh6IHiA/FfeZ1pSPymrOto7DjTfGExpj00nqyilE/ssrS W1o2FqJNxRkuzkKRYgZzksmANVWjWgjr3yTHTl0A90E9b1HhVCL4Ypn5sNZloo+ovRqQF5geO/ RWPvrdtCoW8QDScHWR7awrQhVxzwfuZEU9QmTFRs0TF3A3cdYDJaWoBmrO9uG/mLmXJhatoYYR LWmeN/0Q0Y7XhqHHAo1FK6jXilByJxzI4dPOCqgCfV+eng==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f51.google.com) smtp.remote-ip=209.85.218.51; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1654747734; bh=sIrt0KY/c3oai/7tafEnbVnWAVhCzBr7fRAcBvPSM90=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=Y1wSG6DaJhLxq2iGu3XZ3cSfjwasIi97I0bdCGu81LyTSAKuRqI/Qtn02T7HvL9dtzcsSWDXV9 NFsygyrL/SYhyCsd/GJpnCpKrCA5v+F9NmhMo+7AkIli9tkfAO3SKs9C2PkAFwjxJW0WPURqFg M3uiHdJFvZqSgyO1740HsEAJyE+6ZDX3XNFCi198HMUp1dfufnlMVVBGVOqXmlL3GyowXOEgQx xFkKC6Jca1Wkya+Llo9yrYpNJfIgnoB01FtO2DSKHnJzznVHNzN0AcnAcYCY2kml88RwFjV8xL g8Ds0KwVYy6jZ4em1mC23OiDBvo7dpLMv0pjcCr8ufwYkw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:To:Subject:Message-ID: Date:From:In-Reply-To:References:MIME-Version:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=kV9PYyU7wLSDuHdvZNRILqMX+dduIp3mmJuTAwfqvZE=; b=sqn41MIbbs+1GO8ixqYdD8AgoI WJ37l/5Y9dYtyUHxD6q/RY7P2gwJOlGHvev4EJgNZ3LLGOuazkgJLavTEc6qVTdp7QGx7UNdxqcDi P3acNwZv5WjO6eeStA9gVJB6oc5AoK7vuQyQCWwOatEEmZ/aEkBb2xV/N/873e0uNBnEPZ0dG78z5 FbdlqjhKKY0pkOobavVpPZgbTKhR5iGqj94n47MXfQ3JzsPZQ7Sgdg+76F88cXwPcRj5xnwKHz/6+ K6KzXoyyBTLcxF77QQWIQkvDCp1nAplF8z8e0GrrqqmZpTGmzW0jp9t4ptyY/EuzETZAqn1Qqs/ZW h3nIBL5A==; Received: from authenticated user by zero.zsh.org with local id 1nz9TX-000JFy-Ex; Thu, 09 Jun 2022 04:08:51 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f51.google.com) smtp.remote-ip=209.85.218.51; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ej1-f51.google.com ([209.85.218.51]:42944) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1nz9Sx-000Iuz-Tf; Thu, 09 Jun 2022 04:08:17 +0000 Received: by mail-ej1-f51.google.com with SMTP id q1so45067749ejz.9 for ; Wed, 08 Jun 2022 21:08:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=kV9PYyU7wLSDuHdvZNRILqMX+dduIp3mmJuTAwfqvZE=; b=UqNcq1lmDvmt4P6PdiP6SA2L00WYnYM4c0OzCQxK2xEii9XYm++ts2W1aBJDKFpF/T Fq3tEAjOUWPmkl5Od4FnDBANt6RoALUBrTDyxp6ILP2+qi1rm+U3Uht/ZIvayQBEXin8 AxGdedgu0FaEmfvaYtrcvTfHiyIE5gbqro9lpmRwJmWxQrF4cvZp+z85fCoIEjHkATZq VQrGxxjkzmD+L0zHp17zjWRcehE9MIAOK88wdThJ4CWS4wKObxZmzPy6Ff+BJvSjpgNY xcc00jXJISb7uAeEckHSvFycep0mj8fJ32Z79T4usZJFrqcaQaIe6wj2lD0J0rq/K4RT ps3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=kV9PYyU7wLSDuHdvZNRILqMX+dduIp3mmJuTAwfqvZE=; b=TTVyEHk0ji3GYRcqti+D1HWNw5cnQ1/Cp7Qh75oiw5KDML2h3N+gfEEcgCKGUsJrxD 82060ch8tDv0A7qNf0kS6h5YvJMn37zaS+zx4A5pB9kn/46es9N8ISZ2jJMzdV3ZR5VU 3IGzdBgTrNuNGRjRj1zltUmh7wyIGhmDjPT6LV36xo6l4uYu4XK7KJU6lSL+YTQf6MTK uRZHTtKpftipSjBfcPIL/ktwSyZLP3gqKWEyiOJntldpYuloLPzPTi3V4ypJ3nclF7a4 pANqQtpbHGzxqQzfUoaAWwHw9R2GyVHnCWzSPV0zaXjCXQSszYPflzTKgFiQjLsRX56v QP4Q== X-Gm-Message-State: AOAM532smqxgLtCGnGh290ZUkb6ZWuLki46V7WZDGUHYwvP0rLW7nIuN 2l4yPKKMJRUJJth0zKmB2Mbr/bOo+ISQQilwO/pC2l1h83DfqQ== X-Google-Smtp-Source: ABdhPJywBOBxRLLiVFm5pNcwURlBfTiOQ6m9RlUhoK7HMEjtadYw7P/F40nve+N/naAEPdOxLgln6ksUGQ1u13ZIjPk= X-Received: by 2002:a17:907:1612:b0:711:e427:e9bc with SMTP id hb18-20020a170907161200b00711e427e9bcmr9815157ejc.55.1654747695083; Wed, 08 Jun 2022 21:08:15 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bart Schaefer Date: Wed, 8 Jun 2022 21:08:03 -0700 Message-ID: Subject: Re: There's no xtrace output for function definitions To: Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 50353 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Wed, Jun 8, 2022 at 9:45 AM Bart Schaefer wrote: > > Obviously (I would think) we don't want to dump the entire function > body to stderr, but we ought to output something? In the "I've forgotten more than I still know" department, I just realized that other shells don't trace function definitions either. Consequently, the following is submitted for consideration, but I won't commit it. (I hope gmail isn't actually messing up indentation as much as I think it might be.) diff --git a/Src/exec.c b/Src/exec.c index f2911807c..6d08f5e7e 100644 --- a/Src/exec.c +++ b/Src/exec.c @@ -5364,6 +5364,11 @@ execfuncdef(Estate state, Eprog redir_prog) zfree(shf, sizeof(*shf)); break; } else { + if (isset(XTRACE) && EMULATION(EMULATE_ZSH)) { + fprintf(xtrerr, "function "); + quotedzputs(s, xtrerr); + fputc('\n', xtrerr); + } /* is this shell function a signal trap? */ if (!strncmp(s, "TRAP", 4) && (signum = getsignum(s + 4)) != -1) {