From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: errexit and (Z)ERR trap regression
Date: Thu, 27 Jun 2024 09:43:51 -0700 [thread overview]
Message-ID: <CAH+w=7ahHx=Rig9_GLq_6z6oSoHcdzy3PrYQVqx178-yWERGVg@mail.gmail.com> (raw)
In-Reply-To: <CAGdYchuRvp3swLy-eUXaSu4QK0UHsN3Jbyp58pz35M9mQTO=dg@mail.gmail.com>
On Wed, Jun 26, 2024 at 7:01 PM Philippe Altherr
<philippe.altherr@gmail.com> wrote:
>
> It's true that in the first iteration of the while loop, the noerrexit = oldnoerrexit is always a nop. However, that isn't the case for subsequent iterations and in particular for the last iteration where it's important to always restore noerrexit to its original value (i.e., oldnoerrexit) even if that value isn't equal to 0.
>
> Now that I see this code under this angle, I think that a better version is one where noerrexit = oldnoerrexit is placed after the switch statement.
Ok, this makes much more sense to me than the previous patch. Thanks
for digging in.
next prev parent reply other threads:[~2024-06-27 16:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 17:12 Martijn Dekker
2024-06-21 18:46 ` Bart Schaefer
2024-06-21 20:02 ` Lawrence Velázquez
2024-06-21 20:36 ` Bart Schaefer
2024-06-22 5:49 ` Lawrence Velázquez
2024-06-24 23:02 ` Bart Schaefer
2024-06-26 12:42 ` Philippe Altherr
2024-06-26 21:43 ` Bart Schaefer
2024-06-27 2:01 ` Philippe Altherr
2024-06-27 16:43 ` Bart Schaefer [this message]
2024-06-27 17:09 ` Philippe Altherr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7ahHx=Rig9_GLq_6z6oSoHcdzy3PrYQVqx178-yWERGVg@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).