From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: from zero.zsh.org (zero.zsh.org [IPv6:2a02:898:31:0:48:4558:7a:7368]) by inbox.vuxu.org (Postfix) with ESMTP id 083252727F for ; Thu, 27 Jun 2024 18:44:22 +0200 (CEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1719506662; b=EtlASGDW8Lhnx2eGZHuv8wtUgrQ7kpQ2mVgHDVguaCfzg51YZy+dy65nrf9UlzTuDcwJ08mxQi LcU3Os41vag8aKRaWMSKbLJAGFrf5z9FUFqeFzJmAq5IBceb77n6GykY5glGew2ngs6YZOj++G 64pwUxKgc7AT22vrpvL8BvjVsLYUCeXXLrdvX2LGyJhtJd/b1QZ2OEgGuNEYagekrucF5GscoD RZDRuiXwv4CeFNVAw1o1LTNLP7QcVG6oZAuPy4OSP2iHskiWnwiL+ly0Fra0zn3uauUA5HwDPj hipCuVn7phplJavzajScGbBf9w0rFpTUc8nqLNQCXzj8Bw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f41.google.com) smtp.remote-ip=209.85.218.41; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1719506662; bh=3vByaa301HQc0AIOiUAlKbHusYfKV0SkCvxyG042pMs=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:To:Subject:Message-ID: Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature:DKIM-Signature; b=ml+DtJRXRt8WwdCFtXpfoRdSYG3+kyq98XalT+An2ESKLdQrNekYsZMXclAbru76snhTgBkeHy 5qMFS2NULzAWQEi1vJOl1zKhuw44dJVdLeHqO/IT19mwmuu86L+ycEE8p1FG/zL529eEFVYxSK q9XvRSlwUn27cjLLr0mf9VSXfRMepee6Z+2haSrJ+dygGM0qxq/ZFPnYP4xeOFKfMW5arkoDAZ P9XVh8S1g7qUluXOm4KRZvwBA0zeYVuhAhJ4cpSsURtT+m0FsqSk2rC7l7qCApqU7dmkqeFJVv p0be8jrB5fm43SIXRa1chJgEO0cOWI/E9xj3EB0onaiAMg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=Xx9wD/oLl8LQkCwqMDHd00KUY/YQlKsuMhECBTIQeKE=; b=AKeNQyJOU2tCFHdEUDyK+oQRTm WhEcW9NXZ4kftkguS/S/Ks6V5L90h5vs+kx6BoFO+/j1QBWo19UQg0oqZlsHtkNw+9/zPpz619AdA yxyb+fcfIDu4gIh4wYUvPT9fQl2I9E5u/L5YwPcOG5vQz72sArQ+OpxcAJ7San9sRZ6ofJdv29UxY OgPqYZrCwELmT7GbVncTPIaWJLzrK0S2Z63z1UfMf1ubypo1qz/prxdeyYeV3lW9QCi/SHAN1VPnz W8mHzZpriMh+vy4/7pxZs1876/Op0Rv68fdUdY4G5G6H/UmPfABivvzThMZpynTCZiVHZ2fT38GHc S/1t1/NA==; Received: by zero.zsh.org with local id 1sMsEP-000Hm0-OB; Thu, 27 Jun 2024 16:44:21 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f41.google.com) smtp.remote-ip=209.85.218.41; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ej1-f41.google.com ([209.85.218.41]:54661) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1sMsE8-000HSJ-F2; Thu, 27 Jun 2024 16:44:05 +0000 Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a7252bfe773so584424566b.1 for ; Thu, 27 Jun 2024 09:44:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20230601.gappssmtp.com; s=20230601; t=1719506643; x=1720111443; darn=zsh.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Xx9wD/oLl8LQkCwqMDHd00KUY/YQlKsuMhECBTIQeKE=; b=Hc9zxQyflqnPgozHS7apk0cZ/Ukt0W0TsEcrF/plbs5bMDv/6KjRWubHbx9W53fFIe +WY9rHU7JW10SnTP3+z9crLE2SM3S9zWSCjeeIhis79ecrjcWPks7A66S+EbZAYgHmqa Kpa3r4z9wE0qz3grN81gH2VhCGTeCocRkFCU3x1WTKaCWPUXzEydL1ieLksW7vzyBZcZ 7ICxwELYvIHvxZIIEGkObE3sC3irfp+qbEWV8YZw01XcXLpHoK1R/6mhegxHultjtRa4 WzC8AKp7XQoUaKVf0pynk9StMpO+C6bFSPhrLUPHsCBT6ydL6NF4Y3YyMWDPzpmvlK3j jVpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719506643; x=1720111443; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xx9wD/oLl8LQkCwqMDHd00KUY/YQlKsuMhECBTIQeKE=; b=cjdOa3VVz1otcjnZKQeomj/L+MA4v3mxxw103MSbZa5Ap/ZgPV7NyVUoZ7B6h5Bdtw C2bVDaK14/Q/1U4KagVCL7TtnW+6cuFdOlRFDftyLA7p3BJW4RQVAppza7CxDvqZQTFY QV+qL7essHrwPnD6Lv6+1qRu4q1nTmFIyAghdz8V8aFyygE4xa7oyV/BQdj9bWhG0jcT HjnhQBRIKmQo1yVjplBo0PnWsvfsL1RQcMm0+veSxAF2FQcSt3bJEIJrqUHfj9V5tdfs ENwB6nAfGnBTXNMZ5L8zgPeaN4hbApwR/P1G3OqFtqxkGlPPscwe78qpDD6Hm/zjsqRI MTSg== X-Gm-Message-State: AOJu0YykHAmv3cOhFWh9kZbNBdj1a9LlXRu7b9x4EOxM1DrLadvRVr6t 9GcBMM6zI5zOljB55sdj/zF2WRi9qYbucz/5sptxAcNS4BDo/FCGCZMx/HALBckilJ67VBlGtFC zEMXgHeLwl4qAjf3FdxA9fk1DfwSuwdPOJ3hqj16Vc1BfoGM= X-Google-Smtp-Source: AGHT+IH1mep5daoxG6PHGRNEEsoZbve318+nK135kNF9xSda+iYCdjcd+igVOjyBizmaDQlVmTeuk/hutdgFB0ZVigc= X-Received: by 2002:a17:906:4696:b0:a6f:b67d:959e with SMTP id a640c23a62f3a-a7245dc9b07mr825358666b.53.1719506643389; Thu, 27 Jun 2024 09:44:03 -0700 (PDT) MIME-Version: 1.0 References: <5d54375e-8673-45f0-b5ac-f5e0e233d56f@inlv.org> <2a5f0fa7-23bf-4069-b237-d304965f142e@app.fastmail.com> <33ca21c3-69f8-49f7-9350-2ff9cc4febca@app.fastmail.com> In-Reply-To: From: Bart Schaefer Date: Thu, 27 Jun 2024 09:43:51 -0700 Message-ID: Subject: Re: errexit and (Z)ERR trap regression To: zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 52978 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On Wed, Jun 26, 2024 at 7:01=E2=80=AFPM Philippe Altherr wrote: > > It's true that in the first iteration of the while loop, the noerrexit = =3D oldnoerrexit is always a nop. However, that isn't the case for subseque= nt iterations and in particular for the last iteration where it's important= to always restore noerrexit to its original value (i.e., oldnoerrexit) eve= n if that value isn't equal to 0. > > Now that I see this code under this angle, I think that a better version = is one where noerrexit =3D oldnoerrexit is placed after the switch statemen= t. Ok, this makes much more sense to me than the previous patch. Thanks for digging in.