From: Bart Schaefer <schaefer@brasslantern.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: PATCH: _perl_modules assumes it's called by perl
Date: Mon, 29 Mar 2021 08:16:39 -0700 [thread overview]
Message-ID: <CAH+w=7ap1534966=vrAW1hFmwY=4LWr6dXoM72oNFPzH0QeGPA@mail.gmail.com> (raw)
In-Reply-To: <20210329150644.GA30806@tarpaulin.shahaf.local2>
On Mon, Mar 29, 2021 at 8:07 AM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>
\> + if [[ $service == (perl|perldoc) ]]; then
> + perl=${${(Q)words[1]}%doc}
This still needs to be checked with "whence perl" to make [[ -n $perl
]] have the (intended but messed up) previous semantics.
I otherwise agree with the intent of the patch.
next prev parent reply other threads:[~2021-03-29 15:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 15:06 Daniel Shahaf
2021-03-29 15:16 ` Bart Schaefer [this message]
2021-03-29 15:28 ` Daniel Shahaf
2021-04-08 2:12 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7ap1534966=vrAW1hFmwY=4LWr6dXoM72oNFPzH0QeGPA@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).