From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: zsh-workers-return-43414-ml=inbox.vuxu.org@zsh.org X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,T_DKIMWL_WL_MED autolearn=ham autolearn_force=no version=3.4.1 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id a78ba4c5 for ; Fri, 7 Sep 2018 23:40:30 +0000 (UTC) Received: (qmail 4094 invoked by alias); 7 Sep 2018 23:40:20 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43414 Received: (qmail 13319 invoked by uid 1010); 7 Sep 2018 23:40:19 -0000 X-Qmail-Scanner-Diagnostics: from mail-lj1-f172.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.208.172):SA:0(-1.9/5.0):. Processed in 2.845095 secs); 07 Sep 2018 23:40:19 -0000 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=yghBTsE4z3fm2Hn0jxm2ZIuukBh/lxSwtUXG7o9GVPg=; b=ZnQKLdowAqSvSw+K4nsfQOWhvsNu6DWhqBJ0dPDPufl0vav2qAlPUZalXMJvrFbu13 YatemiJh2+w/tfP6uKMqfjuyHfd24x47iOAajBdKvPIuFxR/UqfrVFf5Y4ds1eLyjQnL e7DRVCO16+7xaCx+XY9vWdrRZ+8UWb9BuFYqxrsEmjsBTV/DbybN/nD5ArN28vB1wMJ6 iagf/+0XyoPAuSzQXvl7Gk7+M7wHcnsVLlVvoJJM+gsF8Rdi4CUlc9SX+AHsSRbmKe2B FIb43Ly1rRpw/NRzldA4/n2wZDIt+VchHnd/GaiOvf7DpE9+8Pvvxm4HEt5QCut2/5XR i28w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=yghBTsE4z3fm2Hn0jxm2ZIuukBh/lxSwtUXG7o9GVPg=; b=DYfstKHivW6MrpMVDJYfo+YuVE6Nz2XafrtC7KQtqOwH8GAz6ZpV9uNGN/EjTRBVat OVqdlVaRMkR4hP1E9UtvB9UVJbQzjg1/tMSgsPx+H5QrErQDjJ7XdL+qUPMK9OHmHwmn 3PVdL+eCmqEJmdGU3jkLqKP72a6W4wmFtWXcScBFBTkz7QKEpGX8Z1g/IJyt9fCSCmVx 6Mz775jnZtXS3hF0cHZdpNto+jUeOtzlttaccVwrRjA6IVwBLyMiMD6Ss9lcsoqjLrQs cRhvzWf78dLPbWY3f5ThbTbddiR327zakkqMWuMBnT13yBM6X8WyrlI1mY3DWP5W5iVe Z5Ug== X-Gm-Message-State: APzg51Ab7F712haVzHnXlFtA7KRUgHR7zqBMDSRHSfEqTsZhHZqwpGm4 LNft+NQ7NIa5GG08lnuIQqbPFPYtEhHBWVm5blCCiQ== X-Google-Smtp-Source: ANB0VdbfYGcx6exqNr53pVNAx3a9l2x6qIW3oMaD2/FKmiezucAeEfw/I5+RZ6MuxzoU6fJCCSXV41Lo0kbahznyaTk= X-Received: by 2002:a2e:5d9d:: with SMTP id v29-v6mr6041882lje.137.1536363612451; Fri, 07 Sep 2018 16:40:12 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <577129092.1106031.1536338813897@mail2.virginmedia.com> References: <20180905210740.5a6aec15@pws-HP.localdomain> <20180906090902.1f344e9f@camnpupstephen.cam.scsc.local> <20180906092250eucas1p13d651e07ae627d179dd0701e65f912d6~RxTLztJrP2263722637eucas1p12@eucas1p1.samsung.com> <20180907101852.62415ff9@camnpupstephen.cam.scsc.local> <20180907122145.2af5bcba@camnpupstephen.cam.scsc.local> <20180907150140.46a05880@camnpupstephen.cam.scsc.local> <20180907145828eucas1p2755db3a0eb9725cb3a29121033e77f21~SJhg-Al9h2728227282eucas1p2z@eucas1p2.samsung.com> <577129092.1106031.1536338813897@mail2.virginmedia.com> From: Bart Schaefer Date: Fri, 7 Sep 2018 16:40:11 -0700 Message-ID: Subject: Re: PATCH: Rimmerworld pipeline race To: Peter Stephenson Cc: Peter Stephenson , Zsh hackers list Content-Type: text/plain; charset="UTF-8" On Fri, Sep 7, 2018 at 9:46 AM, Peter Stephenson wrote: >> >> Here's a more sophisticated fix, though I'll take votes on which to use >> for now. > > (Don't all shout at once.) Timezone difference and mornings are $REALJOB busy for me, so I couldn't answer right away. > Actually, I can't see a good reason why I shouldn't simply commit this. It's much > the neatest way of keeping the states aligned. I'll do that. I was going to ask whether this replaces or adds to the previous patch, but either way, yes, do this. Is there a point to replacing &dummy with &gleader in the call to read_loop(), other than to save declaring "int dummy"? It doesn't appear that read_loop() puts returns anything useful via &gleader.