From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 8896 invoked from network); 31 Dec 2023 05:20:59 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 31 Dec 2023 05:20:59 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1704000060; b=qloVBFszOvTtZBIKX0rK2ArPFAkZ40RyZogmsnEKucR8YWyXem1iKAACmtdqlBBv7WLRQaCSSb fnGAYRLBUd09qJAfRDmK1kp3fenUjM6gkp8sfu8kWaVe1dy/hIeCopDPvpMFn4wlILpqp7Z5ir GG8/EbdA9pypinkzOsHOS/LVZsm36RsAX8EbnHH8NdT+Q1vEcsyNsmn+tWteIXacY6/Fx6sJkV BIzVxgoH99gWEqB5dMBRo9VWjFdz+Hc1x2KhaiuKqg+yeiyZzJWVOZ6Zk3TJlL89lCYADcUyuG vf2i8MlDjcKh9wUDKifT/KWCuRYj/snqt3K0WzueufTBaw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-wm1-f50.google.com) smtp.remote-ip=209.85.128.50; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1704000060; bh=TeQtfrt6ZmOIJWl3QNG8GTirN2R23S9w98fKF+RXDOs=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature: DKIM-Signature; b=snZn1n7T9WPNUD0n5TrgozwMrlziBMGMshMfDcmjjsrr32JQLNuEje7b11jQyZwrbS3QZxNsMw TPLyBu2Q5/gQUQPmZnMhyXBR4mwFZgU4IIvvaH7GDICOserVmLDqpoQ4wwtr9DCMmyfKhdxHOI 15jx+IYlbxmwa6UCccL45WoOmnicqaHN79Gw1lMHq/jn75xa5Xznbs5v81Mfze896ninga2f09 rx6eZwJTu9SNsufry+LmlyIuwzs0fHkk/2P3zk4O/qc5+K5HPLKdIF1SO9I8ywzz3nnSoVhUpA tpw1EV+Z3FGaZXKM0yle1sJwp0Aby036HWEEkh673xa2fw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=Axb0N75VcqLUuKiNBsNFfRWe3x/jfaKaFeUnb1wo1EE=; b=lYxKgqfVsMZUx6rrh5X5RPjopa KP0m6xhYBeqkJkYG/IDQ1+CzqVrzKVRZyfbDCr3okxchDgr3IvxBYPMBMQ6MPEC/yo6IiWlT9ywkA tbgEc9NcfJi8bMoDlgeW0ZMXw/dmhlZZzw8x7rNr8ml4fgZk6N2tfyWrTDn0J17Ti8xNY3q/DGG7O /1p0qDuCF2E1ZXtL4/j+t+DSozwvMFF7FlSQcZy57zpViCFzAA/KlNZj9trkPxKfhIGiiYMnJOxLf AoMozegil5AqIo6fLBZVDe6U+enSmNhoyyNegico/CoodKIzDPhmiGoJAOmmKGZRE9arzqfO8VJdM COyg7i2Q==; Received: by zero.zsh.org with local id 1rJoFv-000ANw-6v; Sun, 31 Dec 2023 05:20:59 +0000 Authentication-Results: zsh.org; iprev=pass (mail-wm1-f50.google.com) smtp.remote-ip=209.85.128.50; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-wm1-f50.google.com ([209.85.128.50]:52636) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1rJoFd-000A3k-6h; Sun, 31 Dec 2023 05:20:42 +0000 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-40d60a96533so36249515e9.1 for ; Sat, 30 Dec 2023 21:20:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20230601.gappssmtp.com; s=20230601; t=1704000040; x=1704604840; darn=zsh.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Axb0N75VcqLUuKiNBsNFfRWe3x/jfaKaFeUnb1wo1EE=; b=USn13Dbl7mF7jlR9utY1jEegKFlMpM4WIDbkSiMpLzkYIJkkDSd1MfSjs6L4G1/PK5 UD07T8BnAwp5rn/yOsDUfxydWZO8bwxbEPe9I9PULVB+l7Qt8Qojuvv/WPXG9ezkKcKf /Mf7kVHgEyqAhN6VVyeyYXzqeDI+vXHx0TFPG5b0MdCJUhrXdnFQT/XqxBcQy4ydf2Ja DdToebErm9vuxbRjLJMD5gHD6OaS6knOfNl0hN5y6HzI/DICuVOkpThafhcwmg0Pk84X Euwav7T9gJxb6qgVtbgLZKuyDmh2PdD7i6WT4RZqpp/k2YOhWiPyksq7RMB4D++C+GH3 Fn+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704000040; x=1704604840; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Axb0N75VcqLUuKiNBsNFfRWe3x/jfaKaFeUnb1wo1EE=; b=NqZgeUmcMXakLq1lGWjOJdKeYe1Hayu3qmXUpRF1yhNwDfzW6vS3UHBxcko22QPDKz Zx3wSmScAlsHVIlSMY/vFcuiXdi6Ze21+P5rKPtCk66KO2i6idxhPnU6KGLrUytFnar9 vBcvAZoNr4ObGFRIJeJaPmo3CZMRBUTbUn3ng47QS0cTKwtslS7KsOQHy5bkyNmzWSD+ V+LTUYMVLLtk4QD62aToA1dJaofzLmVDaaJ5/uozxfEG4z0erspAF20pHqKMzNxFp30U jvX3suvR41eTgS/1uqBTGjagvnOZ0lM/OTgHdKeGxGMq/EiErslNbadSdGhhGb46iols 6kzA== X-Gm-Message-State: AOJu0YwqW/17A7QzpfiCCEtaD5ZDC30es/2uToWMDUwgHCrsBGyJjf1R xHaNdzp+eaFcaDvesSssGWvYekNXJFBfvvBr1sMpDctEErSB X-Google-Smtp-Source: AGHT+IH8Vcyro2pDH2plDE5QBVzrkSCdF0P6wBAxbIW8LfHSAoAEXVf3PjzQBXWh0SsZND2jQIBu6MWVRw8UXOZHm28= X-Received: by 2002:a05:600c:3794:b0:40c:2d80:6c2a with SMTP id o20-20020a05600c379400b0040c2d806c2amr8641966wmr.113.1704000040607; Sat, 30 Dec 2023 21:20:40 -0800 (PST) MIME-Version: 1.0 References: <20231226060159.182340-1-tirtajames45@gmail.com> In-Reply-To: From: Bart Schaefer Date: Sat, 30 Dec 2023 21:20:29 -0800 Message-ID: Subject: Re: [PATCH v2] string.c: remove use of strcat() after strlen() To: James Cc: zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 52436 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On Sat, Dec 30, 2023 at 9:10=E2=80=AFPM James wrot= e: > > Since we are already calling strlen() beforehand to know the size of allo= cation, we can just memcpy() Fair enough, but the function you've optimized is called so seldom that this is not going to have a meaningful effect on performance. > I'm using a MEMPCPY macro because I don't know how zsh handles using GNU/= POSIX extensions. Please explain why that matters? The macro is used exactly once after being declared and there are no preprocesor conditionals around it.