From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 8322 invoked from network); 7 Jan 2024 04:02:31 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 7 Jan 2024 04:02:31 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1704600151; b=dOAZj0diniMymtkDtrLdbdIiY05+K01VuzWrD/L+S3SKuBvJLURdZuHVG3PLe2Q2m8SCsA2Jao aDZCVuzPSFhR+u1aJDx1bFTXP6T7UKfJbf+s5raUwkpioZHm0/8HJrPVAuehL9VEo+O+y9JJDC QuMhYnl/k+rp7p9XTDHfI8eFQc9PIY+qL/5LOH3W3xp85GayA9dbnVFdf2yrsdbanl9+Xc/jv8 sBMudPwmH3eYFGSqWbKI2VubXje5lObNvaFkZ55sNeuZKzJkJHGAiFEC9vRf1tnboPAQZA39sQ ySgqO5nTgTE44pAeJ1Zsv1yfBTTH/Ghp41fUy3eOkjs7Ow==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ed1-f47.google.com) smtp.remote-ip=209.85.208.47; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1704600151; bh=bCu3/f9dXrSPUK4aJNqSItQV1wEdDYxOniT79UWo3U4=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=qF6e8l0ao2agIUMbGqrH8UH0Z2n9NxlV74SjfcQ9QsViD7h6eiaQkGFCaLbsfqnqrd1Sx72nCF gU59+k9DHwMkq+vrlEPRV5ubxptl325ddXy05sBEEF/MBPMaggRwbrSnlEEvy4JIByOnWeJXmQ F3Lsn9Fha9NKNymy373vZHpv5iCmpaExcwRM7IfIwq76Qil9NWB9qO93EUMJ6ZfcH6RG8Dd4NH Z9Ajy1XLYiVZVvwlGYcS9Kug+bZS5N+EWHBmv682gy0uySe7teje3y4Vrry55XcOoecdAk8+XA hGSbd5A1nZM4FD9FZW9geU9+zoKO3NV2VY8YXyl6+XxADA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=bCu3/f9dXrSPUK4aJNqSItQV1wEdDYxOniT79UWo3U4=; b=FQjd309jXhpFHzzcGVeRGKGZmm qdxgRkPvq4a2y77WIV27nbqRh8gBHYtVQdVwoI09MY0DEtZQbmmF0wGw5GAhzNaPx74NWcTFaTZS8 Fy0prpthRSJ01BdGTeHzAo+iy61MPZMgH69n+geDb3D1m93qKA8BJdtZcokteduD7u/sXhYDAzePu wVr25mNSGpFHRcXWjw1nXiea+MoqEHQs000D5AE3zK1Bxo53UqbSjUOza/Pw8zmCZncHnG3jueoEn NWJQ7I17T6LBfG9yjR2CNnfFKTDZtR2lUK7PfE54LH0E9aczvvC5jxmELa49X3RULwHElC3Pv3qgM i94R4/NA==; Received: by zero.zsh.org with local id 1rMKMn-0002Ny-2U; Sun, 07 Jan 2024 04:02:29 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ed1-f47.google.com) smtp.remote-ip=209.85.208.47; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ed1-f47.google.com ([209.85.208.47]:54740) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1rMKMR-00025G-Uh; Sun, 07 Jan 2024 04:02:09 +0000 Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-557642101d2so691638a12.1 for ; Sat, 06 Jan 2024 20:02:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20230601.gappssmtp.com; s=20230601; t=1704600127; x=1705204927; darn=zsh.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bCu3/f9dXrSPUK4aJNqSItQV1wEdDYxOniT79UWo3U4=; b=uQMdFz8kH+Q0rd0N8lHYep9troR/78/zod3O4bFLKGm0ryZCmLpsxz2IC+uMpT8zOO tNzWS/rFL51wly/8J8vfJSfUtE6pLIxvVVJciVaJO9zFIyuocWhRJAsILJSOSJUcbtVz KXjCK8JKZ/L5vdvk1PFiqcXZsiOr6pXuHExCIE7gWXoEfh51XbE8vD+n1IyUqfrhJenx miDbmfwDMHRDgQKM59UOi92aQXIipEGd+kRGcs3K/fRuigXXd1U6FbMfnzep0U28hdm5 sEVA2anGw+P/KQBLQP2gnWEME0gutRNmueVlcFHnil7yRw+a/HVqyECrlwnUBSRS0bw8 UK1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704600127; x=1705204927; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bCu3/f9dXrSPUK4aJNqSItQV1wEdDYxOniT79UWo3U4=; b=XwmIo2+J1OSffWhEtN12KOe2ZRgg7RqRWvzqzelCoBoir9sy0mmMnEvDhKSknNsCGK jfumh8QqABPhKzZK8Z4VCqRWob26RljMbE6T+iQKH1k+rw9iL2GrGMw368ktJZ9BzcxF lyx1tuu7lRczYhw9z52kATvpdDY0ict1NZRxN7IN+4YWRB/b1lVRG+fhSfqXAlIyDqAW 6wIR/YXu5K8RMHlOYyKpiBQjbeN1AxW7t2/SRD7ZIybscJQhpfoKVT41phGzCsiSn0tt LMe/ZnXJbSHr7vq/rkA2SWxMoXeSJo35sEO+f53bfnD3qh35FUvpRoy7MS1remw4YFQI 0e/w== X-Gm-Message-State: AOJu0YyzDuDMcGnVSouy0o+gZPuvTZdtucZObvsmVZz4YCjyiphCN7MK 7ZVrLxHY+qIKO4btcjXYTQOvYq7NwpN5BdpWsj7ad7u6Ruf7 X-Google-Smtp-Source: AGHT+IGVPIKA2hv///zU1TaxzMEMBi8wnUkdLz4+Cx3Tbs+/t566euiDDh/AhN0LA20w6OQWviIO3Xhcf36NVbEzOLU= X-Received: by 2002:a17:906:6dcf:b0:a28:b535:1f59 with SMTP id j15-20020a1709066dcf00b00a28b5351f59mr660185ejt.120.1704600127086; Sat, 06 Jan 2024 20:02:07 -0800 (PST) MIME-Version: 1.0 References: <817638116.1728541.1704215102364@mail.virginmedia.com> <76537568.1773778.1704276224582@mail.virginmedia.com> <280948347.1804817.1704360742900@mail.virginmedia.com> In-Reply-To: <280948347.1804817.1704360742900@mail.virginmedia.com> From: Bart Schaefer Date: Sat, 6 Jan 2024 20:01:55 -0800 Message-ID: Subject: Re: Regression: 'read -s' does not disable echo To: Peter Stephenson Cc: zsh-workers@zsh.org Content-Type: multipart/mixed; boundary="0000000000000f3ecd060e53255e" X-Seq: 52468 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: --0000000000000f3ecd060e53255e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jan 4, 2024 at 1:32=E2=80=AFAM Peter Stephenson wrote: > > We could use ttyname to check that SHTTY and 0 are the same device. > Then we'd just document that -s and -d (which needs a further patch) > only work on the shell's own terminal. That's not compatible with "read -s" on e.g. bash, if that matters. SHTTY is just a file descriptor number, so this isn't terribly difficult to work around. Bit of a hack here: to avoid changing a large number of lines in utils.c, I hid the global SHTTY behind a local. I think this actually fixes another potential bug where the global tty state (in shttyinfo) was restored even though a possibly different state was in the saveti local. --0000000000000f3ecd060e53255e Content-Type: text/plain; charset="US-ASCII"; name="read-s.txt" Content-Disposition: attachment; filename="read-s.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lr2ysr0r0 ZGlmZiAtLWdpdCBhL1NyYy9idWlsdGluLmMgYi9TcmMvYnVpbHRpbi5jCmluZGV4IDllMDhhMWRi Yy4uNWM1YWRiOWQzIDEwMDY0NAotLS0gYS9TcmMvYnVpbHRpbi5jCisrKyBiL1NyYy9idWlsdGlu LmMKQEAgLTY1MDYsMTAgKzY1MDYsMTAgQEAgYmluX3JlYWQoY2hhciAqbmFtZSwgY2hhciAqKmFy Z3MsIE9wdGlvbnMgb3BzLCBVTlVTRUQoaW50IGZ1bmMpKQogICAgIH0gZWxzZQogCXJlYWRmZCA9 IGl6bGUgPSAwOwogCi0gICAgaWYgKE9QVF9JU1NFVChvcHMsJ3MnKSAmJiBTSFRUWSA9PSByZWFk ZmQpIHsKKyAgICBpZiAoT1BUX0lTU0VUKG9wcywncycpICYmIGlzYXR0eShyZWFkZmQpKSB7CiAJ c3RydWN0IHR0eWluZm8gdGk7CiAJbWVtc2V0KCZ0aSwgMCwgc2l6ZW9mKHN0cnVjdCB0dHlpbmZv KSk7Ci0JZ2V0dHlpbmZvKCZ0aSk7CisJZmRnZXR0eWluZm8ocmVhZGZkLCAmdGkpOwogCXNhdmV0 aSA9IHRpOwogCXJlc2V0dHR5ID0gMTsKICNpZmRlZiBIQVNfVElPCkBAIC02NTE3LDcgKzY1MTcs NyBAQCBiaW5fcmVhZChjaGFyICpuYW1lLCBjaGFyICoqYXJncywgT3B0aW9ucyBvcHMsIFVOVVNF RChpbnQgZnVuYykpCiAjZWxzZQogCXRpLnNndHR5Yi5zZ19mbGFncyAmPSB+RUNITzsKICNlbmRp ZgotCXNldHR5aW5mbygmdGkpOworCWZkc2V0dHlpbmZvKHJlYWRmZCwgJnRpKTsKICAgICB9CiAK ICAgICAvKiBoYW5kbGUgcHJvbXB0ICovCkBAIC02NTU1LDkgKzY1NTUsOSBAQCBiaW5fcmVhZChj aGFyICpuYW1lLCBjaGFyICoqYXJncywgT3B0aW9ucyBvcHMsIFVOVVNFRChpbnQgZnVuYykpCiAg ICAgICAgIGRlbGltID0gKHVuc2lnbmVkIGNoYXIpICgoZGVsaW1zdHJbMF0gPT0gTWV0YSkgPwog CQkJZGVsaW1zdHJbMV0gXiAzMiA6IGRlbGltc3RyWzBdKTsKICNlbmRpZgotCWlmIChTSFRUWSA9 PSByZWFkZmQpIHsKKwlpZiAoaXNhdHR5KHJlYWRmZCkpIHsKIAkgICAgc3RydWN0IHR0eWluZm8g dGk7Ci0JICAgIGdldHR5aW5mbygmdGkpOworCSAgICBmZGdldHR5aW5mbyhyZWFkZmQsICZ0aSk7 CiAJICAgIGlmICghIHJlc2V0dHR5KSB7CiAJICAgICAgc2F2ZXRpID0gdGk7CiAJICAgICAgcmVz ZXR0dHkgPSAxOwpAQCAtNjU2OSw3ICs2NTY5LDcgQEAgYmluX3JlYWQoY2hhciAqbmFtZSwgY2hh ciAqKmFyZ3MsIE9wdGlvbnMgb3BzLCBVTlVTRUQoaW50IGZ1bmMpKQogI2Vsc2UKIAkgICAgdGku c2d0dHliLnNnX2ZsYWdzIHw9IENCUkVBSzsKICNlbmRpZgotCSAgICBzZXR0eWluZm8oJnRpKTsK KwkgICAgZmRzZXR0eWluZm8ocmVhZGZkLCAmdGkpOwogCX0KICAgICB9CiAgICAgaWYgKE9QVF9J U1NFVChvcHMsJ3QnKSkgewpAQCAtNjYwNCw4ICs2NjA0LDggQEAgYmluX3JlYWQoY2hhciAqbmFt ZSwgY2hhciAqKmFyZ3MsIE9wdGlvbnMgb3BzLCBVTlVTRUQoaW50IGZ1bmMpKQogCQkJICAgdGlt ZW91dCkpIHsKIAkJaWYgKGtleXMgJiYgIXpsZWFjdGl2ZSAmJiAhaXNlbSkKIAkJICAgIHNldHR5 aW5mbygmc2h0dHlpbmZvKTsKLQkJZWxzZSBpZiAocmVzZXR0dHkgJiYgU0hUVFkgIT0gLTEpCi0J CSAgICBzZXR0eWluZm8oJnNhdmV0aSk7CisJCWVsc2UgaWYgKHJlc2V0dHR5KQorCQkgICAgZmRz ZXR0eWluZm8ocmVhZGZkLCAmc2F2ZXRpKTsKIAkJaWYgKGhhc28pIHsKIAkJICAgIGlmIChzaG91 dCkKIAkJCWZjbG9zZShzaG91dCk7CkBAIC02NzE3LDcgKzY3MTcsNyBAQCBiaW5fcmVhZChjaGFy ICpuYW1lLCBjaGFyICoqYXJncywgT3B0aW9ucyBvcHMsIFVOVVNFRChpbnQgZnVuYykpCiAJICAg IGlmIChpc2VtKQogCQl3aGlsZSAodmFsID4gMCAmJiByZWFkKFNIVFRZLCAmZCwgMSkgPT0gMSAm JiBkICE9ICdcbicpOwogCSAgICBlbHNlIGlmIChyZXNldHR0eSkgewotCQlzZXR0eWluZm8oJnNo dHR5aW5mbyk7CisJCWZkc2V0dHlpbmZvKHJlYWRmZCwgJnNhdmV0aSk7CiAJCXJlc2V0dHR5ID0g MDsKIAkgICAgfQogCSAgICBpZiAoaGFzbykgewpAQCAtNjc0Niw4ICs2NzQ2LDggQEAgYmluX3Jl YWQoY2hhciAqbmFtZSwgY2hhciAqKmFyZ3MsIE9wdGlvbnMgb3BzLCBVTlVTRUQoaW50IGZ1bmMp KQogCSAgICBzZXRzcGFyYW0ocmVwbHksIG1ldGFmeShidWYsIGJwdHIgLSBidWYsIE1FVEFfUkVB TExPQykpOwogCWVsc2UKIAkgICAgemZyZWUoYnVmLCBicHRyIC0gYnVmICsgMSk7Ci0JaWYgKHJl c2V0dHR5ICYmIFNIVFRZICE9IC0xKQotCSAgICBzZXR0eWluZm8oJnNhdmV0aSk7CisJaWYgKHJl c2V0dHR5KQorCSAgICBmZHNldHR5aW5mbyhyZWFkZmQsICZzYXZldGkpOwogCXJldHVybiBlb2Y7 CiAgICAgfQogCkBAIC02OTU3LDggKzY5NTcsOCBAQCBiaW5fcmVhZChjaGFyICpuYW1lLCBjaGFy ICoqYXJncywgT3B0aW9ucyBvcHMsIFVOVVNFRChpbnQgZnVuYykpCiAJICAgICpwcCsrID0gTlVM TDsKIAkgICAgc2V0YXBhcmFtKHJlcGx5LCBwKTsKIAl9Ci0JaWYgKHJlc2V0dHR5ICYmIFNIVFRZ ICE9IC0xKQotCSAgICBzZXR0eWluZm8oJnNhdmV0aSk7CisJaWYgKHJlc2V0dHR5KQorCSAgICBm ZHNldHR5aW5mbyhyZWFkZmQsICZzYXZldGkpOwogCXJldHVybiBjID09IEVPRjsKICAgICB9CiAg ICAgYnVmID0gYnB0ciA9IChjaGFyICopemFsbG9jKGJzaXogPSA2NCk7CkBAIC03MDg2LDggKzcw ODYsOCBAQCBiaW5fcmVhZChjaGFyICpuYW1lLCBjaGFyICoqYXJncywgT3B0aW9ucyBvcHMsIFVO VVNFRChpbnQgZnVuYykpCiAJICAgIGJyZWFrOwogICAgIH0KICAgICAqYnB0ciA9ICdcMCc7Ci0g ICAgaWYgKHJlc2V0dHR5ICYmIFNIVFRZICE9IC0xKQotCXNldHR5aW5mbygmc2F2ZXRpKTsKKyAg ICBpZiAocmVzZXR0dHkpCisJZmRzZXR0eWluZm8ocmVhZGZkLCAmc2F2ZXRpKTsKICAgICAvKiBm aW5hbCBhc3NpZ25tZW50IG9mIHJlcGx5LCBldGMuICovCiAgICAgaWYgKE9QVF9JU1NFVChvcHMs J2UnKSB8fCBPUFRfSVNTRVQob3BzLCdFJykpIHsKIAl6cHV0cyhidWYsIHN0ZG91dCk7CmRpZmYg LS1naXQgYS9TcmMvdXRpbHMuYyBiL1NyYy91dGlscy5jCmluZGV4IDBmNjY5ODRjZC4uMWE0ZjRj MTRiIDEwMDY0NAotLS0gYS9TcmMvdXRpbHMuYworKysgYi9TcmMvdXRpbHMuYwpAQCAtMTczMCw2 ICsxNzMwLDEzIEBAIGZyZWVzdHIodm9pZCAqYSkKIC8qKi8KIG1vZF9leHBvcnQgdm9pZAogZ2V0 dHlpbmZvKHN0cnVjdCB0dHlpbmZvICp0aSkKK3sKKyAgICBmZGdldHR5aW5mbyhTSFRUWSwgdGkp OworfQorCisvKiovCittb2RfZXhwb3J0IHZvaWQKK2ZkZ2V0dHlpbmZvKGludCBTSFRUWSwgc3Ry dWN0IHR0eWluZm8gKnRpKQogewogICAgIGlmIChTSFRUWSAhPSAtMSkgewogI2lmZGVmIEhBVkVf VEVSTUlPU19ICkBAIC0xNzU1LDYgKzE3NjIsMTMgQEAgZ2V0dHlpbmZvKHN0cnVjdCB0dHlpbmZv ICp0aSkKIC8qKi8KIG1vZF9leHBvcnQgdm9pZAogc2V0dHlpbmZvKHN0cnVjdCB0dHlpbmZvICp0 aSkKK3sKKyAgICBmZHNldHR5aW5mbyhTSFRUWSwgdGkpOworfQorCisvKiovCittb2RfZXhwb3J0 IHZvaWQKK2Zkc2V0dHlpbmZvKGludCBTSFRUWSwgc3RydWN0IHR0eWluZm8gKnRpKQogewogICAg IGlmIChTSFRUWSAhPSAtMSkgewogI2lmZGVmIEhBVkVfVEVSTUlPU19ICg== --0000000000000f3ecd060e53255e--