zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Sebastian Gniazdowski <sgniazdowski@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] Index of element after width of characters
Date: Tue, 27 Oct 2015 14:20:10 -0700	[thread overview]
Message-ID: <CAH+w=7b1RQDPWw0u7NSDs9wdxC-rCQYvyXadKCd1pdNXEdFuXA@mail.gmail.com> (raw)
In-Reply-To: <CAKc7PVC4LFGnBJau3gWuws3bTgc+zcnEE+o-B8ZmKEEWa8Kpog@mail.gmail.com>

On Tue, Oct 27, 2015 at 10:18 AM, Sebastian Gniazdowski
<sgniazdowski@gmail.com> wrote:
> y:width:
> Index-post-width: for strings substitutes index of first character that is

In the patch file you attached, the doc refers to x:...: rather than
y, whereas the code uses 'y'.  I do find this to be a pretty highly
specialized operation, though, and I'm not sure I like the idea of
using up more of our limited number of remaining single-character flag
letters for it.

> The code works, however not in the test that I commit. Wonder why it
> works in scripts and at prompt but not in the test?

Did you make sure that the LANG and or LC_* etc. environment variables
are set correctly in the test script?  Also this test should probably
be appended to D07multibyte rather than have its own new file.  (That
would ensure that LANG etc. are properly set, too.)  I don't find a
test of the (m) flag anywhere in Test/*.ztst either, for that matter
-- hard to decide if this belongs in D04 or D07 but I tend to think
the latter.


  parent reply	other threads:[~2015-10-27 21:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 17:18 Sebastian Gniazdowski
2015-10-27 19:41 ` Mikael Magnusson
2015-10-27 19:55 ` Sebastian Gniazdowski
2015-10-27 21:20 ` Bart Schaefer [this message]
2015-10-28  7:46   ` Sebastian Gniazdowski
2015-10-28  7:54     ` Sebastian Gniazdowski
2015-10-28 11:38       ` Sebastian Gniazdowski
2015-10-28 13:31         ` Mikael Magnusson
2015-10-28 15:46           ` Sebastian Gniazdowski
2015-10-28 15:59             ` Peter Stephenson
2015-10-28 16:37               ` Sebastian Gniazdowski
2015-10-28 23:07               ` Bart Schaefer
2015-10-29  9:42                 ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7b1RQDPWw0u7NSDs9wdxC-rCQYvyXadKCd1pdNXEdFuXA@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=sgniazdowski@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).