zsh-workers
 help / color / mirror / code / Atom feed
* [PATCH v2] prompt: support generic non-visible regions
@ 2022-08-11 23:09 Felipe Contreras
  2022-08-14 19:57 ` Bart Schaefer
  2022-08-22  0:11 ` [PATCH v3] " Felipe Contreras
  0 siblings, 2 replies; 10+ messages in thread
From: Felipe Contreras @ 2022-08-11 23:09 UTC (permalink / raw)
  To: zsh-workers; +Cc: Felipe Contreras

readline uses \001 (start of header) and \002 (start of text) as markers
to delimit a non-visible character zone, which are necessary to
calculate the width of a prompt.

In zsh we do this with %{ and %}, but we could support
\001 and \002 as well, so that a function which generates output for
the prompt can use colors in a way that works for both bash and zsh.

This additionally has the benefit of allowing prompts without
PROMPT_PERCENT to use colors correctly.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---

No changes since v1 other than the commit message.

 Src/prompt.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Src/prompt.c b/Src/prompt.c
index 092de63a4..803937029 100644
--- a/Src/prompt.c
+++ b/Src/prompt.c
@@ -886,6 +886,12 @@ putpromptchar(int doprint, int endchar, zattr *txtchangep)
 		    bv->bp += strlen(bv->bp);
 		}
 	    }
+	} else if(*bv->fm == 0x01) { // start non-visible characters
+	    addbufspc(1);
+	    *bv->bp++ = Inpar;
+	} else if(*bv->fm == 0x02) { // end non-visible characters
+	    addbufspc(1);
+	    *bv->bp++ = Outpar;
 	} else {
 	    char c = *bv->fm == Meta ? *++bv->fm ^ 32 : *bv->fm;
 
-- 
2.37.1



^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2022-08-22  0:18 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-11 23:09 [PATCH v2] prompt: support generic non-visible regions Felipe Contreras
2022-08-14 19:57 ` Bart Schaefer
2022-08-14 22:46   ` Felipe Contreras
2022-08-15  1:00     ` Bart Schaefer
2022-08-15 21:37       ` Felipe Contreras
2022-08-17 22:31         ` Bart Schaefer
2022-08-17 22:48           ` Bart Schaefer
2022-08-22  0:17             ` Felipe Contreras
2022-08-22  0:15           ` Felipe Contreras
2022-08-22  0:11 ` [PATCH v3] " Felipe Contreras

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).