zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Daniel Shahaf <d.s@daniel.shahaf.name>,
	Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Bug in completion with curly braces?
Date: Mon, 23 Nov 2020 09:31:50 -0800	[thread overview]
Message-ID: <CAH+w=7bAL3XO0HW59EDsM2rzTrEbyevWNuGoBUEwt7N9B4-WyA@mail.gmail.com> (raw)
In-Reply-To: <CAMP44s1AOsnpqvVF2FAb7XRx3E4sfFV3-=xDfvk1WTMgWGcdYg@mail.gmail.com>

On Sun, Nov 22, 2020 at 10:46 PM Felipe Contreras
<felipe.contreras@gmail.com> wrote:
>
> Yeah, this almost works, but I'm not interested in hacks.
[...]
> I'm not going to add dozens of lines of code just for this corner-case
> depending on the value of $1. If compadd doesn't work on this case,
> then it doesn't work on this case.

There could easily be more documentation around "compadd -Q", because
really it is itself a hack.

The parts of completion that analyze/dismantle the string on the
command line, before _main_complete or another entry point are even
called, are always going to process the line as if special characters
that are not quoted do in fact have their special meanings.  The real
purpose of -Q is not to disable quoting, it's to indicate that the
calling function has already applied the appropriate quoting and
therefore compadd should not also attempt it.

Consequently if the calling function does not apply quoting, -Q is
only going to work well in cases where the matches either have no
common prefixes, or the common prefixes do not contain any of the
special characters, or menu completion is going to be forced (so the
user selects an entire match all at once rather than exit/re-enter
completion with the prefix).

(I would be happy to have someone (Oliver?) argue the untruth of that
last statement.)


  parent reply	other threads:[~2020-11-23 17:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-20  1:50 Felipe Contreras
2020-11-20  2:52 ` Mikael Magnusson
2020-11-21 15:28 ` Daniel Shahaf
2020-11-21 21:08   ` Felipe Contreras
2020-11-21 22:32     ` Bart Schaefer
2020-11-22  0:37       ` Felipe Contreras
2020-11-22  2:28         ` Bart Schaefer
2020-11-22  2:58           ` Felipe Contreras
2020-11-22 20:35             ` Bart Schaefer
2020-11-22 21:20               ` Bart Schaefer
2020-11-23  3:03               ` Daniel Shahaf
2020-11-23  7:15                 ` Bart Schaefer
2020-11-23  6:46               ` Felipe Contreras
2020-11-23  7:17                 ` Bart Schaefer
2021-04-18 21:43                   ` Bart Schaefer
2020-11-23 17:31                 ` Bart Schaefer [this message]
2020-11-24 23:21                   ` Oliver Kiddle
2020-11-25  5:06                     ` Felipe Contreras
2021-12-02 19:45                       ` PATCH: bashcompinit quoting (was Re: Bug in completion with curly braces?) Oliver Kiddle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7bAL3XO0HW59EDsM2rzTrEbyevWNuGoBUEwt7N9B4-WyA@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=d.s@daniel.shahaf.name \
    --cc=felipe.contreras@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).