From: Bart Schaefer <schaefer@brasslantern.com>
To: Philippe Altherr <philippe.altherr@gmail.com>
Cc: "Lawrence Velázquez" <larryv@zsh.org>, zsh-workers@zsh.org
Subject: Re: [PATCH] Fix ERR_EXIT behavior in function calls and "always" statements
Date: Mon, 21 Nov 2022 20:51:25 -0800 [thread overview]
Message-ID: <CAH+w=7bDCd8=DxD=xL69erW3iXzSaZatixcmwDn5_+EceqctCA@mail.gmail.com> (raw)
In-Reply-To: <CAGdYchvM8uwvQ9B-S4n_-oMQkNqgZZrqG9jwYCV7Nz+5Lo6Q=w@mail.gmail.com>
On Mon, Nov 21, 2022 at 6:52 PM Philippe Altherr
<philippe.altherr@gmail.com> wrote:
>
For anyone arriving in the middle of the conversation or viewing this
in the archives --
Please note that I wrote this:
>> Each time though, you've removed the NEWS item. Although we've
>> established that the behavior it describes was not actually
>> appropriate, there still has been a change in ERR_EXIT behavior that
>> probably warrants a mention. What's the best description of that?
Whereas Lawrence wrote this:
>> This suggests that anonymous
>> functions should *not* behave like normal function calls here.
> That's debatable. If, like me, you see anonymous functions as some kind of syntactic sugar, then it makes sense that they behave like function calls and exit. However, I can also understand that others rather see them as another type of compound command. In that case, they should not exit.
I think it's probably more appropriate to view a function, even an
anonymous one, like a subshell rather than like either a simple or a
complex command. Subshells also "pop the bubble" to use Lawrence's
analogy, so it's probably fine for anonymous functions to do so.
> FYI: Here are my next steps
> - Write NEWS for my 3 fixes.
> - Better document the role and usage of noerrexit and this_noerrexit.
> - Try to fix "eval", "source", and possibly a bunch of other related cases.
>
> Unless anyone sees a reason not to, it would be nice to submit my first pacth, which reverts Bart's changes. For the other patches, I have at the very least to first add a NEWS item.
I don't think there's any requirement that the NEWS item arrive at the
same time as the other three patches. We sometimes don't add NEWS
until the time of a release, months (years) after a patch was pushed
to sourceforge git.
I'd also prefer to post all your patches at once because you attached
them all to the same zsh-workers article. Convention has been that a
series of patches should be sent as a series of articles.
I think I will go ahead and remove (most of) the ChangeLog references
to my patches, unless anyone feels they're important for context (the
git log of course remains).
next prev parent reply other threads:[~2022-11-22 4:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 14:40 Philippe Altherr
2022-11-19 13:39 ` Philippe Altherr
2022-11-21 0:43 ` Bart Schaefer
2022-11-21 7:22 ` Lawrence Velázquez
2022-11-22 2:52 ` Philippe Altherr
2022-11-22 4:51 ` Bart Schaefer [this message]
2022-11-22 10:17 ` Peter Stephenson
2022-11-23 8:11 ` Lawrence Velázquez
2022-11-23 6:59 ` Lawrence Velázquez
2022-11-23 9:43 ` Philippe Altherr
2022-11-23 16:11 ` Bart Schaefer
2022-11-23 20:57 ` Submitting multiple patches (was: Re: [PATCH] Fix ERR_EXIT behavior in function calls and "always" statements) Daniel Shahaf
2022-11-23 21:11 ` Bart Schaefer
2022-11-23 21:22 ` Bart Schaefer
2022-11-23 21:54 ` Bart Schaefer
2022-11-24 2:21 ` Philippe Altherr
2022-11-26 2:28 ` Bart Schaefer
2022-11-26 4:02 ` Philippe Altherr
2022-11-24 1:47 ` [PATCH] Fix ERR_EXIT behavior in function calls and "always" statements Philippe Altherr
2022-11-24 4:28 ` Lawrence Velázquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7bDCd8=DxD=xL69erW3iXzSaZatixcmwDn5_+EceqctCA@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=larryv@zsh.org \
--cc=philippe.altherr@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).