From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 2969 invoked from network); 17 Jul 2023 15:59:19 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 17 Jul 2023 15:59:19 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1689609559; b=k85kgEIw83txSb1OHH1pVVZrfuFVO5Ha17azpt/gZTOTBMeS+JqWk+c93oMeptKPLxf2s38oH5 PG7a/HPluj1cr74noj19dKiT757VmssRHzCUJR2Hxm9C46m6rebR9u8XYLJEltnBM2jc4va9qU tiCnNJ3+PibjB72j0cvxkCFjWMtSk8Asm2o44+U6OPO5mEzcYxZkoIB629YXASPy7+LufHMy5C vEriYSpf64a0Ic3OfwtbygVcNQiST5G9Ln/Efr3qEuKBqb/p19hAlmaedpQafwQd9ycZjAbIn3 gc5mjJviIFMF35QfnzuHV5hDTEXY02hkRV0yzeLC0+BE+g==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f42.google.com) smtp.remote-ip=209.85.218.42; dkim=pass header.d=brasslantern-com.20221208.gappssmtp.com header.s=20221208 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1689609559; bh=z17d+ssmDhPIT2DgK2ytomjIKdSNXfvcAlR7OHOVZx0=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature: DKIM-Signature; b=i4lDgVI2R4Iz/VAo1nHEJ+Di7Nzn90Dj0onV7Be/HafTMVhVV51Jphkm0mp4kTWlJpnAH8qG1K C7cla14c0h+jmIq1W9sVkcvsSt0QD/A4w1QpuVkKqFN4QZ7jdb/Q3UogmPLcozPsbc6XiIE2ag e0aVzydxtTMWBKp95IUQe1MAfose/D8FRWG4QVVs+KgRKo4mgH0H4cImHG9NJ2czAsDecWgTBe RHEdhJCrylGMuvkDgrV99Y7pmF19XyJS4qld0G0YiZR3faadKZdRgOeGWwOimuuKG0TqVwzBjG mee1Jkr1jksedlwPkWRqNCDpybH+lg18vfzvQQzpOf6Ebw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=TC5eE9GQBJK59ct6eLBoo7OboKibgZD1vvWgveuUzEM=; b=P1idc5E0h2dNCatkJMEfYAE2TI YWvA7faLTBQ7gPj/8D/ned8XltPJT7L04Pgk97Bu/X4FjNIkpy/N/mr6QxFsrAEhkOL14p7XmnO1l UgOAqBmhCcV2eTZeR1Gm7uJS8qv7if7E++cOH3ZTSPHVyeguprhkOOpr98h6ZFJl3fixVSNQQiDWR KAUq0E1TUEL4lXts5KfLIEfz/EDOBGEat4z4qz3csbdyFaCkFUo8Gd0YBE5oa34HdLI+Hz46JZHcO U4QaBBXcu/q/6PaF7MeRERaLJ8CLPUcI87BtWyRS9YLDgN6LmzJvwrR4tjxF4F2qoCpyP/FTYpX/F IwjJYu5g==; Received: by zero.zsh.org with local id 1qLQd5-000EJc-It; Mon, 17 Jul 2023 15:59:19 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f42.google.com) smtp.remote-ip=209.85.218.42; dkim=pass header.d=brasslantern-com.20221208.gappssmtp.com header.s=20221208 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ej1-f42.google.com ([209.85.218.42]:46239) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1qLQbE-000DPQ-Vv; Mon, 17 Jul 2023 15:57:27 +0000 Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-98377c5d53eso638632566b.0 for ; Mon, 17 Jul 2023 08:57:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20221208.gappssmtp.com; s=20221208; t=1689609444; x=1692201444; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TC5eE9GQBJK59ct6eLBoo7OboKibgZD1vvWgveuUzEM=; b=TY619tULqhrYdpEVw/YhTVlIqpSUSif8TTBYIQYx7xMEFz7J5JPTXqGdenPMoVTgyX /eIGch0EudlKPfGZ0fErxSfKFWeJ6VQVZKSBHxQmnnP+UArRjWi1L6C5r4Ypmcpt739P DWtXZJBBWouEkeUKppaO+46Q4fWlyhxaxKOh8Zie9+/TeKB0k+8xkAx1FqvNUHeIVSPm rB2HU2az22D5ubXX4LpsyrOnjYb2n9mgsqRr1bFQZ9rnyfw/kQozYuEZIhlkhORsb5Oi ssowF6ADYLVs0WRXDGHnY3gwQnPbSYuSRRM587qzSXa1IQCoMgn1n+Xar3FCvbu+8BeK fKfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689609444; x=1692201444; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TC5eE9GQBJK59ct6eLBoo7OboKibgZD1vvWgveuUzEM=; b=lnFbDz6TXA9b+/M/Th0WtIzi5oDcaa3DGUqWwlEHSAMUOmG0A0fKVFEhzENdDnY8N8 vYXMgIYv1JKQQfPl7TOl+gH0i4qIB0PjeB6SNTGo0B7Xd3GaryejAi6zIviito3zTI5Q DOnGTbkb4vD+MJ2daEkX8Ofrt8HM66wWYKFW1WI21WjJEjSl+ac7EvfZLe0IXNQ5/35c dotOz/DrS8Bx9X6tC3iPPB3n68mOwXn5JjJjnF0oPmuFi3SsiaMhlOiBhngqQm4a63jB Uv2YncETGwc1lBftCrdYTk8NxXLXFb/pPI96ZxBKlXXTHCNVM1rH2ii01HhNObMLQjc5 9H3A== X-Gm-Message-State: ABy/qLZyYBcXeKO0kdNHHKC7SoNRMal8lTlIOPC1pGfDFGgArgtvOwWC W8eoEJ31G0aedjg/GIuuktwI/Q7aJKQGt2V3MO9Ca8eJAYDwUj8KMAs= X-Google-Smtp-Source: APBJJlGcdoGJ7Ck4HDHvoGxfGqixI+xf+4JICI4SpJ6ftdo8cMrXL96OIGu03KbHP7JfDCTAFjShKItkcJxe8IGkcAI= X-Received: by 2002:a17:906:51da:b0:994:4f08:2bad with SMTP id v26-20020a17090651da00b009944f082badmr7775976ejk.69.1689609444593; Mon, 17 Jul 2023 08:57:24 -0700 (PDT) MIME-Version: 1.0 References: <422608219.9324398.1673947338127@mail.virginmedia.com> <974250f6-d143-4543-872e-05c72f67a98c@app.fastmail.com> In-Reply-To: From: Bart Schaefer Date: Mon, 17 Jul 2023 08:57:13 -0700 Message-ID: Subject: Re: [PATCH] Re: Bug: Callback to widget set with `zle -Fw ` shouldn't change $LASTWIDGET To: dana Cc: Zsh hackers list , Peter Stephenson Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 51949 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On Mon, Jul 17, 2023 at 8:52=E2=80=AFAM dana wrote: > > Sorry, i'm not very familiar with the LASTWIDGET mechanism, but by the pa= tch > at the start of this thread you mean workers/51310, right? It was committ= ed > as f93ad02b94bd (Facepalm) Looked at the wrong source file. > I should have mentioned that i did a (manual) bisect to confirm that that= is > when the problem started for me; the poster in workers/51673 found the sa= me OK, then it IS a reference counting problem. Try this. diff --git a/Src/Zle/zle_main.c b/Src/Zle/zle_main.c index 4a6c02133..6e554f4b8 100644 --- a/Src/Zle/zle_main.c +++ b/Src/Zle/zle_main.c @@ -737,7 +737,7 @@ raw_getbyte(long do_keytmout, char *cptr, int full) ) { /* Handle the fd. */ char *fdbuf; - Thingy save_lbindk =3D lbindk; + Thingy save_lbindk =3D refthingy(lbindk); { char buf[BDIGBUFSIZE]; convbase(buf, lwatch_fd->fd, 10); @@ -781,6 +781,7 @@ raw_getbyte(long do_keytmout, char *cptr, int full) errtry =3D 1; } lbindk =3D save_lbindk; + unrefthingy(save_lbindk); } } /* Function may have invalidated the display. */