Dump of backlogged commits coming

Dump of backlogged commits coming

[Bart Schaefer]

I finally had several daylight hours with nothing else to do, so here
come 12 commits for patches that I either wrote or indicated that I
would commit on behalf of others (plus a 13th from Marlon that just
came in today).

Here's the ChangeLog entry:

2021-09-06  Bart Schaefer  <schaefer@zsh.org>

        * Stephane Chazelas: 45180: Doc/Zsh/contrib.yo,
        Functions/Example/zpgrep, Functions/Misc/regexp-replace: clarify
        doc for POSIX EREs, fix an issue with PCRE when the replacement
        was empty or generated more than one element

        * zeurkous: 49154: Doc/Zsh/exec.yo: clarify status on exec failure

        * Marlon Richert: 49378: Src/parse.c: skip check for collision
        of aliases and functions when NO_EXEC

        * Marlon Richert: 49292: Src/Zle/complist.c: turn off colors
        before clearing to end of line

        * 49282: set $0 correctly when calling functions from hooks

        * 49266: fix segfault on metacharacters in long job texts

        * Marlon Richert: 49218: Functions/Misc/run-help,
        Functions/Misc/run-help-btrfs, Functions/Misc/run-help-git,
        Functions/Misc/run-help-ip, Functions/Misc/run-help-p4,
        Functions/Misc/run-help-svk, Functions/Misc/run-help-svn:
        run-help filters cmd_args before calling run-help-<command>

        * unposted (cf. 49202 and 49217): Src/Zle/zle_hist.c: insertlastword
        ignores blank/missing history entries when repeating

        * 49196: Src/Modules/db_gdbm.c: gdbm keys not present in the
        database appear unset in tied hashes

        * Marlon Richert: 48969: fix for "zle -N" completion

        * 48888: Doc/Zsh/mod_system.yo, Doc/Zsh/params.yo, Test/E03posix.ztst:
        improve doc for $$ and $PPID, add fail test for PPID readonly-ness

        * 48832: Completion/Unix/Type/_urls: try _gnu_generic first

Re: Dump of backlogged commits coming

[Vin Shelton]

[-- Attachment #1: Type: text/plain, Size: 3464 bytes --]

Perhaps one of these commits is the reason for this test failure:

ZTST_verbose=2 TESTNUM=Z03 make check
cd Test ; make check
make[1]: Entering directory '/SSD-2/opt/build/zsh-2021-09-07/Test'
if test -n "gcc"; then \
  cd .. && DESTDIR= \
  make MODDIR=`pwd`/Test/Modules install.modules > /dev/null; \
fi
if test -z "$ZTST_handler"; then \
  ZTST_handler=runtests.zsh; \
fi; \
if ZTST_testlist="`for f in ../../../src/zsh-2021-09-07/Test/Z03*.ztst; \
           do echo $f; done`" \
 ZTST_srcdir="../../../src/zsh-2021-09-07/Test" \
 ZTST_exe=../Src/zsh \
 ../Src/zsh +Z -f ../../../src/zsh-2021-09-07/Test/$ZTST_handler; then \
 stat=0; \
else \
 stat=1; \
fi; \
sleep 1; \
rm -rf Modules .zcompdump; \
exit $stat
../../../src/zsh-2021-09-07/Test/Z03run-help.ztst: starting.
ZTST_getsect: read section name: prep
ZTST_getchunk: read code chunk:
  PAGER=cat
  unalias run-help
  autoload +X -Uz $PWD/../Functions/Misc/run-help*
  builtin() {
    case "$1 $2" in
      ( 'getln cmd_args' )
        cmd_args="$BUFFER_STACK"
      ;;
      ( 'print -z' )
      ;;
      ( 'whence -va' )
        print -l "$3 is WHENCE:{$3}"
      ;;
      ( * )
        eval $@
      ;;
    esac
  }
  man() {
    [[ $1 == -w && -n $NO_SUBCMD_MANUALS ]] &&
        return 1
    print "MAN:{${(qq)@}}"
  }
  git svn () {
    print "${(U)0}:{${(qq)@}}"
  }
(eval):3: no matches found:
/opt/build/zsh-2021-09-07/Test/../Functions/Misc/run-help*
ZTST_execchunk: status 1
Test ../../../src/zsh-2021-09-07/Test/Z03run-help.ztst failed: non-zero
status from preparation code:
  PAGER=cat
  unalias run-help
  autoload +X -Uz $PWD/../Functions/Misc/run-help*
  builtin() {
    case "$1 $2" in
      ( 'getln cmd_args' )
        cmd_args="$BUFFER_STACK"
      ;;
      ( 'print -z' )
      ;;
      ( 'whence -va' )
        print -l "$3 is WHENCE:{$3}"
      ;;
      ( * )
        eval $@
      ;;
    esac
  }
  man() {
    [[ $1 == -w && -n $NO_SUBCMD_MANUALS ]] &&
        return 1
    print "MAN:{${(qq)@}}"
  }
  git svn () {
    print "${(U)0}:{${(qq)@}}"
  }
../../../src/zsh-2021-09-07/Test/Z03run-help.ztst: test failed.
ZTST_getchunk: read code chunk:

ZTST_getsect: read section name: test
ZTST_test: looking for new test
ZTST_test: examining line:

ZTST_test: examining line:
  BUFFER_STACK='btrfs --help'
ZTST_getchunk: read code chunk:
  BUFFER_STACK='btrfs --help'
  run-help btrfs
ZTST_test: examining line:
>btrfs is WHENCE:{btrfs}
ZTST_getredir: read redir for '>':
btrfs is WHENCE:{btrfs}
MAN:{'btrfs'}
ZTST_test: examining line:

Running test: btrfs with option flag, no subcmd
ZTST_test: expecting status: 0
Input: /tmp/zsh.ztst.111953/ztst.in, output: /tmp/zsh.ztst.111953/ztst.out,
error: /tmp/zsh.ztst.111953/ztst.terr
ZTST_execchunk: status 127
Test ../../../src/zsh-2021-09-07/Test/Z03run-help.ztst failed: bad status
127, expected 0 from:
  BUFFER_STACK='btrfs --help'
  run-help btrfs
Error output:
(eval):2: command not found: run-help
Was testing: btrfs with option flag, no subcmd
../../../src/zsh-2021-09-07/Test/Z03run-help.ztst: test failed.
ZTST_getsect: read section name: clean
ZTST_getchunk: read code chunk:

**************************************
0 successful test scripts, 1 failure, 0 skipped
**************************************
make[1]: *** [Makefile:190: check] Error 1
make[1]: Leaving directory '/SSD-2/opt/build/zsh-2021-09-07/Test'
make: *** [Makefile:263: check] Error 2


This is the most recent Arch linux, in case that helps.

  - Vin

[-- Attachment #2: Type: text/html, Size: 5006 bytes --]

Re: Dump of backlogged commits coming

[Bart Schaefer]

On Tue, Sep 7, 2021 at 6:28 AM Vin Shelton <acs@alumni.princeton.edu> wrote:
>
> Perhaps one of these commits is the reason for this test failure:

Yes, that would be this one:

        * Marlon Richert: 49218: Functions/Misc/run-help,
        Functions/Misc/run-help-btrfs, Functions/Misc/run-help-git,
        Functions/Misc/run-help-ip, Functions/Misc/run-help-p4,
        Functions/Misc/run-help-svk, Functions/Misc/run-help-svn:
        run-help filters cmd_args before calling run-help-<command>

The Z03 test is new (I missed adding it to the ChangeLog entry) and
does not handle separation of source tree / build tree.

Does this fix it?

diff --git a/Test/Z03run-help.ztst b/Test/Z03run-help.ztst
index 2bb3bceed..ca8ba4d04 100644
--- a/Test/Z03run-help.ztst
+++ b/Test/Z03run-help.ztst
@@ -1,7 +1,7 @@
 %prep
   PAGER=cat
   unalias run-help
-  autoload +X -Uz $PWD/../Functions/Misc/run-help*
+  autoload +X -Uz ${^fpath}/run-help*(N)
   builtin() {
     case "$1 $2" in
       ( 'getln cmd_args' )

Re: Dump of backlogged commits coming

[Vin Shelton]

[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]

Yes, that WFM.  As you surmised, my build directory is not the same as my
source directory.

Thanks,
  Vin


On Tue, Sep 7, 2021 at 4:43 PM Bart Schaefer <schaefer@brasslantern.com>
wrote:

> On Tue, Sep 7, 2021 at 6:28 AM Vin Shelton <acs@alumni.princeton.edu>
> wrote:
> >
> > Perhaps one of these commits is the reason for this test failure:
>
> Yes, that would be this one:
>
>         * Marlon Richert: 49218: Functions/Misc/run-help,
>         Functions/Misc/run-help-btrfs, Functions/Misc/run-help-git,
>         Functions/Misc/run-help-ip, Functions/Misc/run-help-p4,
>         Functions/Misc/run-help-svk, Functions/Misc/run-help-svn:
>         run-help filters cmd_args before calling run-help-<command>
>
> The Z03 test is new (I missed adding it to the ChangeLog entry) and
> does not handle separation of source tree / build tree.
>
> Does this fix it?
>
> diff --git a/Test/Z03run-help.ztst b/Test/Z03run-help.ztst
> index 2bb3bceed..ca8ba4d04 100644
> --- a/Test/Z03run-help.ztst
> +++ b/Test/Z03run-help.ztst
> @@ -1,7 +1,7 @@
>  %prep
>    PAGER=cat
>    unalias run-help
> -  autoload +X -Uz $PWD/../Functions/Misc/run-help*
> +  autoload +X -Uz ${^fpath}/run-help*(N)
>    builtin() {
>      case "$1 $2" in
>        ( 'getln cmd_args' )
>

[-- Attachment #2: Type: text/html, Size: 2234 bytes --]