From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 26622 invoked from network); 18 Feb 2023 17:04:32 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 18 Feb 2023 17:04:32 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1676739872; b=jMemBM/Ael5mGTWq8j9WVzrOESymlsiTPbGQT1gA6Vgy9Na4crafGVoPnwAVtNmzbQkys70wWB qUcAafTqTtIyBf4SSKI73pwXQ1Y2lIoGgt/f+WgqLkcNSVSLbO84ZfBfWmRMljTr6dELGyQwpd Xud1xewQ8WxJ4ScUTWLG4XfUx+bSVKxExJNQsesbx/ZCgB5DI7/3vvkoiqq85TS5uQCcPMjSOF VEZeiHvKW7VdDCCB40ok59SUiY8e8GR6a/jEPrZ9+sErZfFUWu34Ww5kenbh8SSqGFIKha+hFR T3sHrgvsjSFiAxnYlRHeGmjSVR+TgZcYDIVK4sXtsxV0iw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ed1-f51.google.com) smtp.remote-ip=209.85.208.51; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1676739872; bh=OcK8U9dwzn7cRdCwPw19ZmRQT4pLvhEkLjkm8u5au2U=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:To:Subject:Message-ID:Date:From:MIME-Version: DKIM-Signature:DKIM-Signature; b=PmITDJjgROL2IclXqY2mbvpvRvOMSj83xoP9fuvqmOoJQ27uv9ysTH9UVIifCsP1sKtY/NZRru i8zcPC6J2OwyTJ+N5mMdwgMK/5FH8traRCtbCmESp6SDaPaD7MKQOBQrsEHgWTWoqtcJaN3S4a mC+CIQUMvMbwO6mRIykTg5ZAe7lbURNKsSI7Ctb7mkTcvZ10gA6CYbVwHyZsMP2IRVDkZ48aT9 toscBZm/EVWw0QqdiPkHofaluxDzI4ouRfRSmabc1sYZ+VVDLCrmdktGQNjfFXzeTahPIEQZfs 4Wu3rGv0KkvpA3BbGuNHaudJMjaIJJPD6n2eM7Ez0zlX1A==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:To:Subject:Message-ID: Date:From:MIME-Version:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References; bh=OcK8U9dwzn7cRdCwPw19ZmRQT4pLvhEkLjkm8u5au2U=; b=BCck7sSGn6afRcn6SQId+hDSRj 1piZ6DDBliWfumGB9UcCaCE26UAcVLYK3nx0ZJ27VblvAPt6+bKfeEJkstu9yMqsySy2GSNEi4BZZ temktXdt+DK289MDLwSrApMwMjZtx3jnuE2n76GDmm5Iqibctj545V2H7gYNRgrEhNmkDxgDYo1bn 3kukaoCVQ70r3JObPrHS8oNMGLBIOwMl6f4AKWuv4Yq626zDIN/zWt3ZkVQWpTDSbaBB6RD2KCsdU XIHhRSOAFDOMBtvJ1QHCdxG2mZ5bjEmHbx8WqMitTT2Ozuyj+9H5GFosT/OTnqnMCT7vfDfvWYslH Q+DXTNsg==; Received: by zero.zsh.org with local id 1pTQdU-000GXQ-4g; Sat, 18 Feb 2023 17:04:32 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ed1-f51.google.com) smtp.remote-ip=209.85.208.51; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ed1-f51.google.com ([209.85.208.51]:41637) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1pTQct-000GDk-UN; Sat, 18 Feb 2023 17:03:57 +0000 Received: by mail-ed1-f51.google.com with SMTP id i28so3534012eda.8 for ; Sat, 18 Feb 2023 09:03:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=OcK8U9dwzn7cRdCwPw19ZmRQT4pLvhEkLjkm8u5au2U=; b=B+ybn5qfALV7pg8sHiQxivo4j0F9XDOhqY942i+liZckZURV4eTSpdMvKbXR03PK1Y Ye5BInA5qLRnvBIy3Eh4eCerS3Xnd2h2AG5eBlmUokqcHiJpUWj5PniVYp2/n0YAF+KJ bRdb3X2fiaadTdMWk78rb89vdUudwY3pZzvjQ6EoayGAAD2TVFVDmDJG3/OaTcKLEwkV am5TJN8ymkZPuK8GgtwpnRSyZa5CgjhS1U8sWMkhwxZ5eRNooeYoSKGQgzCO19boYZto gIv4xuTXudHAZ9zmXA9gCa9PXOU4m9XhreMioyt6SSXQ62lX2XYzpHp3UyYpY/AcsYIw hKiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=OcK8U9dwzn7cRdCwPw19ZmRQT4pLvhEkLjkm8u5au2U=; b=fniiVQ5SVB7j0KmFT2JH7TrotGI7ncVIiQXBEk2ip8Y3duqEFKIDar/6q3/iA6/o2Q 22DXjHB/dH0yNIjpxxqcj+CYbNYkvouPIiPZmyaliZe935KIfW3EBUddSVBFcSowcNsK JNJzc/sPTMT3GjJ4dCQrnCBwmFg9np0hfn8+hUEFzhc4O5WBLtxRMpHHiZY391Yj169u rEjVvFDGdXfD1gJdyfonEmNdf8EL0aRD8HBKloHFL2Mjn1lmN43Mcrh6l66CSmTT+GNd g9dpuAZmWipcdNIQjMB5hl/f+PFc32xpGjzai+Qk21r4q6Kfny4GAKFQKe/wksv/54l0 liFw== X-Gm-Message-State: AO0yUKUxyegrtcyOMRVtsR/6FUnPhFT9tH85+s4dQ9VNm0DMWp0aD/62 rBsspMnxKOS8Pap9ZOIAlPtBwo7P7SWyhsp7VUCo0bgyW6e0RA== X-Google-Smtp-Source: AK7set8tByh/My4ZfWde8nFZpqQdLwrbiiZogzY0jtyFrgStsIjY3bWrbwxq7/R37x/gx6VGq4smRMatPFwMail2Pi4= X-Received: by 2002:a17:906:7b88:b0:8b1:81fa:b07a with SMTP id s8-20020a1709067b8800b008b181fab07amr2713275ejo.12.1676739835455; Sat, 18 Feb 2023 09:03:55 -0800 (PST) MIME-Version: 1.0 From: Bart Schaefer Date: Sat, 18 Feb 2023 09:03:44 -0800 Message-ID: Subject: [PATCH] Bad autoloaded parameter in module crashes shell To: Zsh hackers list Content-Type: multipart/mixed; boundary="000000000000460d2205f4fc6a84" X-Seq: 51460 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: --000000000000460d2205f4fc6a84 Content-Type: text/plain; charset="UTF-8" When setsparam() fails during add_autoparam(), the shell crashes. Patch attached. I'm not entirely sure -1 is the correct value to return on this error. --000000000000460d2205f4fc6a84 Content-Type: text/plain; charset="US-ASCII"; name="bad-autoload.txt" Content-Disposition: attachment; filename="bad-autoload.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lea7ldvt0 ZGlmZiAtLWdpdCBhL1NyYy9tb2R1bGUuYyBiL1NyYy9tb2R1bGUuYwppbmRleCA2Y2Y0NDIyNzAu LmE2MDA1ZjMwYiAxMDA2NDQKLS0tIGEvU3JjL21vZHVsZS5jCisrKyBiL1NyYy9tb2R1bGUuYwpA QCAtMTE5OCw2ICsxMTk4LDcgQEAgYWRkX2F1dG9wYXJhbShjb25zdCBjaGFyICptb2R1bGUsIGNv bnN0IGNoYXIgKnBuYW0sIGludCBmbGFncykKIHsKICAgICBQYXJhbSBwbTsKICAgICBpbnQgcmV0 OworICAgIGludCBuZSA9IG5vZXJyczsKIAogICAgIHF1ZXVlX3NpZ25hbHMoKTsKICAgICBpZiAo KHJldCA9IGNoZWNrYWRkcGFyYW0ocG5hbSwgKGZsYWdzICYgRkVBVF9JR05PUkUpKSkpIHsKQEAg LTEyMTIsMTQgKzEyMTMsMTggQEAgYWRkX2F1dG9wYXJhbShjb25zdCBjaGFyICptb2R1bGUsIGNv bnN0IGNoYXIgKnBuYW0sIGludCBmbGFncykKIAlyZXR1cm4gcmV0ID09IDIgPyAwIDogLTE7CiAg ICAgfQogCi0gICAgcG0gPSBzZXRzcGFyYW0oZHVwc3RyaW5nKHBuYW0pLCB6dHJkdXAobW9kdWxl KSk7Ci0KLSAgICBwbS0+bm9kZS5mbGFncyB8PSBQTV9BVVRPTE9BRDsKLSAgICBpZiAoZmxhZ3Mg JiBGRUFUX0FVVE9BTEwpCi0JcG0tPm5vZGUuZmxhZ3MgfD0gUE1fQVVUT0FMTDsKKyAgICBub2Vy cnMgPSAyOworICAgIGlmICgocG0gPSBzZXRzcGFyYW0oZHVwc3RyaW5nKHBuYW0pLCB6dHJkdXAo bW9kdWxlKSkpKSB7CisJcG0tPm5vZGUuZmxhZ3MgfD0gUE1fQVVUT0xPQUQ7CisJaWYgKGZsYWdz ICYgRkVBVF9BVVRPQUxMKQorCSAgICBwbS0+bm9kZS5mbGFncyB8PSBQTV9BVVRPQUxMOworCXJl dCA9IDA7CisgICAgfSBlbHNlCisJcmV0ID0gLTE7CisgICAgbm9lcnJzID0gbmU7CiAgICAgdW5x dWV1ZV9zaWduYWxzKCk7CiAKLSAgICByZXR1cm4gMDsKKyAgICByZXR1cm4gcmV0OwogfQogCiAv KiBSZW1vdmUgYSBwYXJhbWV0ZXIgYWRkZWQgd2l0aCBhZGRfYXV0b3BhcmFtKCkgKi8K --000000000000460d2205f4fc6a84--