zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: dana <dana@dana.is>
Cc: Zsh Workers List <zsh-workers@zsh.org>
Subject: Re: [PATCH] _multi_parts doesn't always pass -f to compadd
Date: Sat, 21 Dec 2019 21:31:50 -0800	[thread overview]
Message-ID: <CAH+w=7bRqY0z7fgY1-8_vcUZNqnbUdr8q6ptJ1xGmr_NzA7aZQ@mail.gmail.com> (raw)
In-Reply-To: <EAB5158F-19DC-44E8-9852-17F13549112F@dana.is>

On Sat, Dec 21, 2019 at 8:47 PM dana <dana@dana.is> wrote:
>
> I noticed this the other day and forgot about it until now. In some cases
> (seemingly the most common ones?), _multi_parts doesn't pass -f to compadd,
> which prevents colours/symbols from being applied to files. Just adding -f to
> the list of options that are passed unconditionally seems to fix it?

_multi_parts is intended to be usable in cases that are not files,
such as (IIRC) tar listings, perl module names, etc.

I don't know if passing -f to compadd when adding something that is
not a file has any bad effects.

  reply	other threads:[~2019-12-22  5:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-22  4:46 dana
2019-12-22  5:31 ` Bart Schaefer [this message]
2019-12-22  5:36   ` dana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7bRqY0z7fgY1-8_vcUZNqnbUdr8q6ptJ1xGmr_NzA7aZQ@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=dana@dana.is \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).