From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id cd12e9de for ; Sun, 22 Dec 2019 05:32:44 +0000 (UTC) Received: (qmail 2893 invoked by alias); 22 Dec 2019 05:32:38 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45132 Received: (qmail 858 invoked by uid 1010); 22 Dec 2019 05:32:38 -0000 X-Qmail-Scanner-Diagnostics: from mail-lf1-f66.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.1/25663. spamassassin: 3.4.2. Clear:RC:0(209.85.167.66):SA:0(-1.9/5.0):. Processed in 1.573 secs); 22 Dec 2019 05:32:38 -0000 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.167.66 as permitted sender) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SgwoDubJ1FkdzCdByp8O/bkqdgkAkvxAGkzJCRkG+gY=; b=ZCE4oofW+lNo/1cYaFbFfc71PB28Fr/xJqkYJBjy6vylPcGKXaoTuEAs0PgRVPkUkA /iT3HZ6zi2Gj5uvDWkSYYxm4qqqQGhx+t3DB8xXXJEDW71n1Ic5IYnneqmU1PyXwQMIu QkX+7gBdC00i1ow+aiaZsVJNnxvI4u9vfZ+YJXponhxO9l52kAHMoVk6y0mseCMxxUYz dGFqDvxnTkmfcyZpAaradDwoFmD202dQkjjy9+kOcGY0Y7KicoOhGJDpJhF1zxavc8ZE 09x9o5UGzBFsI5dyUUVKZD/bKUgXqIyCASGzrmm15cUt1IQIBLTIiuRFRjDZVvPkITsa R7lg== X-Gm-Message-State: APjAAAXxJ9wbc5BtsgCyOq5Z8jo2x9e6QJUdm3kCtPdfmgCoDabF+t/a T2EzZ/eSyuhTmws7wSlI9D4iG0NIYiMnNeiTOHqWxn/B X-Google-Smtp-Source: APXvYqzr8sZl8CN80DgnBfyyBckCC7R5GGeZ8YZuuZ9ct8UOBH9q0/CJoaphbgbsYn4rlZEgMryMACVxvasfF+RdT4c= X-Received: by 2002:a19:ae18:: with SMTP id f24mr13838246lfc.155.1576992721576; Sat, 21 Dec 2019 21:32:01 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Bart Schaefer Date: Sat, 21 Dec 2019 21:31:50 -0800 Message-ID: Subject: Re: [PATCH] _multi_parts doesn't always pass -f to compadd To: dana Cc: Zsh Workers List Content-Type: text/plain; charset="UTF-8" On Sat, Dec 21, 2019 at 8:47 PM dana wrote: > > I noticed this the other day and forgot about it until now. In some cases > (seemingly the most common ones?), _multi_parts doesn't pass -f to compadd, > which prevents colours/symbols from being applied to files. Just adding -f to > the list of options that are passed unconditionally seems to fix it? _multi_parts is intended to be usable in cases that are not files, such as (IIRC) tar listings, perl module names, etc. I don't know if passing -f to compadd when adding something that is not a file has any bad effects.