From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22195 invoked by alias); 14 Apr 2018 19:34:47 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42650 Received: (qmail 15943 invoked by uid 1010); 14 Apr 2018 19:34:47 -0000 X-Qmail-Scanner-Diagnostics: from mail-lf0-f41.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.215.41):SA:0(-1.9/5.0):. Processed in 14.183274 secs); 14 Apr 2018 19:34:47 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,HTML_MESSAGE, SPF_PASS,T_DKIMWL_WL_MED,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=tni27UzRl6LAm/x0nkZGdagyM309jy8XPR3rGQBFm2s=; b=cmjY7MAvM1IzBw6mFNPVNxtwADpYXxKWYC8iShFM7++rWexqUA9Uq6B1agYQO74c8q 4q2mn16NmIMxxLS5AzC0D0imR2So9ULHbf2nTK53Bc71zKMKiBOGEnI9S9hW9RIZ8JTA CjLkKiQm2Y3Q40WYLcqnq+fh5bPqSxQ4UhVmTxrwR8FYbpMcvQCy9wCtmy+Hv4VzGnNb IZhkTj1wmM5e9Fk7BTgmyW6DwAdEYLjPRwuZo3k3HbCXAAB1JDNHPdG5Uo6IOzoOGRdH gbe1DuuppdL60LeUXDmtkALm3x3OknQyMNzhAPbBGNdA0EqozYSwMOCTA1xCTBvEccFL JMrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=tni27UzRl6LAm/x0nkZGdagyM309jy8XPR3rGQBFm2s=; b=Cq1sIWuhS+cAjkfyf6JSO4soJSmc1jyjvco+npGEOwHGYyqcnackgfeZnTul5/XdFI 2BfxBpivziMFkHBY0bu/UbCSx39MzQfHlitkwDw1x7ilMEIqe0QSMG+uKSy4lvB3f0I7 lhJeOwWRj4JaE66g8B7Jl/o8u1xWqSEpCKlfwN84+PdSVrsfxfqAMaXwKw7EpwJ9pEfy enIeC7cUUKfNTBWTJC383xdYaZV6px+y7YCwygil0+9CPQPN5fFxEk5zOkc1JWm5C2SH 19hfH8npRfjz9W3FSd9Y1j73e7dPEaEFttjVZFVwLrC5mvcL7YTdbsFi+7m9IZt/gKty m0wQ== X-Gm-Message-State: ALQs6tD1L56BOHce3YPeTlfqeOA8KL2rjTRJkFNCBan40YScHKxuz9eT Nv946xLCdtLnqtqvvBtPo6ipTMBkJFQv9fcrsjYvBQ== X-Google-Smtp-Source: AIpwx4/BxF9fOJOEVLrvShBL9ahfUUzoUr0hHvvqjp5fzfqOqKJ6vfWZNc7gEMgT3QyeMedGNCx7/quwD4omZShuVpw= X-Received: by 2002:a19:8d0d:: with SMTP id p13-v6mr11587503lfd.126.1523734468047; Sat, 14 Apr 2018 12:34:28 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1523671201.1300523.1337561832.23CF134B@webmail.messagingengine.com> <674768.793a8c04885b44ab8262babac1a6cd3574623e36@popretr.messagingengine.com> <1523675973.2014280.1337599104.39812D5F@webmail.messagingengine.com> <674768.2c957faa3a879a4aca32e4da95aaa067ac459a04@popretr.messagingengine.com> <1523684099.3421841.1337658008.1438CC79@webmail.messagingengine.com> From: Bart Schaefer Date: Sat, 14 Apr 2018 12:34:27 -0700 Message-ID: Subject: Re: Bug - invalid pointer To: Julien Nicoulaud Cc: John Ramsden , Mailing-list zsh-workers Content-Type: multipart/alternative; boundary="000000000000b34d3e0569d41376" --000000000000b34d3e0569d41376 Content-Type: text/plain; charset="UTF-8" On Sat, Apr 14, 2018 at 3:20 AM, Julien Nicoulaud < julien.nicoulaud@gmail.com> wrote: > > I bisected it and I think it was introduced by commit 5f6a52c06: > https://github.com/zsh-users/zsh/commit/5f6a52c06 > > Hope this helps! Yes, indeed. From that commit: > diff --git a/Src/utils.c b/Src/utils.c >> index 4c0ebe6..74fdac3 100644 >> --- a/Src/utils.c >> +++ b/Src/utils.c >> @@ -1832,7 +1832,7 @@ adjustlines(int signalled) >> else >> shttyinfo.winsize.ws_row = zterm_lines; >> #endif /* TIOCGWINSZ */ >> - if (zterm_lines <= 0) { >> + if (zterm_lines < 0) { >> DPUTS(signalled, "BUG: Impossible TIOCGWINSZ rows"); >> zterm_lines = tclines > 0 ? tclines : 24; >> } >> @@ -1856,7 +1856,7 @@ adjustcolumns(int signalled) >> else >> shttyinfo.winsize.ws_col = zterm_columns; >> #endif /* TIOCGWINSZ */ >> - if (zterm_columns <= 0) { >> + if (zterm_columns < 0) { >> DPUTS(signalled, "BUG: Impossible TIOCGWINSZ cols"); >> zterm_columns = tccolumns > 0 ? tccolumns : 80; >> } >> > That's obviously doing more (or rather less) than it was meant to, the only intention was to silence the DPUTS(). diff --git a/Src/utils.c b/Src/utils.c index 180693d..b418517 100644 --- a/Src/utils.c +++ b/Src/utils.c @@ -1834,8 +1834,9 @@ adjustlines(int signalled) else shttyinfo.winsize.ws_row = zterm_lines; #endif /* TIOCGWINSZ */ - if (zterm_lines < 0) { - DPUTS(signalled, "BUG: Impossible TIOCGWINSZ rows"); + if (zterm_lines <= 0) { + DPUTS(signalled && zterm_lines < 0, + "BUG: Impossible TIOCGWINSZ rows"); zterm_lines = tclines > 0 ? tclines : 24; } @@ -1858,8 +1859,9 @@ adjustcolumns(int signalled) else shttyinfo.winsize.ws_col = zterm_columns; #endif /* TIOCGWINSZ */ - if (zterm_columns < 0) { - DPUTS(signalled, "BUG: Impossible TIOCGWINSZ cols"); + if (zterm_columns <= 0) { + DPUTS(signalled && zterm_columns < 0, + "BUG: Impossible TIOCGWINSZ cols"); zterm_columns = tccolumns > 0 ? tccolumns : 80; } --000000000000b34d3e0569d41376--