From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 9f362a8b for ; Sun, 19 May 2019 17:05:51 +0000 (UTC) Received: (qmail 20050 invoked by alias); 19 May 2019 17:05:38 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44322 Received: (qmail 6600 invoked by uid 1010); 19 May 2019 17:05:37 -0000 X-Qmail-Scanner-Diagnostics: from mail-lj1-f179.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.2/25454. spamassassin: 3.4.2. Clear:RC:0(209.85.208.179):SA:0(-1.9/5.0):. Processed in 1.844759 secs); 19 May 2019 17:05:37 -0000 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.208.179 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J7jLml0Wu2TNkI3eQYqCiozclqysnBXvghWCK9J/08E=; b=VK43VZoMk/Z1nqwslfBN2tzpHCHJIA3ywTYcNwKbbqtKcRMxV8BR//ZOZwVX8aUdQP 75o8F26o0Vx5wSEMIzUWQftrB7l6KgiTHlvR02UPiFltapDyrqO5yQ1XuMUGEtmNf1Aj uvmXlRcR2HEFKYTF5KvYivWwqONyu2QycjjaXiTpuQVZwQpoiqsJfBVJoOvaSqHTf9bA ed2wmHaPND2fsF+cxBjqpItY8uf7ICY8TUv87VEmPWtOZSzwath8JrorbAqownjPIgyo O4HIU7u7FRMefgXUk/cUSaF7v1N1GxbkJRVs73wcN2Dclvr4Woe37jJiOIoYJn4qsoEK rwiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J7jLml0Wu2TNkI3eQYqCiozclqysnBXvghWCK9J/08E=; b=X+1TS4UA7KpVFmR6Dsr+Fgxi84od7Okl7yOZ0zUTO0HslAcuZ3pUyiXP6WgvTd3GfN UnkrMLnom+l+vIcB3xoM2xQADOlxraqBRHeJ3TwQMdiR/WkwHQiHrV36+VQ/jW6zY9wR cNk9exAzfLyk3/zzgDsdzZIszqh9XQ61v/xL0VlFk1rpO/Uo35dEEsjpBBqiY9vl5ERS ejKsvu29IPG+XTnLoHUL2Jz8exaZn9tIXDFgq8wvLVMsu25Vi2DJy3mEEChIs0G8BQSY K29TOpGzY4C7AdGOzNWXrx9UzX8uXtttVjdIeBSVPmyVw+OQa1a1s8f9Mxtua65rVF04 74zA== X-Gm-Message-State: APjAAAUacfS5qerKhdIzHj+0/A0WOO6D0qM6T2loBzQ5QtW3+CB+uZFZ pxr3SibqKp5eXipHyEWpZRfKi+xsmLw/P6kIX4knQw== X-Google-Smtp-Source: APXvYqyyd40iPME0mfqIrFZTzFgkuw/w3TE9EeEgEWl42z6c76Y4dLDFaw9PWZgqiEvWoZoAtXNWCzciscO/CqfEr8I= X-Received: by 2002:a2e:8816:: with SMTP id x22mr5156705ljh.169.1558285500049; Sun, 19 May 2019 10:05:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bart Schaefer Date: Sun, 19 May 2019 10:04:48 -0700 Message-ID: Subject: Re: Incorrect cursor position when ZLE_RPROMPT_INDENT=0 (with a fix) To: Roman Perepelitsa Cc: "zsh-workers@zsh.org" Content-Type: text/plain; charset="UTF-8" We constantly go around on this. If we un-break it for one terminal type it breaks for another. It's an acknowledged problem that in some cases you can't set ZLE_RPROMPT_INDENT=0, that's why the variable exists in the first place; if it always worked to set it to zero we'd remove it. All your patch does is remove a test for the value of that variable. A more correct change would be to add to the test condition a check for whether placing a character in the rightmost column (or the rightmost/bottom-most position) causes the terminal to auto-wrap (or not) the cursor onto the next line. Unfortunately there's no way to reliably determine that (e.g., there's no termcap/terminfo value that reports it consistently). What $ZSH_PATCHLEVEL were you testing against? There was a related change committed only a month ago, and there has not been a release in the meantime.