From: Bart Schaefer <schaefer@brasslantern.com>
To: Marlon Richert <marlon.richert@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Rewrite of zsh-newuser-install
Date: Mon, 8 Feb 2021 17:42:12 -0800 [thread overview]
Message-ID: <CAH+w=7bcxXr0jUSWceQL7KKiJAzju8KnMYwgJFWO0-15Hn_DRg@mail.gmail.com> (raw)
In-Reply-To: <CAHLkEDur33X5s7Ar8n-9zQR0GqoZm3u_8rPRF3P-Jf=v90aLUA@mail.gmail.com>
Generally speaking not bad. Thanks for the sample. More detailed commentary:
> HISTFILE=${ZDOTDIR:-$HOME}/.zsh_history # File in which to save history
I've seen/used this as ".zhistory" for decades, but that's not
actually coded anywhere except in the "c2z" example, I guess. I find
the underscore annoying since none of the other startup files have
one, though I understand the objection to doubling the "h".
> setopt HIST_IGNORE_ALL_DUPS # Ensure all history items are unique.
I'd go with just HIST_IGNORE_DUPS rather than ALL, and as for these:
> setopt HIST_REDUCE_BLANKS # Remove insignificant whitespace.
> setopt SHARE_HISTORY # All simultaneous sessions use the same history.
I agree with Lawrence, these are too intrusive. SHARE_HISTORY makes
me crazy unless some sort of directory-local-history is also in use,
especially if the home directory is NFS mounted or the like.
A bunch of stuff about prompts:
Prompt colors are going to be a matter of taste; if you're going to
apply them then you have to pick a color scheme that's visible on
either a light or a dark background, since zsh doesn't control that
terminal state. I have a white background and the yellow text in RPS2
is almost unreadable.
%F{8} and %F{12} do nothing on my terminal (ssh in Terminal.app from
Mac to Ubuntu, in this case), they just emit the same as %F{default},
so I don't know what you're after with those. Don't use numerics.
I don't like the leading blank line in the prompt, either, but it's
not a showstopper. Isn't coloring the prompt sufficient visual
differentiation?
I don't have a strong opinion about the PS4 prompt, but here's mine:
PS4=": %1N:%i%1(_.:%_.); "
This makes the prompt string into a ":" command ending at ";" so most
of the time you can copy-paste the PS4 output directly back to the PS1
input and hit enter to run it. Same trick used in $HISTFILE for
extended history. Putting extra newlines and characters like ">" in
PS4 make that impossible.
RE completion styles:
Again with the %F{8}, just to call it out. Mostly good otherwise,
just some random grumbling:
In the completer style, _history with 12000 lines of context does not
give me warm fuzzies.
In matcher-list, I waver back and forth on using [:punct:] instead of
something more specific like [-_,.] (which is what I've used for
years).
I'm not a fan of the case-insensitive sorting attempt.
> unsetopt AUTO_PARAM_SLASH # Don't add trailing slashes to dir completions.
Why? The comment isn't very clear either, since it's not "dir
completions" it's $foo where the expansion of $foo gives the name of a
directory. It seems weird to do this when later on you have
> setopt AUTO_NAME_DIRS
which I would recommend against (although not strongly).
RE key bindings/line-init:
Wasn't there a sidebar into why terminfo isn't trustworthy? In any
case, application mode is exactly the opposite of how I want my shell
behaving, unless I'm misinterpreting your code.
Don't mess with Ctrl-U.
I'm not sure I like your choices for Enter / Alt-Enter in menuselect,
because it seems to presume that the most common case is to do
menu-selection on the last word being entered for a command ... but my
experience is that I'm more often using menu-selection on the set of
command-line options, which typically have to be followed by
additional arguments.
next prev parent reply other threads:[~2021-02-09 1:42 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-06 20:03 Marlon Richert
[not found] ` <0102017778f35f33-a962e4d3-83e9-4d3b-a0d7-45701bb40b11-000000@eu-west-1.amazonses.com>
2021-02-06 20:19 ` Marlon Richert
2021-02-06 20:33 ` Lawrence Velázquez
2021-02-06 21:54 ` Bart Schaefer
2021-02-07 13:41 ` Marlon Richert
2021-02-07 13:51 ` Roman Perepelitsa
2021-02-07 17:10 ` Marlon Richert
2021-02-07 17:28 ` Marlon Richert
2021-02-07 20:20 ` Bart Schaefer
2021-02-07 21:06 ` dana
2021-02-07 21:15 ` Marlon Richert
2021-02-08 21:57 ` Marlon Richert
2021-02-08 23:33 ` Lawrence Velázquez
2021-02-09 1:42 ` Bart Schaefer [this message]
2021-02-09 2:00 ` Bart Schaefer
2021-02-09 8:18 ` Marlon Richert
2021-02-09 23:09 ` Bart Schaefer
2021-02-09 8:17 ` Marlon Richert
2021-02-09 8:29 ` Roman Perepelitsa
2021-02-09 23:16 ` Bart Schaefer
2021-02-12 0:09 ` Bart Schaefer
2021-02-12 5:58 ` Marlon Richert
2021-02-09 4:51 ` dana
2021-02-09 6:00 ` Bart Schaefer
2021-02-09 7:30 ` dana
2021-02-09 7:34 ` dana
2021-02-09 9:55 ` Marlon Richert
2021-02-09 10:01 ` Roman Perepelitsa
2021-02-09 10:04 ` Marlon Richert
2021-02-09 10:56 ` dana
2021-02-09 11:14 ` Roman Perepelitsa
2021-02-09 11:39 ` Marlon Richert
2021-02-09 17:21 ` dana
2021-02-09 21:01 ` Marlon Richert
2021-02-09 21:41 ` Marlon Richert
2021-02-09 23:15 ` dana
2021-02-10 0:02 ` Bart Schaefer
2021-02-10 7:02 ` Marlon Richert
2021-02-10 6:57 ` Marlon Richert
2021-02-12 0:10 ` Bart Schaefer
2021-02-12 5:59 ` Roman Perepelitsa
2021-02-13 0:23 ` dana
2021-02-10 2:30 ` Bart Schaefer
2021-02-10 7:44 ` Marlon Richert
2021-02-10 20:27 ` Marlon Richert
2021-02-11 8:30 ` Bart Schaefer
2021-02-11 21:11 ` Marlon Richert
2021-02-11 22:57 ` Bart Schaefer
2021-02-12 5:49 ` Marlon Richert
2021-02-12 5:47 ` Marlon Richert
2021-02-12 23:43 ` Oliver Kiddle
2021-02-13 1:11 ` Bart Schaefer
2021-02-12 23:26 ` Oliver Kiddle
2021-02-13 0:15 ` Marlon Richert
2021-02-13 1:33 ` Bart Schaefer
2021-02-13 1:36 ` Oliver Kiddle
2021-02-13 2:53 ` Bart Schaefer
2021-02-13 10:26 ` Marlon Richert
2021-02-13 22:53 ` Marlon Richert
2021-02-14 0:34 ` Bart Schaefer
2021-02-14 8:12 ` Marlon Richert
2021-02-13 22:56 ` Bart Schaefer
2021-02-14 8:01 ` Marlon Richert
2021-02-19 21:38 ` Marlon Richert
2021-02-20 0:30 ` dana
2021-02-20 8:18 ` Marlon Richert
2021-02-20 18:57 ` Bart Schaefer
2021-02-21 19:24 ` Marlon Richert
2021-02-24 22:15 ` dana
2021-02-25 8:05 ` Daniel Shahaf
2021-02-25 16:58 ` dana
2021-02-26 22:31 ` Marlon Richert
2021-02-27 13:21 ` Daniel Shahaf
2021-02-27 13:46 ` Daniel Shahaf
2021-03-19 22:12 ` Marlon Richert
2021-03-24 13:45 ` gi1242+zsh
2021-03-24 14:16 ` Paul
2021-03-24 17:44 ` Bart Schaefer
2021-03-24 20:38 ` Marlon Richert
2021-03-25 3:36 ` Paul
2021-04-05 18:16 ` Daniel Shahaf
2021-04-05 18:52 ` Sorting of <-> (was Re: Rewrite of zsh-newuser-install) Bart Schaefer
2021-04-05 21:31 ` Rewrite of zsh-newuser-install gammafunction
2021-04-07 14:45 ` Marlon
2021-04-09 16:49 ` Marlon
2021-04-09 23:14 ` Daniel Shahaf
2021-04-10 1:17 ` Oliver Kiddle
2021-04-07 18:17 ` Mikael Magnusson
2021-04-07 18:56 ` Daniel Shahaf
2021-03-24 10:00 ` Marlon Richert
2021-03-25 1:15 ` Daniel Shahaf
2021-04-05 14:00 ` Marlon Richert
2021-04-05 18:36 ` Daniel Shahaf
2021-04-05 19:22 ` Daniel Shahaf
2021-02-22 3:54 ` Paul
2021-02-22 8:14 ` Marlon Richert
2021-02-22 16:31 ` Bug in compdescribe with matcher 'b:-=+' Bart Schaefer
2021-06-14 8:28 ` Marlon Richert
2021-08-12 12:03 ` Marlon Richert
2021-08-12 16:15 ` Bart Schaefer
2021-02-19 21:34 ` Rewrite of zsh-newuser-install Marlon Richert
2021-02-13 1:28 ` Bart Schaefer
2021-02-13 1:34 ` Bart Schaefer
2021-04-22 13:57 ` Marlon Richert
2021-02-09 23:05 ` Bart Schaefer
2021-02-09 9:44 ` Marlon Richert
2021-02-09 18:13 ` Greg Klanderman
2021-02-08 9:21 ` Peter Stephenson
2021-02-08 6:35 ` Daniel Shahaf
2021-02-08 8:44 ` Marlon Richert
2021-02-08 8:46 ` Marlon Richert
2021-02-08 10:32 ` Daniel Shahaf
2021-02-08 17:44 ` Marlon Richert
2021-02-08 20:47 ` Bart Schaefer
2021-02-09 21:44 ` Eric Cook
2021-02-09 22:34 ` Bart Schaefer
2021-02-07 20:22 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7bcxXr0jUSWceQL7KKiJAzju8KnMYwgJFWO0-15Hn_DRg@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=marlon.richert@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).