From: Bart Schaefer <schaefer@brasslantern.com>
To: Jun T <takimoto-j@kba.biglobe.ne.jp>
Cc: zsh-workers@zsh.org
Subject: Re: Bug: time doesn't work on builtins
Date: Fri, 6 Sep 2024 12:13:19 -0700 [thread overview]
Message-ID: <CAH+w=7bef-8TgpNJJ3fsb-reMjQb5iN58qRMfq+QmfU0HmWtXw@mail.gmail.com> (raw)
In-Reply-To: <CEAB70F9-A50B-4A2E-90B8-A8017E921EA7@kba.biglobe.ne.jp>
On Fri, Sep 6, 2024 at 2:52 AM Jun T <takimoto-j@kba.biglobe.ne.jp> wrote:
>
> % time eval 'external command'
> % time . ./script # script runs external command
>
> I think it's better to pass &chti always.
OK.
> [2] Time spent in prefork() is not included in the statistics.
I believe that's fixable by always calling shelltime(...,0) when
Z_TIMED but then only calling shelltime(...,1) when is_cursh is
determined later.
Remaining question is whether stats should be printed on error cases,
e.g., "no such builtin":
time builtin nosuch $(long running command)
That means sticking in a few more calls to shelltime() in front of
early return statements.
next prev parent reply other threads:[~2024-09-06 19:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 13:15 Mark J. Reed
2024-08-15 18:52 ` Bart Schaefer
2024-08-15 22:08 ` Mark J. Reed
2024-08-16 19:20 ` Bart Schaefer
2024-09-04 0:27 ` Bart Schaefer
2024-09-04 14:32 ` Jun. T
2024-09-05 17:29 ` Jun. T
2024-09-05 23:37 ` Bart Schaefer
2024-09-06 9:41 ` Jun T
2024-09-06 0:10 ` Bart Schaefer
2024-09-06 9:52 ` Jun T
2024-09-06 19:13 ` Bart Schaefer [this message]
2024-09-14 2:10 ` PATCH: " Bart Schaefer
2024-09-20 7:46 ` Oliver Kiddle
2024-09-22 0:59 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7bef-8TgpNJJ3fsb-reMjQb5iN58qRMfq+QmfU0HmWtXw@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).