From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from zero.zsh.org (zero.zsh.org [IPv6:2a02:898:31:0:48:4558:7a:7368]) by inbox.vuxu.org (Postfix) with ESMTP id 09C1E2E65A for ; Fri, 6 Sep 2024 21:14:10 +0200 (CEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1725650050; b=O0qL55GFueGbFWv6Qr2VbpXDO4xzkslJhqud2COno3/sirKIWqFJ+fvAbftUUXijYiqF7mV93f X0600nC3kbfvMm0NhhRLD0SMqZlBe0b/7UlVshrNogfOJXdNbMOGzKKbbIxcoeuWpJzelQzG33 W3bRGmRHM7UFYmGteYtGbV3+pAETnMw7tKlILwe/hPMk2gSLvtWGAvFQzvCVCO3b3i0MZv7vWg zLE/0gOENzkxZ8Lz8Sp6sC8pEwT4+HMFm/72e6in87XaQ0DMh7CTt7NNYu+Z+En0IS+1q7DlHL HCaXVM5/9ZhFxX2cRS5FnZ/mK4wZab6eqVJE1hsXYv7ZnQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ed1-f46.google.com) smtp.remote-ip=209.85.208.46; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1725650050; bh=Us/e2HC5aqwKbsvHW6AuqejtNgLRxMa74ru31H/9sqg=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature: DKIM-Signature; b=S8q3+lBe0GN8pb2mjmGhcoxdicLtEzOffnkVf15YIrs36264gZO12MuQJIU+mS7bxdrlu6al4B 2//yn7pm3I0xplO0CG4fmu3e9e13xU6hr5Lw1P2Dq8HS6F89zUmeyH2DvEXMTZciGj+5Zp+NeZ 7MrlnzwTul2QwpRu8GF+HJB1rcGHQUiidfnwlnOYiWUd3YXfYBHx3Sa/M2C3h4K+v5Ledd51Qi e+H6aV7w6H/uhVJg43kSVmOcK4XhoTS0ysxzXp2NDMChdOnZbNLzSjLWnV5teoAa/g7sH0R5SI VYLSBfFDnZlHVNF2xHtekrU52XOkPcgimo93RjG6Arh68A==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=Lrnfc5cXIGasT1gIhZl+JvBpDv8JGjOy3QuNpDDtCsE=; b=d4qJhENqz0w+demUEbtb6NBIa2 0kfza+XqzzsSh0/hkQTWJmGtMARdYP9NJkuW+v4hkO6bvqRuoscG3e/WyeevWrMOYouNLJUEMnGUi gtEE5KLPTHQf3smijYcdJXBUQ4MKBAkEPipcy24EGttE5z3gqgmm2sK+3A7Kfrt64IyKIt9xPT5CF 7qgQcI4ODVtHVdxbhKKWePeNFQ+XTj0641iksSAQqTRxNIVLs/D74SCybTv50pZNRRYAxAtYsBVNl 9hSDRtAEmFEjHcfggxAsvPjAW2zKKnFq4pToxgTURENJL1RD8q2B8a9yJAJgDY/JZ+St7l91wtD0j 1m6nLAQQ==; Received: by zero.zsh.org with local id 1smePI-0001rP-TU; Fri, 06 Sep 2024 19:14:08 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ed1-f46.google.com) smtp.remote-ip=209.85.208.46; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ed1-f46.google.com ([209.85.208.46]:38506) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1smeOh-0001WT-Rr; Fri, 06 Sep 2024 19:13:32 +0000 Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5c24b1ed83eso324848a12.2 for ; Fri, 06 Sep 2024 12:13:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20230601.gappssmtp.com; s=20230601; t=1725650011; x=1726254811; darn=zsh.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Lrnfc5cXIGasT1gIhZl+JvBpDv8JGjOy3QuNpDDtCsE=; b=pye9fjQtDLmhVbmyJ1cusnHEJ8RCDHBwE2lwvxnYIpqO5YO4KsLb3N+3jBT1lWGEUO NAcoql9OFEUZqXL4xx68ff1RjdcYId8uovqD7SEVUWqUB27I8xm1dRWlj7jCfH2t57pO nlipectj0lz8u/Z3trPudlcodTFIbUyEbCKNT8BRyOYygupj8INlqZOVEuBhf9/cjWhF 5dKrk1c8+03sCFQyx0PzpZ2UPh+We18snUCMD7YbUoUnHc+eTPjbqgqDruNUsA2Gelra g75Gy4jbKvbP09ixl3Oq9hmTNvuWCjTPxZLn2/8tAEw7hNszqtpSIzZ4HuDalh489h23 D7ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725650011; x=1726254811; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Lrnfc5cXIGasT1gIhZl+JvBpDv8JGjOy3QuNpDDtCsE=; b=JEwljD+ZwA0l2bn9f/R88avPCcdUHoHwhx5vxIdA0pUCI9fbmnj4fr3Kv+dS9aZSb3 gJz/g/cI0la5K8h38L3qcvbhqQLHlTrq/4bWcCXAJuBCniRbbFl04UFSkmaIOJjNwc5R QYOHfTBz61CzYi4xKWGlnmRdyplUSHdFEH+cpsuofhQF6tCLLMQHmFKnL/WEBuyoUXNH enrSYb43E4N539ElrXx+QKcnpSTa6/+mkhZblbWBPYp7aeCj9RHt42jscRS59gqCn8cs Owak4ddsnDBcgRYVdTbj0Tbk+l2n14cplXpTjr9OWzU5nCDgsME8xZlq58We1OAdQMqE V2Xw== X-Gm-Message-State: AOJu0YzbQzwdWM2hFUCwmA5q4zhCAl80B5DKelpqmAZpa8qnyOGs68L9 YI0ANGTeMG+vmHBxNa3h5VRIQdTpJ/4YL7HNUzw3XcmC7FbODW4cR/GppAWMcs8oRsaINMcuG7y Y4uyP/rv/HIdR52Nj4No1gr2TEf14h8Y/sKNfHyOsdW6/PRc= X-Google-Smtp-Source: AGHT+IHVTkTaKOvvUtiNw402zvD9TDUHQWo/wLOeynrA+42HphMC/a5Xx0lWwg/ffdzngZRHhrBaipHERK1JTtqj4jw= X-Received: by 2002:a17:907:1c24:b0:a8a:93ce:d252 with SMTP id a640c23a62f3a-a8a93ced5d2mr120646766b.6.1725650010945; Fri, 06 Sep 2024 12:13:30 -0700 (PDT) MIME-Version: 1.0 References: <20C9A9EE-49A5-4A58-AA00-136A5D221331@kba.biglobe.ne.jp> In-Reply-To: From: Bart Schaefer Date: Fri, 6 Sep 2024 12:13:19 -0700 Message-ID: Subject: Re: Bug: time doesn't work on builtins To: Jun T Cc: zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 53071 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On Fri, Sep 6, 2024 at 2:52=E2=80=AFAM Jun T = wrote: > > % time eval 'external command' > % time . ./script # script runs external command > > I think it's better to pass &chti always. OK. > [2] Time spent in prefork() is not included in the statistics. I believe that's fixable by always calling shelltime(...,0) when Z_TIMED but then only calling shelltime(...,1) when is_cursh is determined later. Remaining question is whether stats should be printed on error cases, e.g., "no such builtin": time builtin nosuch $(long running command) That means sticking in a few more calls to shelltime() in front of early return statements.