zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Oliver Kiddle <opk@zsh.org>
Cc: Zsh workers <zsh-workers@zsh.org>
Subject: Re: github PR to "Add command to improve robustness"
Date: Wed, 20 Sep 2023 10:29:51 -0700	[thread overview]
Message-ID: <CAH+w=7bgsjTVAueaCV5JU1RehbDY7t5g86EEAu5r80xZ5a8sCQ@mail.gmail.com> (raw)
In-Reply-To: <9993-1695230403.478634@56vb.M_iZ.HRRz>

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

On Wed, Sep 20, 2023, 10:20 AM Oliver Kiddle <opk@zsh.org> wrote:

>
> I would guess that the cause of the "bug" is function wrappers being
> defined which wrap ifconfig and ip to apply colouring to their output.
>
> Any ideas?
>

If _call_program runs in a subshell, it could start with

unfunction -m '*'

That might be a bit violent, though.  Maybe a zstyle listing functions to
ignore?

Or should we just tell them to test something like [[ -t 1 ]] if they
> insist on writing wrappers for system utilities that add colour.
>

That would certainly be best practice.

>

[-- Attachment #2: Type: text/html, Size: 1413 bytes --]

      reply	other threads:[~2023-09-20 17:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-20 17:20 Oliver Kiddle
2023-09-20 17:29 ` Bart Schaefer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7bgsjTVAueaCV5JU1RehbDY7t5g86EEAu5r80xZ5a8sCQ@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=opk@zsh.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).