help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: "Jun. T" <takimoto-j@kba.biglobe.ne.jp>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] out of memory error after "edit-command-line"
Date: Tue, 18 Oct 2022 13:08:45 -0700	[thread overview]
Message-ID: <CAH+w=7bkQehhH=ybrtCCigJKenxSzNGvnN9Hm1=Hm_WebUjrTg@mail.gmail.com> (raw)
In-Reply-To: <CC437935-AE7B-457B-9761-B3DD2695DD7F@kba.biglobe.ne.jp>

On Tue, Oct 18, 2022 at 8:08 AM Jun. T <takimoto-j@kba.biglobe.ne.jp> wrote:
>   dosetopt() has the extra code only when setting MONITOR to ON.
> so again just opts[MONITOR]=on is enough in doshfunc().... Is this correct?

Hm, the shell having acquired the process group when MONITOR turned ON
... I don't know of any way to relinquish it again.  So either this
has to change in dosetopt() as well if it's even possible, or
doshfunc() is OK.

> The patch below forces 'bindkey -e/-v' to set the option EMACS or VI.
> Is this OK?

The only possible reason I can think of why this would not be OK is
that it will change the output of "setopt" when its "form is chosen so
as to minimize the differences from the default options for the
current emulation".  That seems a pretty insignificant issue, but
might warrant mention in NEWS or even in the incompatibilities section

> I _hope_ there is no other option that require extra code in doshfunc().

The only ones I was worried about seem to be in the set of those that
can't be changed after startup, or that can't change back again

  reply	other threads:[~2022-10-18 20:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-02  3:47 Jim
2022-08-12 15:33 ` Jim
2022-08-12 20:18   ` Bart Schaefer
2022-08-13  0:10     ` [PATCH] " Bart Schaefer
2022-10-18 15:07       ` [PATCH] " Jun. T
2022-10-18 20:08         ` Bart Schaefer [this message]
2022-10-19  9:12         ` Jun T
2022-10-27  5:34           ` Jun T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7bkQehhH=ybrtCCigJKenxSzNGvnN9Hm1=Hm_WebUjrTg@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=takimoto-j@kba.biglobe.ne.jp \
    --cc=zsh-workers@zsh.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).