From: Bart Schaefer <schaefer@brasslantern.com>
To: "Lawrence Velázquez" <larryv@zsh.org>
Cc: Zsh hackers list <zsh-workers@zsh.org>,
Marlon Richert <marlon.richert@gmail.com>
Subject: Re: [PATCH] Let run-help try to show function source from file (was Re: [RFC][PATCH] Try calling command with help flags in run-help)
Date: Tue, 27 Jul 2021 19:03:12 -0700 [thread overview]
Message-ID: <CAH+w=7brBuH0VFY1BjRbPfHsZA5Q-xwkdvUSvLVnoO7OSePhrw@mail.gmail.com> (raw)
In-Reply-To: <d15475b9-d588-46c2-aec0-ccab9efc370d@www.fastmail.com>
On Sun, Jun 20, 2021 at 2:24 PM Lawrence Velázquez <larryv@zsh.org> wrote:
>
> On Wed, Jun 2, 2021, at 2:26 PM, Marlon Richert wrote:
> > Here's part of workers 48926 as a separate patch.
> >
> > Attachments:
> > * 0001-Let-run-help-try-to-show-function-source-from-file.txt
>
> ping, needs review
Finally looked a little more closely at this.
I don't think we can allow it to unconditionally run
autoload +X -Uz $func
because for example it's always possible that $func should be
autoloaded with -k instead. Further, even if we grab the correct
autoload flags, it's possible that loading the function will have some
side-effects, or that loading it with +X will omit some necessary
side-effects.
Also, if the function was loaded from a zcompile file, displaying
$functions_source[$func] with the pager will either fail or be a mess.
There's also the minor point that if the function came from a file
containing multiple other functions, you get way more than you asked
for.
next prev parent reply other threads:[~2021-07-28 2:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 20:47 [RFC][PATCH] Try calling command with help flags in run-help Marlon Richert
2021-05-25 20:57 ` Bart Schaefer
2021-06-02 18:26 ` [PATCH] Let run-help try to show function source from file (was Re: [RFC][PATCH] Try calling command with help flags in run-help) Marlon Richert
2021-06-20 21:23 ` Lawrence Velázquez
2021-07-18 18:38 ` Lawrence Velázquez
2021-07-28 2:03 ` Bart Schaefer [this message]
2021-06-02 20:58 ` Let run-help filter cmd_args before calling run-help-<command> " Marlon Richert
2021-06-03 4:34 ` Bart Schaefer
2021-06-03 4:38 ` Bart Schaefer
2021-06-03 21:26 ` Marlon Richert
2021-06-03 21:45 ` Lawrence Velázquez
2021-06-03 21:52 ` Bart Schaefer
2021-06-03 22:00 ` Lawrence Velázquez
2021-06-03 23:33 ` Bart Schaefer
2021-06-05 19:15 ` Marlon Richert
2021-06-20 18:01 ` Lawrence Velázquez
2021-07-18 18:45 ` Lawrence Velázquez
2021-07-28 17:58 ` Bart Schaefer
2021-07-29 12:11 ` Marlon Richert
2021-07-30 16:55 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7brBuH0VFY1BjRbPfHsZA5Q-xwkdvUSvLVnoO7OSePhrw@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=larryv@zsh.org \
--cc=marlon.richert@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).