From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 22457 invoked from network); 2 Dec 2023 23:31:30 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 2 Dec 2023 23:31:30 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1701559890; b=FlY5c5QO6Yio6BPwwPCnKctLlYcagUzvrlXvbH2784Qtts2rjCCYIs9KiwiPpY9Ov1aM5xkTnh zTWN39nDyrA5PU/yifoqUcV4C6Ll6YSGZSmattQRMZXjGT/m3Ejwxi+Wh2nN6pu2r+eqyOdnAO M6P+XmqKnuWtdCo6m+7DHQOfkBH/JU/X9J/KDDqzuZJ8XEPjBTWm4sqmxdf9DG+mdtfZo5jR8u MZaJXIQTKiAqUJJgwOTDWxhmjWC6+IZxM8CkTdzjinNLUAhX28SSAOCaWvKLQ8RhF5YDVZICky /GaFA+f005IidHd0+nQjlygfEBloAn7z51k4OsXXhAdoqg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f46.google.com) smtp.remote-ip=209.85.218.46; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1701559890; bh=YRx3qa9/RFlHFOS81drJbSf3mVG2Bb98+092bWwv+Yc=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature: DKIM-Signature; b=UX2WwxWbm6cOCc/UzBUWnlkais+a7t9Nj4Mh9qQIk0tBjeJxDUTHoUQXYOPxOL7I1yG2jy/Z+G w2RXXSsSzllj0vdwSyNZSNkqzUgMESCbeM5VSI9Fu2lE+gfMAmMGG1K4GLGGbGJAETo+5YmPxT ZknV+EohMsAxVYuTHGhQkAtUE6+u/OYRxA/xcC1FDghCI9cjPOucQ0BsAxl8wnFmrwCQQemf/J fwi7/x7c3E5tFmucTxq/7P/+j52h+mRfu32jXniMHoRTy5SBqS6cCuQf5ggBjPxGv2R7VsE2mF mqoOo7HY5+p2eMvZ52CeeT/Bv9UfVp7/EX/IgiIbCWuX3A==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=YRx3qa9/RFlHFOS81drJbSf3mVG2Bb98+092bWwv+Yc=; b=JXyc6QgObYeiuWCV+izvMvJQvK pDq+2iiuPtAy2qX72dgfASATGZa5FEeEMTzXM2TA055J7PsFfdc5gdIh1eKgDf/x2FSzx+bMd0Oft K+799PluQIjV+aOha2+JWben3beF1pLe7O6Vm6bcgP4WexVLCsOsZjS5guz96ZQMZVElj4lPaj6ds SoP/lREsuMD0gm3ogMq26P2NjTvWczXB7NzMhLJXgY/rhtoQ/Yl/pOXQaHlJJ+xF31jm3OEj3XBhJ W9viGW9MV72gl5VmiDZ2zIqR7qpWM6iD6DqJjpD/+KoTFp5jl/3Gp8dZpGInuVEwOCSCMFpsdDPRM cbIsjMWA==; Received: by zero.zsh.org with local id 1r9ZSM-000AGN-33; Sat, 02 Dec 2023 23:31:30 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f46.google.com) smtp.remote-ip=209.85.218.46; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ej1-f46.google.com ([209.85.218.46]:42020) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1r9ZS6-0009x3-Kc; Sat, 02 Dec 2023 23:31:15 +0000 Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a18b0f69b33so573607366b.0 for ; Sat, 02 Dec 2023 15:31:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20230601.gappssmtp.com; s=20230601; t=1701559874; x=1702164674; darn=zsh.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YRx3qa9/RFlHFOS81drJbSf3mVG2Bb98+092bWwv+Yc=; b=arr7cHjkJM3B3Afexfd8c0EeailcFoUUMto9+S6mkJRziIMBpSfqg1MvuRwqQ8SbFg 9SReBAXEw4ijjTpf3PTSFNihPdQSvLjkDg+koVaj92rW4IrIrR8S6XF82tIkkmvahD7p GRho/VjmRYLI6oNKfzL08/mOv3XLXYGtQ8GHX+znTHsuCS8VJ+FEaFLEb7hE0aNgEYfb CfsKBpNnPRldF3FkdzdDuE4zkh2eseV2/OylJsfN20MtBdwYyLvxCXAwcDoSWNTzRn+1 t4ioLbwyADDROPQKU/dXutszOm917sc0TNy0atoLqHOUlC1w4UEFk9+uvurzzfOmh0Zr gkkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701559874; x=1702164674; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YRx3qa9/RFlHFOS81drJbSf3mVG2Bb98+092bWwv+Yc=; b=xJKPqqrnxFSNupRZaZ/cQdtVTGRdELo3GfydvxCIW6K4SMzTe43YNpKa/evkjdEVTJ e4tjw3Kdcy+rNsDq31jr14ZaJpWmyesJule8fmtK0ioP7qpgrUG3JXQYPdBMn9rB73q7 5mxpHb2HWRhC66XeIbbWh+S6hKtSAejMxuKFF+x10XQoiDawkXogREatzPXWXG7r5nfS mGYXa8hZqfjREYYP2AQLidVP5xxv34sxniccDq/JM4B5Ss83OfawsEE9o83nwlH1IewP 9ofN5/K5a8+lzCK7VFvxa0S0bqE4XsbL9HwVbPCm+JbI55w93maJT/lbBT9BwmOyMWmc Uamg== X-Gm-Message-State: AOJu0Yz7kwXi8Vs2fblPSuAOtRjKEJeaxyf03XxNBw4aZFYTOVZY0Ggz m7CTxBdk03d1AyFQ6tvxKozE9Vyogy36n95OZHlgVA== X-Google-Smtp-Source: AGHT+IHfMgLG2io/O4EchOIjSgypGkxemQXMyJn4XKFpG1kFRQANUgrH3wFa0x3RB9iLnDqt2DsMwScv35HyUab6uFI= X-Received: by 2002:a17:906:e28b:b0:a19:f7d:853 with SMTP id gg11-20020a170906e28b00b00a190f7d0853mr3134446ejb.20.1701559874148; Sat, 02 Dec 2023 15:31:14 -0800 (PST) MIME-Version: 1.0 References: <207461559.9336309.1701221332233.ref@mail.yahoo.com> <207461559.9336309.1701221332233@mail.yahoo.com> In-Reply-To: From: Bart Schaefer Date: Sat, 2 Dec 2023 15:31:03 -0800 Message-ID: Subject: Re: PATCH: Improve quote handling in _ant completion To: Mikael Magnusson Cc: German Riano , "zsh-workers@zsh.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 52362 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On Wed, Nov 29, 2023 at 11:56=E2=80=AFAM Mikael Magnusson wrote: > > >> Also I am proposing to shield 'find_targets' with '(( > >> $#functions[find_targets] )) ||' so that users can easily override the > >> function. > > > > No particular objection to this, though I wonder if it should be tied > > to the "targets" style and _call_program (Oliver?) > > It should probably also be renamed to _ant_find_targets or something > similar, it's very unexpected that a completer pollutes the main > function namespace. I've lost track of whether Oliver originally wrote this completer or merely committed it, but I'm going to leave this bit unchanged for him to weigh in.