zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Mikael Magnusson <mikachu@gmail.com>
Cc: Marlon Richert <marlon.richert@gmail.com>,
	Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Rewrite of zsh-newuser-install (Mikael's subthread)
Date: Mon, 5 Apr 2021 14:44:55 -0700	[thread overview]
Message-ID: <CAH+w=7buB+hUY6ufROgGTRc4SPzqjRuO6e4vq2gU4q_UzJH=eg@mail.gmail.com> (raw)
In-Reply-To: <CAHYJk3Sh8ErYyObh=nURosOnj4+bsB1WsxhOi_-e=n_1fjAQ6Q@mail.gmail.com>

On Mon, Apr 5, 2021 at 12:44 PM Mikael Magnusson <mikachu@gmail.com> wrote:
>
> > # Prompt settings
>
> This is 70 lines that should be a prompt theme, not pasted verbatim in .zshrc.

There was some side discussion about prompt themes being unmaintained
and therefore unsuitable for this.  My take is that we should find a
way to put some effort into maintaining it.  We did just have a few
patches for it, so I personally would be fine with this going into a
theme.

> > typeset -A key  # Declare `$key` table, without overriding any existing values.
>
> How could $key possibly already exist as an associative array at this
> point?

Also, won't this by default print everything that's already in $key if
by some magic (/etc/zsh* or ~/.zshenv ?) it does already exist?

> > WORDCHARS=''  # Characters treated as part of words (in addition to letters & numbers)
>
> Why are we setting WORDCHARS to the empty string here?

There was a side discussion about this, too.  The default WORDCHARS
acts like the stty driver, emptying it works more like emacs.

> > bindkey -M menuselect "$key[PageUp]"   backward-word          # Page Up
> > bindkey -M menuselect "$key[PageDown]" forward-word           # Page Down
>
> I think most people expect these keys to scroll history backward/forwards.

I don't recall what difference being in the menuselect keymap makes here.

> > bindkey -s '^[-' "^Qpushd -1$key[Return]"   # Alt-Minus:  Back to previous dir stack entry.
> > bindkey -s '^[=' "^Qpushd +0$key[Return]"   # Alt-Equals: Forward to next dir stack entry.
>
> Might go as far as say NAK on these bindkey -s abominations.

Yeurgh.  Agree, avoid bindkey -s.

> > # Make each entry in these Unique (that is, remove duplicates).
> > # See http://zsh.sourceforge.net/Doc/Release/Shell-Builtin-Commands.html#index-typeset
> > typeset -gU PATH path FPATH fpath CDPATH cdpath MANPATH manpath
>
> specifying the scalar halves of these tied variables is superfluous.

Again, previously discussed ... the man page recommends specifying
both halves because of the -U option.

> Overall I think there's a bit too much stuff in here. It's longer than
> some (many) actual personal .zshrc files I've seen.

I tend to agree.


  parent reply	other threads:[~2021-04-05 21:45 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-05 19:44 Mikael Magnusson
2021-04-05 21:01 ` Mikael Magnusson
2021-04-05 21:44 ` Bart Schaefer [this message]
2021-04-07 13:44   ` Marlon
2021-04-07 16:24     ` Daniel Shahaf
2021-04-10 11:23       ` Marlon
2021-04-10 20:46         ` dana
2021-04-10 21:41           ` Bart Schaefer
2021-04-10 22:03             ` Roman Perepelitsa
2021-04-11 11:38               ` Marlon Richert
2021-04-13 14:49               ` Daniel Shahaf
2021-04-13 14:55           ` Daniel Shahaf
2021-04-07 14:28 ` Marlon
2021-04-07 15:14   ` Daniel Shahaf
2021-04-07 16:36   ` Bart Schaefer
2021-04-07 18:15   ` Mikael Magnusson
2021-04-07 18:50     ` Daniel Shahaf
2021-04-07 20:08     ` Arseny Maslennikov
2021-04-09 20:07     ` Marlon
2021-04-09 22:04       ` Oliver Kiddle
2021-04-09 23:04         ` Daniel Shahaf
2021-04-09 23:55           ` Bart Schaefer
2021-04-13 15:00             ` Daniel Shahaf
2021-04-09 23:08         ` Bart Schaefer
2021-04-10  7:44           ` Roman Perepelitsa
2021-04-09 23:23       ` Mikael Magnusson
2021-04-10  7:45         ` Marlon Richert
2021-04-09 15:29   ` Marlon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7buB+hUY6ufROgGTRc4SPzqjRuO6e4vq2gU4q_UzJH=eg@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=marlon.richert@gmail.com \
    --cc=mikachu@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).