From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI,
	RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4
Received: (qmail 11276 invoked from network); 5 Jul 2020 17:23:43 -0000
Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2)
  by inbox.vuxu.org with ESMTPUTF8; 5 Jul 2020 17:23:43 -0000
Received: (qmail 3557 invoked by alias); 5 Jul 2020 17:23:38 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
Sender: zsh-workers@zsh.org
X-Seq: 46189
Received: (qmail 16434 invoked by uid 1010); 5 Jul 2020 17:23:38 -0000
X-Qmail-Scanner-Diagnostics: from mail-ot1-f50.google.com by f.primenet.com.au (envelope-from <schaefer@brasslantern.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.102.3/25863. spamassassin: 3.4.4.  
 Clear:RC:0(209.85.210.50):SA:0(-1.9/5.0):. 
 Processed in 1.783255 secs); 05 Jul 2020 17:23:38 -0000
X-Envelope-From: schaefer@brasslantern.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.210.50 as permitted sender)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=CiqXbPJI7Eqw5+XYZ62DRCX1Jpfvn5B0v1QKrr9+JlU=;
        b=cT9gvNq0XjL/ffm29veJpjlwCLVOSNnktK5l9m3/0pFr6AQhNWj4B+bLAqtnN9SyvL
         9wNPakjPw7V0jtkaeoziMiOU0J4rtCwBO4mEEGY9+BOSWJuWVQnPWlH3UB0EEoeq6GYz
         Rz/PziOL+d3nYD0s5A9SyJq2Gnc3EuwgNfH5d1joLWB+j5uymf7RHpwtr0xuGYj911bx
         8mjYLSYN49Uhf7DDgj4NOXYvyoXveIHqNlbHx1WwWX2B+eJEyOmEjQNWmX1/YCzH7pdx
         K7+Jp7wjLt4FxEvXWfi2Ti3iDmljdSjULbUNl7R+Lycvv8Er+B0w1+p5iubZqBu8Oe0F
         Jiag==
X-Gm-Message-State: AOAM530e9QtJKUI1oU5vVSywrgJ/6M1w8zZJCUREZnSMoqurEZuc/Yiq
	oPmg1QdEc0E40VxE0gP3zLLa4G0YRp1QF3XiIB6W/cQpWCU=
X-Google-Smtp-Source: ABdhPJyhDKLq/xBRGAfm8cxqO4UnpZa0ozK5u7T/FMNDsEOsnKXdOKlwTEePio1vm6IHbIEsJPpQuX8F6FtzhN12bh8=
X-Received: by 2002:a9d:6047:: with SMTP id v7mr22967390otj.161.1593969783721;
 Sun, 05 Jul 2020 10:23:03 -0700 (PDT)
MIME-Version: 1.0
References: <CACeGjnUn+0CRiJGK2MCfm0xRvhXDB_dYoFcADW4u21s2A+F=uw@mail.gmail.com>
 <CAH+w=7bv_TF7OdoWqEQi1L8GtMBHyAhNZL-oaysV2X4peUxeJw@mail.gmail.com> <CAH+w=7ZOQj_x65=y8wD8MB1u4uhQ-YV5S4Avz6d326=UsobDxw@mail.gmail.com>
In-Reply-To: <CAH+w=7ZOQj_x65=y8wD8MB1u4uhQ-YV5S4Avz6d326=UsobDxw@mail.gmail.com>
From: Bart Schaefer <schaefer@brasslantern.com>
Date: Sun, 5 Jul 2020 10:22:52 -0700
Message-ID: <CAH+w=7buVYy0OA3bXKqTH0xmtgWLN5qRm=AWHVcx52TgrHEqNQ@mail.gmail.com>
Subject: Re: Five New Test Failures
To: Vin Shelton <acs@alumni.princeton.edu>
Cc: "Zsh Hackers' List" <zsh-workers@zsh.org>
Content-Type: text/plain; charset="UTF-8"

On Sun, Jul 5, 2020 at 9:57 AM Bart Schaefer <schaefer@brasslantern.com> wrote:
>
> On Sun, Jul 5, 2020 at 9:28 AM Bart Schaefer <schaefer@brasslantern.com> wrote:
> >
> > It's the change to supposedly subvert symlink attacks.
>
> Hmm, no, I'm getting random failures even after I revert.  Sorry for
> the red herring.

Ahem.  Those failures were something else in my environment.

It does have to do with the "always" block.  All the tests pass if I
just put a "return 0" after the "always".

A bit of further digging indicates that
  zpty_flush After comptesteval
does not always succeed, but it doesn't need to.  The "always" is now
preserving that failure status.

So perhaps this?

diff --git a/Test/comptest b/Test/comptest
index b14d4c9..a36e301 100644
--- a/Test/comptest
+++ b/Test/comptest
@@ -128,6 +128,7 @@ comptesteval () {
        return 1
      }
      zpty_flush After comptesteval
+     : Suppress error from zpty_flush
    } always {
      rm $tmp
    }