From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 26306 invoked from network); 28 Jul 2021 17:58:51 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 28 Jul 2021 17:58:51 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1627495131; b=oOXDSqQlHMZl4VUkYloH6HjfXqK69bxM06Bj6VSJbTcHXd6qT7ccN/GqJn6l7+AsfkhpAf7ehL 5jyM+OF1Zes6eAKmAO1RQBZZEXL/rmVxImDDbI8UJSw2a0iUdmEyFQgm38exCjCX5L2zM6otpw 0w5/0Xwp40V4UZyNW9vdZD9bByxsGtRuYfEsqPK2p6G8aszBX9pvDzBwrAcnhLN1QQczGFKQbM fLXuU7XFvtAnqWiwKi5VT/jV1tAS49mMiW+e/iBvJEx21ou9zXUsgGLx6GqV7Dkj8E5XknZGPg rI9AEZjR353W8r7vAolc9c2g+LRf4s9/uGJ0OSEYb0430A==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-yb1-f169.google.com) smtp.remote-ip=209.85.219.169; dkim=pass header.d=brasslantern-com.20150623.gappssmtp.com header.s=20150623 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1627495131; bh=CuFwlNEv0WaR6x5KqQzj6ysnnIlynUeRoXM4+KkS7cA=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature: DKIM-Signature; b=g+UwnbGqYbCMmvSRUsWTlxBgfo1zQU/k/X8ibIHLFwkqEjb7unc6lh8cb1qXl5VD80H9ddJQRx 0BQbYK6J1bvLXs7M5OE1eW+Ahq2O3UMLqwjYHigm3o3OlFFw1YW3MG3+TB95WsDtzVK9Hfs31B 9OnKy/y3ewOdVYMzJuc96L5slRAsy5Dx3wPqSEVUmJEMt59ODK8TAmfXtdnT6gilu8zTaCyEDr 8TWaiumAqSA91x8S5MilvyxlOfnYshqc+bZ3qbLq0oJs96MWtXT2APZ0FIgsMu/4gE01rciWkO IzCTBANENZ6Z/AdI51Auun99wYF1i2qEyspsoLmjpzLAhA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=uW94TuNXRX3F1l0bFkWS2kGh8NPZNsaghHVbPFJigM4=; b=OdhEjT3Bjsu9YnCmkk3fHTdbR1 9ZNiTRAZO0T9HC4NrdginTUwv9RJqrpDnKYcBhcgVCpYDeM6BcUJkL27MsfPbjdZ1+4YscCKfUtxE RUVMB7dVAulHRFoSzSmHVZiKJ2fubBj+DRWJtcOG+qo1YmynVw3vsFBBOFke017gux/zslGWjf0Et gUXxiFjz+2jjYHpSw3AhNrXef7HHmEBPMqsn3DSlprjvC/cs15y7eI2M/cRqSn4GD4prWnUKyuGgb bDo9jG1fKPV4jUveB9e6FsfJntXTJlwhVMk7WHwT6jOtpTjG+h4n3bRhH7TXflobECm4YMvSfgGxq VHDML7jw==; Received: from authenticated user by zero.zsh.org with local id 1m8npS-0005pI-B2; Wed, 28 Jul 2021 17:58:50 +0000 Authentication-Results: zsh.org; iprev=pass (mail-yb1-f169.google.com) smtp.remote-ip=209.85.219.169; dkim=pass header.d=brasslantern-com.20150623.gappssmtp.com header.s=20150623 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-yb1-f169.google.com ([209.85.219.169]:40754) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1m8npC-0005WN-7e; Wed, 28 Jul 2021 17:58:34 +0000 Received: by mail-yb1-f169.google.com with SMTP id s48so5357389ybi.7 for ; Wed, 28 Jul 2021 10:58:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=uW94TuNXRX3F1l0bFkWS2kGh8NPZNsaghHVbPFJigM4=; b=yoSR6aVyAEOeqOviKe1okRo8hiQfEwhaITbOswEjzeZPxKdcUTv463LQ5r90Qk364C WirAy4j1qK8wYxUVzRqIwQTmydspAUg7qvWCdoIyxdGTKM1s3i7U+00dr3Q2nGhRp8wo op5+9V3SsghX9tbkchMtzmWUt/m31u7eV4UIyjUgV3WwC2n7RKpvzazq/bLf3Pg+ceBc 6RcmQ0Z0DpQEJt45cVcmHizszoRUZBLcMnpMvxsnVt8lh9GjTGZOrk6cMtu3QLDlNxz8 HvQ8JfqDXt7AGudkTczd8WMVgqUSWoUX5JznFTgsQlDI1qFrgRnITyYNfFaf7c/NwBao 08HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=uW94TuNXRX3F1l0bFkWS2kGh8NPZNsaghHVbPFJigM4=; b=CzCe3XXVbUe5jYxKvX9Z90C3r/HoD7rKdLOCRrq6/HGSjVNHJNIfRe/LCf//VdJs9m SQnh9DIaXa0KWKhx88vAl/nZCT2K2tnZeZ24apFd5soI92QfIqQEvqwJ7JQNlA5UH9mE xotViiH/bd3NUDJfJQRSPF2Jk8f9/w/NFvdFuY2EJQ8X456zXY4Nl1DwsYLFsufCnAUJ zl7iwtEWTWdPNFGtOz9JYuToPpM2vnaZPDMX8Iwm3WOhaZfie8sOeXLtrx0WetwnhnqF odNgOqT9fjga8XGK6fE6VLe9WlXVl/oo/T11HuLJOKocFCWjIJ//IYRmqod6A91qs1UB v3IQ== X-Gm-Message-State: AOAM531LLfS6aGDLt6KPtcawH0SuGCmvf4cGQizl9+tjttI9fT0CdNax 0EFfC4mdkReuQIkYd3WPh0eO6uCAEnvdSL0165g6fQ== X-Google-Smtp-Source: ABdhPJyeXxv00GkAWRGrZn14XK82zn2+WrH2N7pkJwVUo1ikclJb/cP8+uAdqacjljR4Mx9v01Nfzm1RZe8A4d30nXA= X-Received: by 2002:a25:dc12:: with SMTP id y18mr1215527ybe.69.1627495113307; Wed, 28 Jul 2021 10:58:33 -0700 (PDT) MIME-Version: 1.0 References: <3f494f65-cede-41f5-862f-cfd8424668ea@www.fastmail.com> <0f3f4217-44f6-4bf9-b2d2-2110ae10d40e@www.fastmail.com> In-Reply-To: <0f3f4217-44f6-4bf9-b2d2-2110ae10d40e@www.fastmail.com> From: Bart Schaefer Date: Wed, 28 Jul 2021 10:58:22 -0700 Message-ID: Subject: Re: Let run-help filter cmd_args before calling run-help- (was Re: [RFC][PATCH] Try calling command with help flags in run-help) To: =?UTF-8?Q?Lawrence_Vel=C3=A1zquez?= Cc: Zsh hackers list , Marlon Richert Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 49215 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Sun, Jul 18, 2021 at 11:46 AM Lawrence Vel=C3=A1zquez w= rote: > > On Sun, Jun 20, 2021, at 2:01 PM, Lawrence Vel=C3=A1zquez wrote: > > On Sat, Jun 5, 2021, at 3:15 PM, Marlon Richert wrote: > > > New patch here with test cases, plus a rewrite of run-help-git. All t= he > > > tests succeed for both the new and old versions of the run-help-* > > > functions (except for the old run-help-git, because the new > > > run-help-git uses `git help` instead of `man`). > > > > > > Attachments: > > > * 0001-Let-run-help-filter-cmd_args-before-calling-run-help.txt > > > > bump > > bump bump Nothing obviously wrong with the code patch, but one of the test cases fails for me: --- /tmp/zsh.ztst.50384/ztst.out 2021-07-28 10:56:06.301935368 -0700 +++ /tmp/zsh.ztst.50384/ztst.tout 2021-07-28 10:56:06.301935368 -0700 @@ -1,2 +0,0 @@ -git is WHENCE:{git} -GIT:{'help' 'git'} Test ./Z03run-help.ztst failed: output differs from expected as shown above= for: BUFFER_STACK=3D'git --exec-path' Was testing: git with option ./Z03run-help.ztst: test failed.