From: Bart Schaefer <schaefer@brasslantern.com>
To: Sebastian Gniazdowski <psprint@zdharma.org>
Cc: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: Valgrind testing, ideas
Date: Thu, 25 May 2017 22:50:25 -0700 [thread overview]
Message-ID: <CAH+w=7bwXF2wOw_ZNyR1ho=b1RkajJJED=00uhHfVBwXAc0=fQ@mail.gmail.com> (raw)
In-Reply-To: <etPan.5927b758.12200854.1a9@MacMini.local>
On Thu, May 25, 2017 at 10:04 PM, Sebastian Gniazdowski
<psprint@zdharma.org> wrote:
>
> The arrlen branch seems to faint.
Sorry, what's the "arrlen branch"?
> Also I get multiple PIDs from valgrind.
Not all tests use the single zsh. Some explicitly re-invoke
$ZTST_exe, others run in subshells. In fact when I want to add
valgrind to a "make check", I insert
local ZTST_exe=(valgrind $ZTST_exe)
> Last thing, there should be much more test files. Single test per-file, I think.
I'm not thrilled with this suggestion. There are a lot of tests that
depend on sharing a single %prep (and corresponding %cleanup) section,
for example, and also a number of tests that depend on cascading one
after the other. The amount of duplicated code that would result from
attempting to make these into singleton files would lead to other
problems.
next prev parent reply other threads:[~2017-05-26 5:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 5:04 Sebastian Gniazdowski
2017-05-26 5:50 ` Bart Schaefer [this message]
2017-05-26 7:57 ` Sebastian Gniazdowski
2017-05-26 10:56 ` Daniel Shahaf
2017-05-26 23:48 ` Bart Schaefer
2017-05-28 19:43 ` mikachu/badarrays (Re: Valgrind testing, ideas) Bart Schaefer
2017-05-29 13:21 ` Mikael Magnusson
2017-05-31 5:47 ` Bart Schaefer
2017-06-01 16:31 ` Sebastian Gniazdowski
2017-06-01 20:35 ` Bart Schaefer
2017-06-02 1:40 ` Sebastian Gniazdowski
2017-06-02 22:00 ` Bart Schaefer
2017-06-04 0:49 ` Bart Schaefer
2017-06-04 7:08 ` Sebastian Gniazdowski
2017-06-01 21:22 ` Mikael Magnusson
2017-06-01 21:38 ` Bart Schaefer
2017-06-07 10:53 ` PM_ flags (Re: mikachu/badarrays ...) Oliver Kiddle
2017-06-07 18:15 ` Mikael Magnusson
2017-06-07 22:18 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7bwXF2wOw_ZNyR1ho=b1RkajJJED=00uhHfVBwXAc0=fQ@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=psprint@zdharma.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).