From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-41161-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 2041 invoked by alias); 26 May 2017 05:50:33 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 41161
Received: (qmail 7110 invoked from network); 26 May 2017 05:50:33 -0000
X-Qmail-Scanner-Diagnostics: from mail-qt0-f180.google.com by f.primenet.com.au (envelope-from <schaefer@brasslantern.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(209.85.216.180):SA:0(-0.2/5.0):. 
 Processed in 1.137447 secs); 26 May 2017 05:50:33 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-0.2 required=5.0 tests=RCVD_IN_DNSWL_LOW,
	RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_SPAM,SPF_PASS,
	T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1
X-Envelope-From: schaefer@brasslantern.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.216.180 as permitted sender)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=brasslantern-com.20150623.gappssmtp.com; s=20150623;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc;
        bh=O/T0hm/+1KgCmBp4X0Sq9LpEfaNgqnSpFwvdGY06l8Y=;
        b=GmXUaDy3PJzXINsoQrVdYdfqiNf/NYlI8hDYLXW+HGWZ/WAlyY7t7uvBaPtJ3eYU6P
         mZfgkDF6WienHgV6TS/Z1irTcOPFdpIqq3UF5a8KWacLJCT9FsUOlBYnMxEwZWeovkRF
         7RF4qgwbDF1i1386q/xWAzn13+7hg18/UlZo0RxaYjya46SyoRVH+SUC2YKHtL9yUSeV
         4J7OKxuD9UA9krD9JypEnItlQCrEr3Mw3UzDm0L62XhR/csqlzvJ5jX+b/F0nJ/ncZwe
         +Pmw9EmArWRt9fUEyc71v+u6fy55K98O6koJfgLz3rvvucHjCL0FjxDzgov6oBZjfQwO
         2peg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:in-reply-to:references:from:date
         :message-id:subject:to:cc;
        bh=O/T0hm/+1KgCmBp4X0Sq9LpEfaNgqnSpFwvdGY06l8Y=;
        b=PLY8U2VpDUlfCqsRK7CoYrfodEM4uT4q2mC3IVJFuY289QnLlwvcflN83suP+peAmE
         CQwdJ1mO1oWqcpMv7rMj2u/a7g7m+q2e7CNfDz/QbNNdo4JghYTOkpeMGHtTUFqXRCyv
         za0+JDy7QFBBv4QjP0txLrEJD/RqQvy1HSvjJjRzQyZLF5w95CCwpvnYwq/vnKsUTJ8u
         y8X2mhTMD68jMxJoMpVaObnVEshi0ihouLipThpKk3Rs2ND7/tb0JT8SEUSSadM/JI44
         s4k3DlteeWFTbC4HNE0c7bLOp/A69EtrUI10km8MQDHQQZGveTyr70xLMZDJLJCvFjDh
         S+pw==
X-Gm-Message-State: AODbwcDxYrDn0opDHi8FurNwHrHOz3jf+ehGPuZWxKYzFOCMMkLoem7U
	+012RfNMbvrkOYwsSmJ055r7vgTMSc3P
X-Received: by 10.200.50.49 with SMTP id x46mr246760qta.105.1495777826009;
 Thu, 25 May 2017 22:50:26 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <etPan.5927b758.12200854.1a9@MacMini.local>
References: <etPan.5927b758.12200854.1a9@MacMini.local>
From: Bart Schaefer <schaefer@brasslantern.com>
Date: Thu, 25 May 2017 22:50:25 -0700
Message-ID: <CAH+w=7bwXF2wOw_ZNyR1ho=b1RkajJJED=00uhHfVBwXAc0=fQ@mail.gmail.com>
Subject: Re: Valgrind testing, ideas
To: Sebastian Gniazdowski <psprint@zdharma.org>
Cc: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Content-Type: text/plain; charset="UTF-8"

On Thu, May 25, 2017 at 10:04 PM, Sebastian Gniazdowski
<psprint@zdharma.org> wrote:
>
> The arrlen branch seems to faint.

Sorry, what's the "arrlen branch"?

> Also I get multiple PIDs from valgrind.

Not all tests use the single zsh.  Some explicitly re-invoke
$ZTST_exe, others run in subshells.  In fact when I want to add
valgrind to a "make check", I insert
  local ZTST_exe=(valgrind $ZTST_exe)

> Last thing, there should be much more test files. Single test per-file, I think.

I'm not thrilled with this suggestion.  There are a lot of tests that
depend on sharing a single %prep (and corresponding %cleanup) section,
for example, and also a number of tests that depend on cascading one
after the other.  The amount of duplicated code that would result from
attempting to make these into singleton files would lead to other
problems.