From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 26881 invoked from network); 21 Jun 2023 03:50:17 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 21 Jun 2023 03:50:17 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1687319417; b=Ay8xoc9/e4pq7f+w5qPZzP+zAGIqTde1WpDzmCr9IasXGC4qP1prP0JW9VuoGKwuXzYEz70Qlo Gwxi+2rJLSh3O4U71NdEfM6TDst8o40/Bn4HnFrrY5oyE1uUXqA3vsAiD7o/hFgWoyJLe2/auX mmkUfopU71vnnB8LZaDTLIrd20sO/OzYgT9fubjlpyE83A2b6WB8Ch6ARJEDx7YDdaZkmBPQkl 0wq9Unu3/2hZtbKbUoPU0xp9faa9HS2fqLJ2AuyOpLj6uUpDCMJnjGGLR/9bZj82Nhv0ycNfvR 7bsnVktdOLE9suH3ZUmkHiK6zJU5wj6ch1KJQdvqNQcCOw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f49.google.com) smtp.remote-ip=209.85.218.49; dkim=pass header.d=brasslantern-com.20221208.gappssmtp.com header.s=20221208 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1687319417; bh=kZbC8B7yz79N8NkFMHn3Y5TrH1aM6rce+sndfll3fAc=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature: DKIM-Signature; b=DW3+IKIIy6fgpL4uJ1vFfjl0N7B0vo+Ie4xc1G062jXXH5E3xOWmQH3lvVAKGZGAUFbuk6f7qu Pe/EkxGMb9NUF8XB/TDRSPac753tzom377tVnU+fd909SsrkgLaI0pJ4BBbSoZ3IYkPonhIpq1 6joh7RV8bT1boFIxggOgbAw7eahoaOaQaMTeIHhkQW35chXia8pT+RXav2EAYakFwoE7GSX8tt /DO1gpN+ERP/MGIjZ0Kp9+LZK44f1j7SAcc02/zVfktRprPw7jbORFEhFAkRPPG0SE/BDIZHn7 dw/CT+MPtd81mrdaSveDh0TR+v2nXZfhdxyvoHvA6tuBvA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=QJpyFQgftj1K7nGtZBR1giEVjCcKfTsDC1QtuKDSMbE=; b=PFlhFH6lF2WNyApTHmGWOpPIH2 V6D2k/QckTt7jlrrBf6YVIJMLZiigx8iYVtF4rMmDwxBu5DxIEHUWVdQTiWDzoj1JAWMPHvDx+nST tUjfouPwN1/ATPNyRZqYZd8/buwksiXqenUV0rk6MIBJ8rICaXkedwD04XO/e9WA5eKlaQGSf+Rbh 1DpdMa158yE0mE73G20NRxg4t/FrsDxdSHTSMSeDgdPYDxBOL2S1T7D3FJ6sbfXFzvsNKvEG+kGOu oQ2jeoN7Q9Qf0gDbn8RpqqvfkvkQxm2QzpvCyttm8Sehr7d2YM7BJQn0TT37zgTW8ZBHnYn8QPsks jSaBdMkg==; Received: by zero.zsh.org with local id 1qBorJ-000LzA-DL; Wed, 21 Jun 2023 03:50:17 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f49.google.com) smtp.remote-ip=209.85.218.49; dkim=pass header.d=brasslantern-com.20221208.gappssmtp.com header.s=20221208 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ej1-f49.google.com ([209.85.218.49]:48328) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1qBor1-000LeD-8U; Wed, 21 Jun 2023 03:50:01 +0000 Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-987c932883bso644645166b.0 for ; Tue, 20 Jun 2023 20:49:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20221208.gappssmtp.com; s=20221208; t=1687319398; x=1689911398; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=QJpyFQgftj1K7nGtZBR1giEVjCcKfTsDC1QtuKDSMbE=; b=XWQUrdRo6ON+7mo4naDDvWdk/lmDoPyMr9yZqUgIkQPLLDwggZ6qJk2Tvx2gsqUsY8 G8tBUJmsIA3yXKbsP+I7lcuhfYQYvDzQNWvvZapndchY4Sv7Dv/vVVE4sNhTWMTx+0YW 9J5U6m6562n68NguHIGVsSo9DZirO7PpKndC1k9Z46oFGZJWe0K/7m+q1I0FnM0Z44NO cZXP3NadF2Dv38E2RJ/0kKBGpve1BfwkOkwiCY5ytQdN0sXVTfHtQRySC9IKKJqUMUm0 AuhcBJzTzbs84N53UfvCedyWUwiU+WE/4VAGiRSisySldDPJKXbhpbDbdC0b+Li+nm6s nCeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687319398; x=1689911398; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QJpyFQgftj1K7nGtZBR1giEVjCcKfTsDC1QtuKDSMbE=; b=Af3V4s7jg9kyYUD0RMEU/Yhlo3zNxhcdIXAgLLdPcUr12wDcaRSISVVvTspg4tP+P/ uNLlRDEqq4P6WyutunrJjfMy5sUBphPVU5H6EECxZVSLH9+V8IICBQ7f4J3nuDrxzM2U rs/8IF96yzSE5D9k8rPQoHIg8EsG3p04U5hwgHHcFwZlrllPXVlHhtkg3+xD7plRbKnT XC9Gummp+vUEQ6vAoHbZyDlYzdDZ9/qUj22BdSgmLUKQIKmLbhrp8VD/BCSWglMr5rjk CbRTPl465QcBfyPqWLyQi6iK4YLQguEtK0tVXbc6MTZz+Us9KUlY32R/OHekLndiwqlc Kpxg== X-Gm-Message-State: AC+VfDzI1ri50J0/D0HRGPjz2cYoJ3zEHbC8hweETNRICOJ/TbpHLI6I +IIEKA2xcahSF7Aj4p9U3oKV6gd1rrT+tYslM/xh/g== X-Google-Smtp-Source: ACHHUZ63DcrZfSU0S7n8KEuSVFI8YwIkNrfTvIBzMbUG/BZ/Dz2hvfvGME0ALFHwHkDHOlKGxiU6+Y/r8DzjIA2zfA4= X-Received: by 2002:a17:907:9449:b0:988:6491:98e1 with SMTP id dl9-20020a170907944900b00988649198e1mr7512297ejc.42.1687319398483; Tue, 20 Jun 2023 20:49:58 -0700 (PDT) MIME-Version: 1.0 References: <20230615142916.20616-1-marlon.richert@gmail.com> In-Reply-To: <20230615142916.20616-1-marlon.richert@gmail.com> From: Bart Schaefer Date: Tue, 20 Jun 2023 20:49:47 -0700 Message-ID: Subject: Re: [PATCH] Let _approximate work w/ possible compadd function To: Marlon Richert Cc: zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 51883 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On Thu, Jun 15, 2023 at 7:29=E2=80=AFAM Marlon Richert wrote: > > +_shadow -s _approximate compadd > +compadd() { > + local ppre=3D"$argv[(I)-p]" > [...] > + > + compadd@_approximate "$_correct_expl[@]" "$@" > +} I'm concerned that this doesn't work in the event that _approximate is called recursively. Maybe that never happens? If it did, "_shadow -s" will not re-create compadd@_approximate, but _unshadow will remove it, in each case leaving "compadd" pointing at the wrong earlier shadow.