From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 17383 invoked from network); 7 Aug 2021 19:56:23 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 7 Aug 2021 19:56:23 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1628366183; b=IWqZgUbSSPRgHjwdZ2BsivxxwmwYSzxIp54kopQ9rAc+mvNTpAp2c8tlkKwgM7i+s5fVOc/qu+ TxL5eNfrWUKlielIoHUDSELtV5O/yaYZRwtO5uP0Z7zuR3WQj01YHB8EEZeKY3aqhSmfN/d1NE KYW47hoX5rKsXenDcRq55zS6c7Xf8n9BPG1xaSGp2CzS4ijhFGN5hHGlMjSPz1IQTAZIFonAC8 qoFlghSnbKlVG1B5MJXy4+/EM2mNjy6UPGIMizHUAiR7XehuZ57A+lsYRjf/8gAP78g8ODZbBV Sio1xNQIyLSeyVXTQnjvoF1+veTVWEZR1GCxvZrCza2i4Q==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-lj1-f173.google.com) smtp.remote-ip=209.85.208.173; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1628366183; bh=HiqQ5CuMrlR93MQDZh6xJqME0lUDU8bhsZGnWhCvcKE=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=GbeP7hh8rvnVL9BAlP7sB87lV9YCKM5yF0AK1/z+CzVnl2V41M8WFU9eidloXwRGgxIa95etkN FaAOcokS1yx+6g520amVql0DdY7KgMr8MKeb7rF11MMz4f9z85ehQi0YOfzZK7REI/D11Q8vXT /WDDYh18tf/5780lc440fm/i/qtw5Mn7i2+y8wDhzfjyJGTnfB4m6f8tUss6NPld0QBWPQ7ANo rcEqmf/uW+F+/727w/Vkb/QWQzDiKaJ0da7vF+P+qvzpCG+wL6Ys9/C/8Baj1DjAPf0EFwJdNU ZbmkJw4GcibLrH1aTjui7ZwZZwd8FvvXzJUoeStQEsTImw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=b9gUOez6fOp4SO+HNYCkuTp4Ybs2KJbuMCvAZ1MQSKE=; b=VD82SDdT66lcz9CLGS7k/u6ZNN ulZG8DrzWhsKsuOvIXIexPkrXEZaHbWy0ecBkoHd2sdCp7WhZJydEAtCllrIkjj28uNf/ImnqK4qi wnPisYbv9czmf3B9XC7/TRLCxVigGccXG1vPnqpw7T3wG7ALvkxz3iMLPSOTNaY32kvlsvTvNNOax mOBoLhRP5VTC7ioWXfcufrtGjgwIuwYlEZ8xB7hYulpSbt+qIFUQSANtW6KGun/mXNPwAJ+nwCYCK 6W6Kstw1b8vIadZ177G9GqapTMup4c0tooXmVSpBvqEy+09PIXSWf/VGLt57mtMFtjbhjsiFVRXw8 6+vqGNnQ==; Received: from authenticated user by zero.zsh.org with local id 1mCSQg-000JUB-LW; Sat, 07 Aug 2021 19:56:22 +0000 Authentication-Results: zsh.org; iprev=pass (mail-lj1-f173.google.com) smtp.remote-ip=209.85.208.173; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-lj1-f173.google.com ([209.85.208.173]:45819) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1mCSQT-000JAl-8d; Sat, 07 Aug 2021 19:56:09 +0000 Received: by mail-lj1-f173.google.com with SMTP id h11so2234221ljo.12 for ; Sat, 07 Aug 2021 12:56:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b9gUOez6fOp4SO+HNYCkuTp4Ybs2KJbuMCvAZ1MQSKE=; b=eof4Xqpxoyotv4bWqW9KOGR5u7WmEdn/fWNGBB1NxBo0e5U0BZoOD3oD4CwHkWtAhR TJ8K+PbNKYJWkGYWgd6k5VwNfh1zfQU60TmH8Pfimif7mfUaTUZF3EeTxwHn1NpEqyuR goA6L882fn0jHRj7t+jzX0O7CRz7h4uuS1XhW/juPi299ey6N778HUJZWqkPbFs+/wPf ni4ARyq8fEuzf5YLCsTieqY1Z9sHW2cGo+rvemDg/Q5zbUw6y0fLvAAK43qveN7oM4NA O45qA8Wzj3lUXb/iF55MweLNMAPTtH5W48Z7XiiSOWECbq4jMqVPCzbuyqU2F/HLg3/e a1RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b9gUOez6fOp4SO+HNYCkuTp4Ybs2KJbuMCvAZ1MQSKE=; b=eo3a4SdKHY4DvAr9TVTcHutkJPbgCtP98WbdPMQWhL8saYRA8K92kcNwjczS7vPSs7 NGIBUdgDM9sp3xOUhmoZ3v64JOtLIld+dSWSv2Lb3zvwaUww18nZoJUh8xw+60JI1q9w syw05u69q/zQOFj1KruVoX0vj8Lo8Yd7ckX7iPbd5zcf/yhTTnyzDwu0axID4UrNa7ZY jG+o5PoqBk31yhRKfuwrM+xU8l+f+KxKIIPneT9BQZVYSP3a6JD5LNfeYxPD92YGsSZB H4RZXP9nj+0pZ/WGi5uel8M0xHs7psiY92lk5QohhaAoJmnMfNKv7KEqUwJJLCZpy6dj +oKg== X-Gm-Message-State: AOAM533PhpuPlNQ/rLc+tOpbj5mpC2bOOBY4N9EaiWrMUSbFtURs+MzY nf9m1phGBlpHFSr5AuUct4xZwos5/0IY6EeHWzo= X-Google-Smtp-Source: ABdhPJxq0tmhNIrABSwNikJIAKkmR39bH7iIgr5e8EZ/3Tx5QhQZTpIV686+DqD8QhEpTKOT+lno+wOi7aMkDhmw5Tg= X-Received: by 2002:a2e:a22c:: with SMTP id i12mr10567480ljm.267.1628366168744; Sat, 07 Aug 2021 12:56:08 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Marlon Richert Date: Sat, 7 Aug 2021 22:55:32 +0300 Message-ID: Subject: Re: [PATCH] Increase $COLUMNS when generating long option completions To: Bart Schaefer Cc: Zsh hackers list Content-Type: multipart/mixed; boundary="0000000000000d7c2205c8fd8b0e" X-Seq: 49256 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: --0000000000000d7c2205c8fd8b0e Content-Type: text/plain; charset="UTF-8" On Fri, Aug 6, 2021 at 2:44 AM Bart Schaefer wrote: > > On Thu, Aug 5, 2021 at 11:12 AM Marlon Richert wrote: > > > > I don't know if it makes sense to always set > > COLUMNS in _call_program, because it is not always called to produce > > visual output. On the other hand, if you think it won't hurt, then > > yes, that might be a better option. > > I can't think of a case where it would be an issue ... if the program > isn't producing output meant for the terminal, it shouldn't be > bothered by either the presence or absence of $COLUMNS. I'm now > pondering whether your original method does either a better or a worse > (or neither) job if the called program uses a remote shell or the > like. > > > I made it 999, rather than $COLUMNS, because the output is cached and > > terminal emulators can be resized. > > Hrm. That sounds like a problem with the cache validation rules, but > I suppose setting a large value of COLUMNS is a reasonable safeguard. How does this patch look to you? --0000000000000d7c2205c8fd8b0e Content-Type: text/plain; charset="US-ASCII"; name="0001-Set-COLUMNS-in-_call_program-to-ensure-cached-comman.txt" Content-Disposition: attachment; filename="0001-Set-COLUMNS-in-_call_program-to-ensure-cached-comman.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ks2731ac0 RnJvbSAxOTEyYTU3NWZiZGYzNGU0OTM3ZWVlYTkzODc4MDczNTEzNDJmYzM3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJsb24gUmljaGVydCA8bWFybG9ucmljaGVydEB1c2Vycy5u b3JlcGx5LmdpdGh1Yi5jb20+CkRhdGU6IFNhdCwgNyBBdWcgMjAyMSAyMjo1MjoyMSArMDMwMApT dWJqZWN0OiBbUEFUQ0hdIFNldCAkQ09MVU1OUyBpbiBfY2FsbF9wcm9ncmFtIHRvIGVuc3VyZSBj YWNoZWQgY29tbWFuZCBvdXRwdXQKIGlzIHN1ZmZpY2llbnRseSB3aWRlCgotLS0KIENvbXBsZXRp b24vQmFzZS9VdGlsaXR5L19jYWxsX3Byb2dyYW0gfCAxMyArKysrKysrLS0tLS0tCiAxIGZpbGUg Y2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0Nv bXBsZXRpb24vQmFzZS9VdGlsaXR5L19jYWxsX3Byb2dyYW0gYi9Db21wbGV0aW9uL0Jhc2UvVXRp bGl0eS9fY2FsbF9wcm9ncmFtCmluZGV4IDczZjNlZjZkMi4uY2M3YzlhZGY5IDEwMDY0NAotLS0g YS9Db21wbGV0aW9uL0Jhc2UvVXRpbGl0eS9fY2FsbF9wcm9ncmFtCisrKyBiL0NvbXBsZXRpb24v QmFzZS9VdGlsaXR5L19jYWxsX3Byb2dyYW0KQEAgLTEsNiArMSw3IEBACiAjYXV0b2xvYWQgK1gK IAotbG9jYWwgY3VyY29udGV4dD0iJHtjdXJjb250ZXh0fSIgdG1wIGVycl9mZD0tMSBjbG9jYWxl PSdfY29tcF9sb2NhbGU7JworbG9jYWwgY21kIGNsb2NhbGU9J19jb21wX2xvY2FsZTsnIGNvbHM9 J0NPTFVNTlM9OTk5JyBjdXJjb250ZXh0PSIke2N1cmNvbnRleHR9IgorbG9jYWwgLWkgZXJyX2Zk PS0xCiBsb2NhbCAtYSBwcmVmaXgKIAogaWYgW1sgIiQxIiA9IC1wIF1dOyB0aGVuCkBAIC0yMiwx NCArMjMsMTQgQEAgZmkKIAogewkjIEJlZ2luICJhbHdheXMiIGJsb2NrCiAKLWlmIHpzdHlsZSAt cyAiOmNvbXBsZXRpb246JHtjdXJjb250ZXh0fTokezF9IiBjb21tYW5kIHRtcDsgdGhlbgotICBp ZiBbWyAiJHRtcCIgPSAtKiBdXTsgdGhlbgotICAgIGV2YWwgJGNsb2NhbGUgIiR0bXBbMiwtMV0i ICIkYXJndlsyLC0xXSIKK2lmIHpzdHlsZSAtcyAiOmNvbXBsZXRpb246JHtjdXJjb250ZXh0fTok ezF9IiBjb21tYW5kIGNtZDsgdGhlbgorICBpZiBbWyAiJGNtZCIgPSAtKiBdXTsgdGhlbgorICAg IGV2YWwgJGNsb2NhbGUgJGNvbHMgIiRjbWRbMiwtMV0iICIkYXJndlsyLC0xXSIKICAgZWxzZQot ICAgIGV2YWwgJGNsb2NhbGUgJHByZWZpeCAiJHRtcCIKKyAgICBldmFsICRjbG9jYWxlICRjb2xz ICRwcmVmaXggIiRjbWQiCiAgIGZpCiBlbHNlCi0gIGV2YWwgJGNsb2NhbGUgJHByZWZpeCAiJGFy Z3ZbMiwtMV0iCisgIGV2YWwgJGNsb2NhbGUgJGNvbHMgJHByZWZpeCAiJGFyZ3ZbMiwtMV0iCiBm aSAyPiYkZXJyX2ZkCiAKIH0gYWx3YXlzIHsKLS0gCjIuMzAuMSAoQXBwbGUgR2l0LTEzMCkKCg== --0000000000000d7c2205c8fd8b0e--