zsh-workers
 help / color / mirror / code / Atom feed
From: Marlon Richert <marlon.richert@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: "Lawrence Velázquez" <larryv@zsh.org>,
	"Zsh hackers list" <zsh-workers@zsh.org>
Subject: Re: [PATCH] Let 'extra-verbose' completion show alias values
Date: Wed, 9 Jun 2021 16:27:23 +0300	[thread overview]
Message-ID: <CAHLkEDsfx8+obaf99LCWn2OW2TYwFR4zeTk=qhqE-Ng=LYaLmQ@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7a1C04fbTSm=7uupfVRaLybY3qtu92wReZKpjod+WPbjQ@mail.gmail.com>

On Tue, Jun 8, 2021 at 11:11 PM Bart Schaefer <schaefer@brasslantern.com> wrote:
>
> On Mon, Jun 7, 2021 at 3:29 PM Lawrence Velázquez <larryv@zsh.org> wrote:
> >
> > On Fri, May 28, 2021, at 6:02 PM, Marlon Richert wrote:
> > > See attachment.
> > >
> > > Attachments:
> > > * 0001-Let-extra-verbose-completion-show-alias-values.txt
> >
> > Any feedback on this?
>
> I'm probably not going to take responsibility for committing this, but:
>
> If you do NOT have { zstyle ':completion:*' group-name '' } this
> behaves a bit oddly.  External, builtin, and alias are all grouped
> together, causing strange layout (the descriptions line up for
> everything but the alias):
>
> valgrind           -- a suite of tools for debugging and profiling programs
> valgrind.bin       -- a suite of tools for debugging and profiling programs
> valgrind-di-server -- Experimental debuginfo server for valgrind
> valgrind-listener  -- listens on a socket for Valgrind commentary
> vared  -- noglob vared
> vdir               -- list directory contents
> vftovp             -- convert virtual font (vf) files to virtual property li...
> vgdb               -- intermediary between Valgrind and GDB or a shell
> (etc.)
>
> Also the set of names is not unique-ified, so if "vared" is an alias
> (as in my test case) it also re-appears in the multi-column listing of
> external commands because of the presence of the vared function in the
> fpath.  Both of these issues go away with group-name styled.
>
> I have no opinion on whether these effects are significant enough to
> be in need of repair, just making mention.

This also happens if you have extra-verbose but no group-name and you
get both command & parameter completions in the same list:

% v
vared  -- vared
vim      -- Vi IMproved, a programmer's text editor
vim    -- vim
vimdiff  -- edit two, three or four versions of a file with Vim and
show differences
vimtutor -- the Vim tutor
vis      -- display non-printable characters in a visual format
vm_stat  -- show Mach virtual memory statistics
vmmap    -- Display the virtual memory regions allocated in a process
vtool    -- Mach-O version number utility
vared           venc_data_dump  vi              view            visualinfo


  reply	other threads:[~2021-06-09 13:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-28 22:02 Marlon Richert
2021-06-07 22:27 ` Lawrence Velázquez
2021-06-08 20:11   ` Bart Schaefer
2021-06-09 13:27     ` Marlon Richert [this message]
2021-07-18 23:13       ` Lawrence Velázquez
2021-07-28  3:26         ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHLkEDsfx8+obaf99LCWn2OW2TYwFR4zeTk=qhqE-Ng=LYaLmQ@mail.gmail.com' \
    --to=marlon.richert@gmail.com \
    --cc=larryv@zsh.org \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).