zsh-workers
 help / color / mirror / code / Atom feed
From: Marlon Richert <marlon.richert@gmail.com>
To: "Lawrence Velázquez" <larryv@zsh.org>
Cc: Bart Schaefer <schaefer@brasslantern.com>,
	Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] Increase $COLUMNS when generating long option completions
Date: Thu, 5 Aug 2021 09:19:38 +0300	[thread overview]
Message-ID: <CAHLkEDsieRtSrdYPwCOUDGZRprukkBwuGwJ51SjLZExDVZ3Y4g@mail.gmail.com> (raw)
In-Reply-To: <CB6936F6-1D97-4CE0-ACE2-71785A163450@zsh.org>

On Wed, Aug 4, 2021 at 10:19 AM Lawrence Velázquez <larryv@zsh.org> wrote:
>
> Yes, these commands are explicitly setting COLUMNS in pip’s environment. As Bart said, the tty vs. not-tty distinction probably only matters when COLUMNS is not in pip’s environment.
>
> Same thing here. You are explicitly setting COLUMNS in the environment of ls, and ls is respecting it.

OK. Thanks for clearing that up.

I don't think this all changes anything about the patch, though?


  reply	other threads:[~2021-08-05  6:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-01 19:24 Marlon Richert
2021-08-01 23:06 ` Bart Schaefer
2021-08-03 14:05   ` Marlon Richert
2021-08-04  1:12     ` Lawrence Velázquez
2021-08-04  3:48       ` Bart Schaefer
2021-08-04  6:51       ` Marlon Richert
2021-08-04  7:19         ` Lawrence Velázquez
2021-08-05  6:19           ` Marlon Richert [this message]
2021-08-05  6:24             ` Bart Schaefer
2021-08-05 18:11               ` Marlon Richert
2021-08-05 23:44                 ` Bart Schaefer
2021-08-07 19:55                   ` Marlon Richert
2021-08-07 22:41                     ` Bart Schaefer
2021-08-10 19:04                       ` Marlon Richert
2021-08-10 19:17                         ` Marlon Richert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHLkEDsieRtSrdYPwCOUDGZRprukkBwuGwJ51SjLZExDVZ3Y4g@mail.gmail.com \
    --to=marlon.richert@gmail.com \
    --cc=larryv@zsh.org \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).