From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 20243 invoked from network); 16 May 2021 19:41:45 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 16 May 2021 19:41:45 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1621194105; b=ya4j/hQyui5mKz+is2hCEbJQD5JADFZrTMNO8Bu+/a5G7bMGsl3H97LNXrCxNDdCUR+DlwzQT2 bgMJGHUniwwfxm93cEeq9i3Nb7WIBDhrZGdGe/gKH46b8e6odj7OnCZyoIjTnGkap9jF2Or42X ofZITXMBoMlKb+CI3wqe+6gBiBvDLw1NDPziEBqWxUZ/wq/wC/Z98gr9gA8joeDE9jesJr5L84 zIcstJ3EszChStpMAx0dt69zfCB5Saecd1wNSuVOaITt8VvtdI+J+ONcOxPnW3k7HEIISF9ViT t10uXGIBRl1TnE7zWNzichK2u/ITubrd0giQmGhnhID4uw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-lf1-f52.google.com) smtp.remote-ip=209.85.167.52; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1621194105; bh=zd/g2r32Xc9ZQyRf5DCG2WsK5vesxQ4xmjIv30YM1N8=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature: DKIM-Signature; b=ST5EUzNH+RtkFIRgIc/KO+S2UYRxPQUNjzEyZfU3HDIwsEkX7Al21842dgkA8Dy4MoiBb8A3ne f9ItpN5KA6k74PRaaa+WAaFj0P0MzLIm7NtIZHacAmmV1ru5ZXO0dfb5ubWkL6fEbBBVLx89BT +0EZVEFlTaYkFJHSkRePq54wbZJplzuv4c+AdpjopZ3scq+7jUK3l7niyEeGx2w+mVuMTVRJ6X 2/qAoVDLi9kcY7SmPyLVIjKHLL4Gi/LL4AnnmvTjcCVXeFbvv0J3tpmTYIhcQopnwRkzttfdtc Mpj3LTARnHRLUe5jBnRlYrtYojURinBk/2mH1CEqej7Vkw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=dUemFRuND8Ok5mURBPwCNxGSCDDRV+nkYo+RrVeyw2I=; b=TFIZwwpZlbUqFlqjBmgzmMMS0T nCh41Su8m5470TGbd8smWxGGo0eMCvLCFiCksnVcO6hKb7VlpMsj3i9oU1aFsN92ZabgKcTqiV44b TRqaTaSjlsE6MCa781gN0PCpoRBfb1Sw+le+OFWoKn36LdwqLokKYYfGWInZHF7c1u8kzlgKsxC2/ riBqIkjD65EwTqPL6BrkFT0joVd9CSE9aQlr7MVP3qpJB0sBbuRY9k8kKED0ygIpk/TnxvzStydGP 2Ptec9BuouxTqIZtys8x1LeOy3++9c4CGAQoyV36nD+XjOmIvuz8OMXmRAD/q0VdRer48hTxtCsYl dI5VyKMg==; Received: from authenticated user by zero.zsh.org with local id 1liMe0-000Aij-Ob; Sun, 16 May 2021 19:41:44 +0000 Authentication-Results: zsh.org; iprev=pass (mail-lf1-f52.google.com) smtp.remote-ip=209.85.167.52; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-lf1-f52.google.com ([209.85.167.52]:35634) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1liMdj-000AQ2-RX; Sun, 16 May 2021 19:41:28 +0000 Received: by mail-lf1-f52.google.com with SMTP id x19so5681236lfa.2; Sun, 16 May 2021 12:41:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=dUemFRuND8Ok5mURBPwCNxGSCDDRV+nkYo+RrVeyw2I=; b=bWRYluWq/IpmWk0qtw90OtpPmV4QTZq00ljl+FCvdVplTgEsi23IzWMi07+8pcaGFC XnQxqHhU9iZdiCLLi9XwvvxXQi16Vc75a3rB0SuEQQaZ4+CCqHPX9s1YzOP5yf3H5yeL 9YDaE52CDhhUDybhnqq5srOiimM8BVFc9oCj0BmfeNXbCbnDoS/iMS/o1hoYGq0QWrop QxIeXUlC/peUls9dkqsHBI1b2mYre6pqPaKGaf0H/UEYAr/DdyvpnhiVxftOtRy5QUw+ DRcRDb4JMtn++BOrHNsUOg3TQqIAL3ngy3cyKtAzJB2PHiF0AplvgKSSSzO1jfbpmbuh 5YZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=dUemFRuND8Ok5mURBPwCNxGSCDDRV+nkYo+RrVeyw2I=; b=ca6Kcf928l4lfPkpU6FButsFs+6NpOKkIXDF6gG0chRcvjkkkaSUZzJeFPFvgAVT8m 6vxVFecn4FwPSa709En6nADh3XHQO/7XzDVlZP2t59x9BMwxXZ/Bff4rzDdLhQImx3fQ SiX4zMWwIiePVbVS96TwZ68+YC9ZNB3nabPDuBop6InlkAzTVFQby0IkIttWKn6RNXtA 5IZdJkRSspMaKAouN4s1ht7amTbDvNwayfwp+dFgfbXxqkDV+3ZWSNaIdDS47cs3Is6e 7PWOfzBocu+Rhlwg5awy4tRMp/qthUFXVj2aacVIHnf52AaXmh2UoLZMlxiFPpYYjYk6 /Dqg== X-Gm-Message-State: AOAM533Dl4F2QUiRQIDZYpZi1RGrvCIIhkZqZ6zj/PUb3KBOeroz0n2e 1fp+rsQmxUBjemCIpQhHYG1pwho3lwz0ZeNMbw7kekdJ7oA1+Q== X-Google-Smtp-Source: ABdhPJx318lHtxlc3E6N1qThnTLnjYrSMef1WAeN+jYQyppbTZm/MUp2ddG6h94uRpHdE/EF0Js0y7hIn7dV1Y26zI4= X-Received: by 2002:a05:6512:2351:: with SMTP id p17mr38690529lfu.319.1621194087319; Sun, 16 May 2021 12:41:27 -0700 (PDT) MIME-Version: 1.0 References: <036910d7-71be-4ac5-8f1e-dc58c69e942a@www.fastmail.com> <718561fa-3489-4345-9feb-05c52e4d7fcc@www.fastmail.com> In-Reply-To: From: Marlon Richert Date: Sun, 16 May 2021 22:40:51 +0300 Message-ID: Subject: Re: [PATCH] Improve extra-verbose completion of array params To: Mikael Magnusson Cc: =?UTF-8?Q?Lawrence_Vel=C3=A1zquez?= , Zsh hackers list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 48854 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Sun, May 16, 2021 at 7:18 PM Mikael Magnusson wrote: > > On 5/16/21, Lawrence Vel=C3=A1zquez wrote: > > On Sun, May 9, 2021, at 1:47 PM, Lawrence Vel=C3=A1zquez wrote: > >> On Tue, Apr 27, 2021, at 6:28 AM, Marlon Richert wrote: > >> > This patch improves the extra-verbose completion display strings for > >> > arrays and associative arrays. > >> > >> ping for review > > > > Ping II: The Sequel > > I looked at the patch but there is no description of what the intent > is, so it is impossible for me to say if it achieves it. The code > itself is not exactly self-explanatory... I thought the test changes included made it rather self-explanatory: 0:extra-verbose shows parameter values >line: {: $ba}{} >DESCRIPTION:{parameter} ->NO:{bar -- '^@' '^A' '^B' '^C' '^D' '^E' '^F' '^G' '^H' '\t' '\n' '^K' '^L' '^M} ->NO:{baz -- '^@ ^A ^B ^C ^D ^E ^F ^G ^H \t \n ^K ^L ^M ^N ^O ^P ^Q ^R ^S ^T ^U ^} +>NO:{bar -- ( '^@' '^A' '^B' '^C' '^D' '^E' '^F' '^G' '^H' '\t' '\n' '^K' '^L' '} +>NO:{bat -- ( [' ']=3D'!' ['"']=3D'#' ['$']=3D% ['&']=3D\' ['(']=3D')' ['= *']=3D+ [,]=3D- [.]=3D/} +>NO:{bay -- '^@ ^A ^B ^C ^D ^E ^F ^G ^H \t \n ^K ^L ^M ^N ^O ^P ^Q ^R ^S ^T ^U ^} When using extra-verbose parameter completion, you can now clearly see the difference between the values of scalars, arrays and associative arrays. How about if I change the commit message? Perhaps something like this: Improve formatting of array values in extra-verbose parameter completio= n Make it more visually obvious which values are arrays or associative arrays." Would that help? I'm open to suggestions.