From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 27476 invoked from network); 5 Aug 2021 18:12:30 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 5 Aug 2021 18:12:30 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1628187150; b=lu7ExEyCmVMwpCejVQNFYIPsrC/lbxb74CpwklYH9I64e9mifMlMv3r56BOU/6i0OT4wMj/lTO 2DoYnUpulGY93yYgAkj+MosYVRpRHBM+WRckAMkcKDypJ7pEK2s0ie0N5DWhHBfvr6P2MEUPPF LVBdF6ElJ0atE3n7IeoLaBtihYqSQfVii7H6Oiv7xjJAckdmkU6vdigJMixeUwxwvcJXScDZtG KcvQ+xu6aSMl2nLwaQi7Qn6Y1xaJjqcMDeAjhFl+2GpXaQfK5ol+f7SYIFpJXfxAyZN1Y+5OGY xzgfwdUB7AS8QRm5fGXlsYaxsSKNCa/TevjuVrCgpUltJQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-lf1-f54.google.com) smtp.remote-ip=209.85.167.54; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1628187150; bh=nf+j7NIXiJMkw+MsVgH4/U6yXmHhllMkWliELDExSJQ=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=m8RPjWRDXCp6dutN6JODDO6bKdL2iXeyj+4/TpjY3faTTKbs0TxofFB+reiLDX7sn8dIFUGIz8 GHYu4Ws1Tym8bm0fiSJ+wdyo+yIHinTfud8baxdSfrO3Fbn1nVClJRwn5Ga3zEJ91qefyFPnv7 yO62nHrIcok486HB2d9No7vhR4tDvgD7468BecwOspwTwdIlK32wyRU0ujyLlVhiCZfTLUlv0e Rjrm50qvlucVFA0RuIoPKmKazVa71LSV2+nkfLF+37qC1pQvc58/s69/E5lXEgIKI46B0teVUR tazUdFBbipC7MGxOKpz0iDYOB0y96OFtWb8YCGojZTauvw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=MnKEmWSXTHpkNOU23q2F4VTevuCU+IQHtUe6xgiBLF0=; b=dfR63jbC3v+2heXggI8uLmLhdh XNsKbdf9V7M5nnVO7qp9M+rqbNvQNtWUmMjJKebupfBJRP73YAsECLUmCD4fORKsOl42i3NxJEBxZ RL471WuFgoD+Xq/08fxX5tbryvtsXLTT1c8zY/spjNeu4R/2fgLHe8/Itl5mttGe6P3Q/MUVtQsOB HDzyrxAWVNnF/tWGHoK/XfLeIi3byd9+ZhOkXkwd+NjNA9d5L6nN/n32buUUv3KoyT2o0VG0KM3kh zFSQbPi3EOD8ahfmXHRVUkJukdD0ToVBexLbeRA2gNaIKOzzwDwTeScOvTj74nB8d7b/3F05AgSbJ SvBfHdHw==; Received: from authenticated user by zero.zsh.org with local id 1mBhr4-000COl-CX; Thu, 05 Aug 2021 18:12:30 +0000 Authentication-Results: zsh.org; iprev=pass (mail-lf1-f54.google.com) smtp.remote-ip=209.85.167.54; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-lf1-f54.google.com ([209.85.167.54]:46661) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1mBhqo-000C4t-G4; Thu, 05 Aug 2021 18:12:15 +0000 Received: by mail-lf1-f54.google.com with SMTP id n17so10139315lft.13; Thu, 05 Aug 2021 11:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MnKEmWSXTHpkNOU23q2F4VTevuCU+IQHtUe6xgiBLF0=; b=GaOlsZHU2Uf3eC9YBA88WBMH6WMU9yQI1VEC5YhHL6X+48K+GEALct1ePkNEcFiGXD eqEUtP5n4rwowbRRyFiqTojd0zYQhXLOJxl3jyOTUbl5XjT2AXa1hXG5TkipLkk7wPoU 5gN+DicQPuUNQAs8T/h5Qjd7lZ5E1ZtttNjvs3SmcbbrRrAqQdn3gKSzrJ9+zIqR1869 ZOTgxcccV4w42rOMch+MX1SyWqYGOHPKphuMbraxuVx02tK1mQj9XgILyFfxL8psJS7i gKAjT3PCSal6x8QAzg+APn0pwglgmeXiKZG9s/eSlhEmhkQ9OrZQco6n5q3dmG5OqBjx 1v1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MnKEmWSXTHpkNOU23q2F4VTevuCU+IQHtUe6xgiBLF0=; b=qYKNqe52BY06uIYAZGFGYU0pEy2cuGXPi4OqHLbk0MY+U1iwa5fnmjcN8sjHEMgL9q jk/OMQgrA6iLbeqe1ByTLaa0+QqlI1vr6k9kVsgF3zzRCtGDE7dGnhopOB0hEyCC4ilg fAA3i2gecnKja+d99W9DLxnXOyFJdRNJ5bJc5dmnE2DrGlYOhdVVvz3DeTTZRrJ8qHrC 3viJxzMJxm+oO1iCeOqNo+RPbhr505xjyLTagy8Yny6Udd7mA7x+3svdQLyIyi+5hgC3 C8YnKWyItQUU0RDBXXc+SoKSLvYagy7u8FdCbfZcNwXjCFOTmGVjH/tX0E5jmhfGk9+B kt6Q== X-Gm-Message-State: AOAM531sWc2FXBEYT+Vjk+167iSeks/Lhge6GCWBmn6a0txg6qtYUMzL 3yOFNolIAT2TsMyOABXyhDg4kviK7KaKTf5yceafmh7t8Zo= X-Google-Smtp-Source: ABdhPJzlht5nIKHJMRog+CeQd9yrVYI0f1ZQ0Tj1Cj7xkLjVCdv+LNiZDGzopQ9yK65+WRqHv1HoqfamBu5fpIuwqFc= X-Received: by 2002:ac2:5fe3:: with SMTP id s3mr4524282lfg.319.1628187132371; Thu, 05 Aug 2021 11:12:12 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Marlon Richert Date: Thu, 5 Aug 2021 21:11:36 +0300 Message-ID: Subject: Re: [PATCH] Increase $COLUMNS when generating long option completions To: Bart Schaefer Cc: =?UTF-8?Q?Lawrence_Vel=C3=A1zquez?= , Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 49247 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Thu, Aug 5, 2021 at 9:24 AM Bart Schaefer wrote: > > On Wed, Aug 4, 2021 at 11:20 PM Marlon Richert wrote: > > > > I don't think this all changes anything about the patch, though? > > On Tue, Aug 3, 2021 at 8:48 PM Bart Schaefer wrote: > > > > The next question would be, is _arguments the only place this is > > useful? Or would it be better if _call_program always did so? E.g. > > local -x COLUMNS Sorry, I missed this. I don't know if it makes sense to always set COLUMNS in _call_program, because it is not always called to produce visual output. On the other hand, if you think it won't hurt, then yes, that might be a better option. > If the answer to that is to leave it in _arguments, then I think > COLUMNS=$COLUMNS is preferable to COLUMNS=999 I made it 999, rather than $COLUMNS, because the output is cached and terminal emulators can be resized.