zsh-workers
 help / color / mirror / code / Atom feed
From: Marlon Richert <marlon.richert@gmail.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [RFC][PATCH] Add zrestart()
Date: Tue, 27 Apr 2021 14:37:30 +0300	[thread overview]
Message-ID: <CAHLkEDtR0ym1KP1ma5iFn+_mLpwiDqUTsMMPfn-GGqOM1QqDXA@mail.gmail.com> (raw)
In-Reply-To: <c109abe9-1190-4227-8524-f6f1d1c84e74@www.fastmail.com>

On Mon, Apr 26, 2021 at 10:29 PM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > > > +  local err="$(zsh --interactive --monitor --zle -c '' 2>&1 > /dev/null)"
> > >
> > > Also, I think it's quite a stretch to describe this line as "_tests_
> > > whether the shell is able to restart".
> >
>
> Care to comment about the part of my answer before the "Also", which you
> had snipped?

Sure:

On Mon, Apr 26, 2021 at 6:22 AM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > +  local err="$(zsh --interactive --monitor --zle -c '' 2>&1 > /dev/null)"
>
> This doesn't necessarily restart the _same_ zsh, if there's more than
> one installed.

I think your observation is correct and I was planning to fix it in
the next version of my patch. :)

When I don't reply to a point you make, it means that I either agree
or think it's not worth arguing about, and I've put it on my TODO list
for the next version of my patch. I was trying to be brief and not
post a bunch of agrees/will-dos or quote unnecessarily. But if it's
prefered that I do respond to every point I agree with and/or quote
each part of every email I reply to, just let me know. :)


> > I originally had `zsh -fn <all the dotfiles>`, along the lines of what
> > was suggested earlier, but that test can fail on a valid dotfile that
> > uses dynamically named dirs.
>
> A minimal example of this would not be out of place.

% zsh_directory_name() { [[ $2 == home ]] && reply=($HOME) }
% cd ~[home]; print $?
0
% print 'zsh_directory_name() { [[ $2 == home ]] && reply=($HOME) }
cd ~[home]' > tmp
% zsh -fn tmp
tmp:2: no directory expansion: ~[home]
%


> > Plus, if any dotfile sources other files,
> > those files aren't checked this way at all. The approach above is the
> > only one I've found so far that appears to be completely reliable in
> > determining whether the shell can start up successfully.
> >
> > > This line executes a whole bunch of code you have no control over.
> >
> > It is, however, exactly the code we want to test here.
>
> I'm aware.  However, you aren't "testing" it, you are *running* it.
>
> First, that means the docs are wrong.
>
> Second, that code might do things that are inappropriate for the use-case
> of "testing" the startup code.

When you execute `make check`, does it not _run_ the code? How else
are you going to test it? :)


> Or, in other words: the trick is to throw the bathwater out and
> keep the baby.  Keeping *both* the baby and the bathwater isn't an
> ideal solution.

What exactly here is the "bathwater"? Would it help to mock out
certain features in the subshell that you wouldn't want to actually
run in this test? Would it help to invoke the subshell with -o
RESTRICTED?


  parent reply	other threads:[~2021-04-27 11:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-24 20:50 Marlon Richert
2021-04-26  3:22 ` Daniel Shahaf
2021-04-26 19:03   ` Marlon Richert
2021-04-26 19:29     ` Daniel Shahaf
2021-04-26 23:54       ` Bart Schaefer
2021-04-27 11:42         ` Marlon Richert
2021-04-27 11:49           ` Roman Perepelitsa
2021-04-27 17:49             ` Marlon Richert
2021-04-27 17:57               ` Marlon Richert
2021-04-27 18:37                 ` Bart Schaefer
2021-04-29 13:58           ` Daniel Shahaf
2021-04-27 11:37       ` Marlon Richert [this message]
2021-04-29 14:12         ` Daniel Shahaf
2021-04-30 17:27           ` Marlon Richert
2021-05-09 20:59             ` Lawrence Velázquez
2021-05-09 22:52               ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHLkEDtR0ym1KP1ma5iFn+_mLpwiDqUTsMMPfn-GGqOM1QqDXA@mail.gmail.com \
    --to=marlon.richert@gmail.com \
    --cc=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).