From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 5710 invoked from network); 3 Jun 2021 21:28:12 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 3 Jun 2021 21:28:12 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1622755692; b=sC+E3+Tf370Ni5Qz9Ge0lS31BJSYy0QgMPNYudu0MbGAcHe+lLSchaYKY7ijqvUulMcO9UsiV2 9ZceM10hI5VDzc44+d4fCjkBb1Y0p1TlRlVyqqPCJL2Y10NXTLUqis8ZZEaFQ7mXxi2maUsG3Z iIVIyaD1BiKUCfqlFgBir37K37pgTl91QLCkNKh0Om3wEUrRXO0qHnsMpVTPKKYNo1YVSM0Hez iX0E/8P7G8VUPg2sFq4+T2t1Hrg6107qrI7SM5qXo6GkWDLrQ4vDBZQAwA7bJ5O/CuOQiY28qh ziPQBrnhDggdsiaGR7WqPOjNMZ5TX6sKHfaGGkwYKFeB2Q==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-lf1-f45.google.com) smtp.remote-ip=209.85.167.45; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1622755692; bh=wb9H98qUUi8Ws6/gsvI+WmG68Lgm62U5qd20PCRel8Y=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=IwcXQeb1xLbaLdOf0nm9uV2nlyG0b28fwirctpbdz8wf9WOveq0hEPWaRAyHwIUMIcDaJcJ9Zl dc5jKJ7QCmXQLZs7N7XbiDLnBdrtpa+VNwvspaonG5yWNFsLLCO40te1A5TZ6yIezjo+Afm+bR /DTKQPq8G8wNMV96FrK+QFlCw5Z0Dxu1OsoGb+4/A9A4ATbtnAzsWZuMzppRIqZMWo1jiUfwQQ qJsO7feT2//sd92qjK6it3dF8uSvUYLJpYwPsQMl7otPcBqEQzkfc9Al24A0WHuJdUNpCTt1PP 4j8eqRcE467bItQ9iKHoXOu1u+48YshiEHgykOHgV4wHMg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=YBayv+0vBCw8Oi23ZeNBHq3AwLoj4pJzZIEQSseGeQA=; b=asbg/XZ3x5Zf/sVHajs0vRX9L4 /NT+yPGKO/tRfUo6zEOgjC6UHgPIG8mMrUnArP0szPgOCEebH/PqsXCGphmczMGSo0ASUDifkInUR KmN6O8x0SjZxhrI96yl173vYCnFGuDQVzHOHzRel3178e/jfLHroaOcpOOqYwXYsHKgFG8PIk7Suv t4QXJhPVkgtHdgRT4XW0XOE94z7rp92A3VNUPpHWdGKO81gFHmqKQKQGO2qE+560MpHloACb0ZjmS uiMP4Sj6uczxAMDbjjzKcwGNEx/Lb+f1nG7ydgMuqHTql/njyV7cRIoTft6UtJoWjW0Jk8niJAfZU RmQ9AgaQ==; Received: from authenticated user by zero.zsh.org with local id 1louss-0004S7-IG; Thu, 03 Jun 2021 21:28:10 +0000 Authentication-Results: zsh.org; iprev=pass (mail-lf1-f45.google.com) smtp.remote-ip=209.85.167.45; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-lf1-f45.google.com ([209.85.167.45]:42702) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1lousK-00049u-1t; Thu, 03 Jun 2021 21:27:37 +0000 Received: by mail-lf1-f45.google.com with SMTP id a2so10941884lfc.9 for ; Thu, 03 Jun 2021 14:27:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YBayv+0vBCw8Oi23ZeNBHq3AwLoj4pJzZIEQSseGeQA=; b=siyIt49xYUvXP9AM5ETc0tqCZLAHRlV1s8k5MmaoFCi6zH1t4s45xlT0bVNPGFA0HK XDygDBNe/pvGGjfwQ3azMKiUE6BnUZ4iJQ3FQoi2T4REh0r18RFQeaVpHDOcBNpSHJ5W /wOvFKiprzZ6yuEUdVfbRdesdYTG8AoyZlB2RPWkC076kYWzLaWQ/+OoFbLoaeHeDwpr aS1p6hXHsR64/qiwQBbJZIfrFaKs5TeHfwFvYTQWLhPIi6MIkryuz+6j2pjASP0CGIcm T8cyZnksoD6qp8eZ/75ftMw9GuqwA56Q8ZgNyvnqObXuENMj1B09D1CjT/R5NkJRXgP0 QmDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YBayv+0vBCw8Oi23ZeNBHq3AwLoj4pJzZIEQSseGeQA=; b=VyC0hEH2Kxeu7pbEQC5sN5XOZ0rrJgSlTtDc7+ByVF1ZQ7Iwtngu+K+2T8y3dM06zI 4jiGDZzDWPkGqpUKvJrJHWpUxkNSwEA4JtV2DK+uRAW4zHkKCzAGj+0lWsqjlELNguPi qMHBkSNjMG/7qaztDemGcDahs+ncNOyqT3JoyrUs79LiDV9qGjdUSKuiZ/VzIdixHOOq zQI5GEJ8U+HC1jsuQsb7eGkDCFsdNEqUI0kdOWRnFMqYOcD/jxqacnWRYazROl7Euy1D szLyIbJsu5RPe4/ib2Gen2lt2T+pSOlMb1NGJSM/4wm4DV0Ptw0zt1pb1ioF+2t6PQay U2CQ== X-Gm-Message-State: AOAM532dvHMK0vy4v64BsAyFtTASFc/9FePHiM1GW1634UMvKK9o52fm qEwKrBzZwpemftKuMHx/lVrcokOs1NIdqQkDLI0Vqe4MMuk= X-Google-Smtp-Source: ABdhPJyYtK6AjJVE5VSQApOf8R2ImWLhRk2NfrCKJj7ud2nlSgl/Tq50P+49Tv+gQru+Szh+VTna9clBA7ZOHmqTxrg= X-Received: by 2002:ac2:4e69:: with SMTP id y9mr563140lfs.593.1622755655244; Thu, 03 Jun 2021 14:27:35 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Marlon Richert Date: Fri, 4 Jun 2021 00:26:58 +0300 Message-ID: Subject: Re: Let run-help filter cmd_args before calling run-help- (was Re: [RFC][PATCH] Try calling command with help flags in run-help) To: Bart Schaefer Cc: Zsh hackers list Content-Type: multipart/mixed; boundary="0000000000006370a205c3e33e69" X-Seq: 49006 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: --0000000000006370a205c3e33e69 Content-Type: text/plain; charset="UTF-8" On Thu, Jun 3, 2021 at 7:34 AM Bart Schaefer wrote: > On Wed, Jun 2, 2021 at 1:58 PM Marlon Richert wrote: > > And here's another part of workers 48926 as a separate patch. > > run-help:115: parse error near `]' > > Typo? > + shift -p (( $#cmd_args + 1 - cmd_args[(i)(-|--|;)] )) cmd_args Apparently. But I've removed that line now in the new version of the patch (attached). > This change also breaks the run-help-ssh example in the documentation, > and does so in a way I think it's impossible to fix. > > Stupid example, but: > > % ssh -- localhost date > > Without the patch, run-help displays help for the "date" command. > With it, help for "ssh". That's weird. For me, it gets help for 'ssh', both before and after the patch (on commit bd328a2). > It would not surprise me to find that attempting to generically parse > arguments in run-help would also break helpers for commands like "su" > and "sudo", I tried it, but it doesn't seem to be the case. > or some commands that have git-style sub-commands. My patch actually fixes an annoying case with 'run-help git'. Try pressing ^[h on, for example, 'git -C /path/to/zsh log'. Without my patch, it gives % run-help git git is /usr/bin/git error: invalid key: alias.-C No manual entry for git--C With my patch, it correctly displays help for 'git log'. Anyway, here's a new version of my patch. Let me know what you think. --0000000000006370a205c3e33e69 Content-Type: text/plain; charset="UTF-8"; name="0001-Let-run-help-filter-cmd_args-before-calling-run-help.txt" Content-Disposition: attachment; filename="0001-Let-run-help-filter-cmd_args-before-calling-run-help.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kpheo9vj0 RnJvbSAxZDIzNDljMGQ5ZGNhYWE4YjQ2NDc0MWVkNWE2MDhjNmYxZWIzMmQxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJsb24gUmljaGVydCA8bWFybG9uLnJpY2hlcnRAZ21haWwu Y29tPgpEYXRlOiBGcmksIDQgSnVuIDIwMjEgMDA6MjI6NTkgKzAzMDAKU3ViamVjdDogW1BBVENI XSBMZXQgcnVuLWhlbHAgZmlsdGVyICRjbWRfYXJncyBiZWZvcmUgY2FsbGluZwogcnVuLWhlbHAt PGNvbW1hbmQ+Ck1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hh cnNldD1VVEYtOApDb250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0CgrigKZ0byBtYWtlIGl0 IGVhc2llciB0byB3cml0ZSBydW4taGVscC08Y29tbWFuZD4gZnVuY3Rpb25zLgotLS0KIEZ1bmN0 aW9ucy9NaXNjL3J1bi1oZWxwICAgICAgIHwgMTUgKysrKysrKysrLS0tLS0tCiBGdW5jdGlvbnMv TWlzYy9ydW4taGVscC1idHJmcyB8ICA0IC0tLS0KIEZ1bmN0aW9ucy9NaXNjL3J1bi1oZWxwLWlw ICAgIHwgIDQgLS0tLQogRnVuY3Rpb25zL01pc2MvcnVuLWhlbHAtcDQgICAgfCAgMiArLQogRnVu Y3Rpb25zL01pc2MvcnVuLWhlbHAtc3ZrICAgfCAgMiArLQogRnVuY3Rpb25zL01pc2MvcnVuLWhl bHAtc3ZuICAgfCAgMiArLQogNiBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAxNyBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9GdW5jdGlvbnMvTWlzYy9ydW4taGVscCBiL0Z1bmN0 aW9ucy9NaXNjL3J1bi1oZWxwCmluZGV4IGUzNTFkZDZhNi4uOTE5ODk5YTEzIDEwMDY0NAotLS0g YS9GdW5jdGlvbnMvTWlzYy9ydW4taGVscAorKysgYi9GdW5jdGlvbnMvTWlzYy9ydW4taGVscApA QCAtMTAxLDEyICsxMDEsMTUgQEAgZG8KIAkJYnVpbHRpbiBnZXRsbiBjbWRfYXJncwogCQlidWls dGluIHByaW50IC16ICIkY21kX2FyZ3MiCiAJCWNtZF9hcmdzPSggJHsoeiljbWRfYXJnc30gKQot CQkjIERpc2NhcmQgZW52aXJvbm1lbnQgYXNzaWdubWVudHMsIGV0Yy4KLQkJd2hpbGUgW1sgJGNt ZF9hcmdzWzFdICE9ICR7cnVuX2hlbHBfb3JpZ19jbWQ6LSQxfSBdXQotCQlkbwotCQkgICAgc2hp ZnQgY21kX2FyZ3MgfHwgcmV0dXJuIDEKLQkJZG9uZQotCQlldmFsICJydW4taGVscC0kMTp0ICR7 KHFAKWNtZF9hcmdzWzIsLTFdfSIKKyAgICAgICAgICAgICAgICAKKyAgICAgICAgICAgICAgICAj IERpc2NhcmQgdGhlIGNvbW1hbmQgaXRzZWxmICYgZXZlcnl0aGluZyBiZWZvcmUgaXQuCisgICAg ICAgICAgICAgICAgc2hpZnQgJGNtZF9hcmdzWyhpKSR7cnVuX2hlbHBfb3JpZ19jbWQ6LSQxfV0g Y21kX2FyZ3MgfHwKKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuCisgICAgICAgICAgICAgICAg CisgICAgICAgICAgICAgICAgIyBEaXNjYXJkIG9wdGlvbnMsIHBhcmFtZXRlciBhc3NpZ25tZW50 cyAmIHBhdGhzLgorICAgICAgICAgICAgICAgIGNtZF9hcmdzPSggJHtjbWRfYXJnc1tAXTojKFst K10qfCo9KnwqLyp8XH4qKX0gKQorICAgICAgICAgICAgICAgIAorICAgICAgICAgICAgICAgIGV2 YWwgInJ1bi1oZWxwLSQxOnQgJHsoQHEpY21kX2FyZ3N9IgogCSAgICBlbHNlCiAJCVBPU0lYTFlf Q09SUkVDVD0xIG1hbiAkQDp0CiAJICAgIGZpCmRpZmYgLS1naXQgYS9GdW5jdGlvbnMvTWlzYy9y dW4taGVscC1idHJmcyBiL0Z1bmN0aW9ucy9NaXNjL3J1bi1oZWxwLWJ0cmZzCmluZGV4IDBkYzFk YWJjYi4uY2IxMzllOWI3IDEwMDY0NAotLS0gYS9GdW5jdGlvbnMvTWlzYy9ydW4taGVscC1idHJm cworKysgYi9GdW5jdGlvbnMvTWlzYy9ydW4taGVscC1idHJmcwpAQCAtMSw3ICsxLDMgQEAKLXdo aWxlIFtbICQjICE9IDAgJiYgJDEgPT0gLSogXV07IGRvCi0gICAgc2hpZnQKLWRvbmUKLQogY2Fz ZSAkMSBpbgogICAgIChiKikgICAgbWFuIGJ0cmZzLWJhbGFuY2UgICAgICAgICAgOzsKICAgICAo YyopICAgIG1hbiBidHJmcy1jaGVjayAgICAgICAgICAgIDs7CmRpZmYgLS1naXQgYS9GdW5jdGlv bnMvTWlzYy9ydW4taGVscC1pcCBiL0Z1bmN0aW9ucy9NaXNjL3J1bi1oZWxwLWlwCmluZGV4IDg4 MDdmOWVmMS4uYjgxMWNlMzUyIDEwMDY0NAotLS0gYS9GdW5jdGlvbnMvTWlzYy9ydW4taGVscC1p cAorKysgYi9GdW5jdGlvbnMvTWlzYy9ydW4taGVscC1pcApAQCAtMTQsMTAgKzE0LDYgQEAgaWYg ISBtYW4gLXcgaXAtYWRkcmVzcyA+L2Rldi9udWxsIDI+JjE7IHRoZW4KICAgICByZXR1cm4KIGZp CiAKLXdoaWxlIFtbICQjICE9IDAgJiYgJDEgPT0gLSogXV07IGRvCi0gICAgc2hpZnQKLWRvbmUK LQogY2FzZSAkMSBpbgogICAgIChhZGRybCopIG1hbiBpcC1hZGRybGFiZWwgOzsKICAgICAoYSop IG1hbiBpcC1hZGRyZXNzIDs7CmRpZmYgLS1naXQgYS9GdW5jdGlvbnMvTWlzYy9ydW4taGVscC1w NCBiL0Z1bmN0aW9ucy9NaXNjL3J1bi1oZWxwLXA0CmluZGV4IDY2MmNlOTRmZS4uZTQ4YTRkMDY4 IDEwMDY0NAotLS0gYS9GdW5jdGlvbnMvTWlzYy9ydW4taGVscC1wNAorKysgYi9GdW5jdGlvbnMv TWlzYy9ydW4taGVscC1wNApAQCAtMiw0ICsyLDQgQEAgaWYgKCggISAkIyApKTsgdGhlbgogICBw NCBoZWxwIGNvbW1hbmRzCiBlbHNlCiAgIHA0IGhlbHAgJDEKLWZpIHwgJHs9UEFHRVI6LWxlc3N9 CitmaSB8ICR7PVBBR0VSOi1tb3JlfQpkaWZmIC0tZ2l0IGEvRnVuY3Rpb25zL01pc2MvcnVuLWhl bHAtc3ZrIGIvRnVuY3Rpb25zL01pc2MvcnVuLWhlbHAtc3ZrCmluZGV4IDkyNDM4YTUzZi4uNzgy NTM4MjQ2IDEwMDY0NAotLS0gYS9GdW5jdGlvbnMvTWlzYy9ydW4taGVscC1zdmsKKysrIGIvRnVu Y3Rpb25zL01pc2MvcnVuLWhlbHAtc3ZrCkBAIC0xICsxIEBACi1zdmsgaGVscCAkeyR7QDojLSp9 WzFdfSB8ICR7PVBBR0VSOi1tb3JlfQorc3ZrIGhlbHAgJDEgfCAkez1QQUdFUjotbW9yZX0KZGlm ZiAtLWdpdCBhL0Z1bmN0aW9ucy9NaXNjL3J1bi1oZWxwLXN2biBiL0Z1bmN0aW9ucy9NaXNjL3J1 bi1oZWxwLXN2bgppbmRleCA1ZDEwNjg1ODguLmQ1NWE0OTNhNiAxMDA2NDQKLS0tIGEvRnVuY3Rp b25zL01pc2MvcnVuLWhlbHAtc3ZuCisrKyBiL0Z1bmN0aW9ucy9NaXNjL3J1bi1oZWxwLXN2bgpA QCAtMSArMSBAQAotc3ZuIGhlbHAgJHske0A6Iy0qfVsxXX0gfCAkez1QQUdFUjotbW9yZX0KK3N2 biBoZWxwICQxIHwgJHs9UEFHRVI6LW1vcmV9Ci0tIAoyLjMwLjEgKEFwcGxlIEdpdC0xMzApCgo= --0000000000006370a205c3e33e69--