Can someone please review Roman's patch (attached)? On Tue, Oct 13, 2020 at 2:05 PM Roman Perepelitsa wrote: > On Mon, Oct 12, 2020 at 11:23 AM Marlon Richert > wrote: > > 1. It seems incorrect to convert `fg=default` to `none`. From reading the [documentation](http://zsh.sourceforge.net/Doc/Release/Zsh-Line-Editor.html#Character-Highlighting), `none` is not supposed to be the same as `fg=default`. > > I took a quick look at this yesterday. When you print region_highlight > and "fg=default" comes out as "none", that's a bug in the printing > logic (function output_highlight in Src/prompt.c). It's fairly easy to > fix -- patch below (only for fg; bg should be handled similarly). > Naturally, it doesn't solve the other issues you've described. I > haven't looked at why the highlight doesn't get applied as it should > be.