From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 16172 invoked from network); 31 Mar 2021 08:25:02 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 31 Mar 2021 08:25:02 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1617179102; b=PUSptK8HTZtqgQKcWybmpWqLNoIA8topT7o1adZN1NerYuTJBd5tkA2mbqfOYrdfLeGCR+HMpm wKE469IG0rP7E0mDjWW2jIltgQGLFXgLWElHDSoPE1TDXvx3NFpvSitGlWJ0AkF8Kx8ClA8MbN 8IZ26tQrESBRm/aQEYukH5HWKcvHIuChp7r33aNFpSksuv7uITvdXwrjv7E3SVtRmhjLfJESoQ wsp7jtmIbvuezMfQBhsB/MREi6IkTeRYwIyzHdFNvQz2ApaUNw3LbCNguJeS3fWRNcntsMgTF0 yfXFnwAYdWgmfrUquPj8U6dQ3sfL/4MPnNKhIgkU46Oqmg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-lf1-f52.google.com) smtp.remote-ip=209.85.167.52; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1617179102; bh=CamUS+ckwqsPaiBHI+isvTi+1/6eBPDqQ5Cy4iSt6gE=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=Pqchv8gFSRx7Jp38UYyC9hWmCOq1kyVSFcOS3pLNFb+E++GwPIkFsSduRl/ArPG1aRLxIz6FmO mZSzA6p2jebSrabQrh/TjqzmxeeA8pCcznnK8eK477uSmhp6LFciMosejfiPx9PoR8MmlLF3KS JJh3i3cYho8ohjtqWt3FbfXXvQ315jcbPoTdeHLMxfhZSPzURVEV2Fgc5auXofhkmRsInuiWbI 22zdUO0Hdq0wE7buhPQvAO/DckGauNRVljH07zwTi9yampZTK0u8OE2H2AEJm5lslFVtfZNDj4 VJkQTXWa3RY8O5ZN/HgtJk9NFg7jGmwTD2fTo0olTGL+1A==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:To:Subject:Message-ID: Date:From:In-Reply-To:References:MIME-Version:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=xTKZSRAuo9wfdzx8HpsG/GLl7XSsIUYWkJBJa/eHa1c=; b=HAOkii/sK738lQd2ij9EoqWh62 49PQRFurskNFjeplqglyCqCEBbANaFTajcn/3mmoS2AKBF80wDg8uwt4zJ92YlBYH9i5pMERsHPY/ Y50t570h3PjCMVIvX0bK18L1GDz6dKzzmjdg8TxJyBB3yaWnZp1mPlXgjlRNqObnrrFMOwr5lGxzu xf2UK9oAhdmDbdiuDFDuPb/ctHaT0/PnReeEzcMKlJlmqnJLP0/S34tH7MkZmK2IKWMYSPK6GNCee UjDce5i6jkT94/4qS+b8nXM85J8ZTGvx3QcJRWFTpZANZpYHPox8lhDs8IOSrT1Wu5Bao9jRBqOXg yfJg/okA==; Received: from authenticated user by zero.zsh.org with local id 1lRW9u-000Dr0-4X; Wed, 31 Mar 2021 08:25:02 +0000 Authentication-Results: zsh.org; iprev=pass (mail-lf1-f52.google.com) smtp.remote-ip=209.85.167.52; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-lf1-f52.google.com ([209.85.167.52]:33695) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1lRW9Z-000DgQ-Qd; Wed, 31 Mar 2021 08:24:42 +0000 Received: by mail-lf1-f52.google.com with SMTP id o126so27957548lfa.0 for ; Wed, 31 Mar 2021 01:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=xTKZSRAuo9wfdzx8HpsG/GLl7XSsIUYWkJBJa/eHa1c=; b=dZZzourkB3aNWsWTWa9ummYDr6vh2jtqhD6CMzjuT6BkW47rj9TW9lHviOsznK3l83 qAZYx1nCUixJkUkzGZXNxXELMtyrvLQoiKrkKfDbc6SNtQLUre/kf3t2lV43vrXHJ/uW lnlEs8r9sIGmvuD/qLO61nvXux0PQN0gZcGCtCqmZHnP8WYZMiNHd504ALNJJDjCV+sQ xWsvIRCMZe8qkfMJ/FoGxGxHUL59Xn3jepHbVCXJFUoWeWQjqWd33LK89VIF3CP0corK 5Ui6+D1DJxvxD3jvWNaHY03ID1JpMWQ8VBhOH0dECMGQpiNAdOz0q8Wmne1Jy4X4RSCK cYdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=xTKZSRAuo9wfdzx8HpsG/GLl7XSsIUYWkJBJa/eHa1c=; b=KsxdnRA2JQyf7D6NXTJPgajJ2zAI4vfxFie1urbahQjVgoHJwAR4cxxhcCbzCb21FL Kge0vQpaH9yOJ+zpdxNjRQMu2kKnjy5pZIxEppORJ00SqwpXmkvqtAyVON+6sLltdMLt cuBO2IhOxyWRc9vQb2BZdkOfjyrVrwfa2Ugy/V1PVmAsl0NB+EEwJRUYPPLrILiNaYlR GY790QZFpZpn1+tEkmuuJCkBJDo5TWbNebFdS0drSD9cIJ2+s/D46eMGQ8eb/ed9opzg LxLUc9ZcKUEhdLFhtkx/YgVZ9aAvyExIocFjVhPkyszLUyyv1QUWlq43VmfH+tplAnzU l9/g== X-Gm-Message-State: AOAM532NMo/PQPrQwyCacaXUfAvICkNSSRy/KKvwGANea6ezWXBDIWiX mmgvBiuVm6IFpEFNRFVsgBTzIC0R7a7NgkOKZ34mTijIuas= X-Google-Smtp-Source: ABdhPJyDQaaL2TnZW4VZbuQWd7IjSocYQDwpNySEVSZb9Bll3kIjZ96l12/FaO3yL/h9OJTun6NvvMZ3PKa2p2dDLIA= X-Received: by 2002:a19:a40c:: with SMTP id q12mr1520903lfc.319.1617179081029; Wed, 31 Mar 2021 01:24:41 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Marlon Richert Date: Wed, 31 Mar 2021 11:24:04 +0300 Message-ID: Subject: Re: region_highlight converts `fg=default` to `none`, which is not the same To: Zsh hackers list Content-Type: multipart/mixed; boundary="000000000000aa17d905bed0d8e2" X-Seq: 48343 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: --000000000000aa17d905bed0d8e2 Content-Type: text/plain; charset="UTF-8" Can someone please review Roman's patch (attached)? On Tue, Oct 13, 2020 at 2:05 PM Roman Perepelitsa wrote: > On Mon, Oct 12, 2020 at 11:23 AM Marlon Richert > wrote: > > 1. It seems incorrect to convert `fg=default` to `none`. From reading the [documentation](http://zsh.sourceforge.net/Doc/Release/Zsh-Line-Editor.html#Character-Highlighting), `none` is not supposed to be the same as `fg=default`. > > I took a quick look at this yesterday. When you print region_highlight > and "fg=default" comes out as "none", that's a bug in the printing > logic (function output_highlight in Src/prompt.c). It's fairly easy to > fix -- patch below (only for fg; bg should be handled similarly). > Naturally, it doesn't solve the other issues you've described. I > haven't looked at why the highlight doesn't get applied as it should > be. --000000000000aa17d905bed0d8e2 Content-Type: text/plain; charset="US-ASCII"; name="output-highlight-patch.txt" Content-Disposition: attachment; filename="output-highlight-patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kg7uyy7s0 ZGlmZiAtLWdpdCBhL1NyYy9wcm9tcHQuYyBiL1NyYy9wcm9tcHQuYwppbmRleCA5OTczMjdlMTgu LjM2YzgyODMyMSAxMDA2NDQKLS0tIGEvU3JjL3Byb21wdC5jCisrKyBiL1NyYy9wcm9tcHQuYwpA QCAtMTg0Miw2ICsxODQyLDEzIEBAIG91dHB1dF9oaWdobGlnaHQoemF0dHIgYXRyLCBjaGFyICpi dWYpCiAJYXRybGVuICs9IGxlbjsKIAlpZiAoYnVmKQogCSAgICBwdHIgKz0gbGVuOworICAgIH0g ZWxzZSBpZiAoYXRyICYgVFhUTk9GR0NPTE9VUikgeworCWxlbiA9IDEwOworCWF0cmxlbiArPSBs ZW47CisJaWYgKGJ1ZikgeworCSAgICBzdHJjcHkocHRyLCAiZmc9ZGVmYXVsdCIpOworCSAgICBw dHIgKz0gbGVuOworICB9CiAgICAgfQogICAgIGlmIChhdHIgJiBUWFRCR0NPTE9VUikgewogCWlm IChhdHJsZW4pIHsK --000000000000aa17d905bed0d8e2--