From: Wayne Davison <wayned@users.sourceforge.net>
To: zsh-workers@zsh.org
Subject: Re: ommitted time on resume
Date: Sat, 6 Aug 2011 12:45:28 -0700 [thread overview]
Message-ID: <CAHSx_SuD-_Sfvw2eUFLyFPZHhzuEK+7mqQJk_iCAqmbMLBn6GQ@mail.gmail.com> (raw)
In-Reply-To: <CAHSx_Ss6c1S9KRi8aco+CegZn63s_Da_UmCSTS8fckWRB7Jy=g@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 875 bytes --]
Another potential fix would be to change the hiding choices of the jobs so
that the "jobs" output would show the pieces of the pipeline, more like when
a non-time-using pipeline is used. For example, if I suspend "sleep 5 | cat
~/foo/*(^/) | wc", jobs shows me the various pieces of the pipeline (as
would continue):
[1] + suspended sleep 5 |
done cat ~/foo/*(^/) | wc
I created the attached simple patch to test this, but it doesn't really work
right -- it doesn't hide the super job (which might be a good thing), and it
prints superfluous "done" messages at the end of the run. I'm not going to
fiddle with this anymore, since my prior patch seems like a reasonable fix,
and the changing of the jobs output when suspending a newly-created
super-job seems like a separate issue (but one that could also fix the time
issue in a different way).
..wayne..
[-- Attachment #1.2: Type: text/html, Size: 1032 bytes --]
[-- Attachment #2: time-suspend2.patch --]
[-- Type: text/x-patch, Size: 553 bytes --]
index 6320f6a..7170652 100644
--- a/Src/exec.c
+++ b/Src/exec.c
@@ -1549,8 +1549,8 @@ execpline(Estate state, wordcode slcode, int how, int last1)
* normal (non-super-) job. */
if (!(jn->stat & STAT_DONE)) {
jobtab[list_pipe_job].other = newjob;
- jobtab[list_pipe_job].stat |= STAT_SUPERJOB;
- jn->stat |= STAT_SUBJOB | STAT_NOPRINT;
+ jobtab[list_pipe_job].stat |= STAT_SUPERJOB | STAT_NOPRINT;
+ jn->stat |= STAT_SUBJOB;
jn->other = pid;
}
if ((list_pipe || last1) && hasprocs(list_pipe_job))
prev parent reply other threads:[~2011-08-06 19:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-05 23:21 Wayne Davison
2011-08-06 3:17 ` Bart Schaefer
2011-08-06 19:20 ` Wayne Davison
2011-08-06 19:45 ` Wayne Davison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHSx_SuD-_Sfvw2eUFLyFPZHhzuEK+7mqQJk_iCAqmbMLBn6GQ@mail.gmail.com \
--to=wayned@users.sourceforge.net \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).